From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19D97C10F13 for ; Thu, 11 Apr 2019 07:50:04 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D8D0821841 for ; Thu, 11 Apr 2019 07:50:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="uG1z7q1B" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D8D0821841 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=X/G0/Tvwgjg+1MZA9cIj27D+t4x1BMuLnKlOxA02xbQ=; b=uG1z7q1Bk2pQqj+yhVxQF9RJw DoMsa3IaHA6oGSSGu5oKu8UbUzvV1ihNjKmkvMqRmZmlMFcvInays8ClYcdteI20Q2KtngVk9eaxG mMzveZ7hiT5mY5/Rwf+XB7PL56lgkHVZvsIBYK0IXvmdT/vxbn7Rw5/9UIJ3moKiA1mazVdCSDlHY l5CiXxKsWWEdQTTOhkmnDjszeiNAYaQro7Hl3SGMzte55h4berSjU3ZTp6Q/gOdHzVsl4RRGNrjMD uDr0SIXB3z1DFuovjIIm0bYHf8oESt0cK4JWwUxEGmjJJJRg0Sbw0GRAPeaC1E3uc0Nrla7UeoTeL u+43wVMFQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hEUT5-0003j6-PK; Thu, 11 Apr 2019 07:49:55 +0000 Received: from relay11.mail.gandi.net ([217.70.178.231]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hEUT1-0003iB-SY for linux-arm-kernel@lists.infradead.org; Thu, 11 Apr 2019 07:49:53 +0000 Received: from localhost (aaubervilliers-681-1-63-121.w90-88.abo.wanadoo.fr [90.88.18.121]) (Authenticated sender: maxime.ripard@bootlin.com) by relay11.mail.gandi.net (Postfix) with ESMTPSA id C3C96100016; Thu, 11 Apr 2019 07:49:38 +0000 (UTC) Date: Thu, 11 Apr 2019 09:49:38 +0200 From: Maxime Ripard To: Frank Lee Subject: Re: [PATCH v2 2/2] dt-bindings: cpufreq: Document operating-points-v2-sunxi-cpu Message-ID: <20190411074938.z6gygxfcj43giz57@flea> References: <20190409172558.18778-1-tiny.windzz@gmail.com> <20190409172558.18778-3-tiny.windzz@gmail.com> <20190410145659.62nl4o2jvkuggmpe@flea> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20180716 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190411_004952_227260_F208F459 X-CRM114-Status: GOOD ( 24.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nm@ti.com, mark.rutland@arm.com, Linux PM , sboyd@kernel.org, vireshk@kernel.org, rjw@rjwysocki.net, Linux Kernel Mailing List , Chen-Yu Tsai , robh+dt@kernel.org, Linux ARM , Greg Kroah-Hartman , mchehab+samsung@kernel.org, davem@davemloft.net, devicetree@vger.kernel.org Content-Type: multipart/mixed; boundary="===============5976025105469740039==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============5976025105469740039== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ar5gkwcb4uiazh5y" Content-Disposition: inline --ar5gkwcb4uiazh5y Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Apr 11, 2019 at 01:49:39AM +0800, Frank Lee wrote: > On Wed, Apr 10, 2019 at 10:57 PM Maxime Ripard > wrote: > > > > On Tue, Apr 09, 2019 at 01:25:58PM -0400, Yangtao Li wrote: > > > Allwinner Process Voltage Scaling Tables defines the voltage and > > > frequency value based on the speedbin blown in the efuse combination. > > > The sunxi-cpufreq-nvmem driver reads the efuse value from the SoC to > > > provide the OPP framework with required information. > > > This is used to determine the voltage and frequency value for each > > > OPP of operating-points-v2 table when it is parsed by the OPP framework. > > > > > > The "operating-points-v2-sunxi-cpu" DT extends the "operating-points-v2" > > > with following parameters: > > > - nvmem-cells (NVMEM area containig the speedbin information) > > > - opp-microvolt-: voltage in micro Volts. > > > At runtime, the platform can pick a and matching > > > opp-microvolt- property > > > > > > Signed-off-by: Yangtao Li > > > --- > > > .../bindings/opp/sunxi-nvmem-cpufreq.txt | 166 ++++++++++++++++++ > > > 1 file changed, 166 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/opp/sunxi-nvmem-cpufreq.txt > > > > > > diff --git a/Documentation/devicetree/bindings/opp/sunxi-nvmem-cpufreq.txt b/Documentation/devicetree/bindings/opp/sunxi-nvmem-cpufreq.txt > > > new file mode 100644 > > > index 000000000000..c81a2075b974 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/opp/sunxi-nvmem-cpufreq.txt > > > @@ -0,0 +1,166 @@ > > > +Allwinner Technologies, Inc. NVMEM CPUFreq and OPP bindings > > > +=================================== > > > + > > > +For some SoCs, the CPU frequency subset and voltage value of each OPP > > > +varies based on the silicon variant in use. Allwinner Process Voltage > > > +Scaling Tables defines the voltage and frequency value based on the > > > +speedbin blown in the efuse combination. The sunxi-cpufreq-nvmem driver > > > +reads the efuse value from the SoC to provide the OPP framework with > > > +required information. > > > + > > > +Required properties: > > > +-------------------- > > > +In 'cpus' nodes: > > > +- operating-points-v2: Phandle to the operating-points-v2 table to use. > > > + > > > +In 'operating-points-v2' table: > > > +- compatible: Should be > > > + - 'operating-points-v2-sunxi-cpu'. > > > > Vendor-specific compatibles should have the vendor mentionned. > > > > Also, even though the H6 is the only SoC so far that has needed this, > > we can't really assume that it will be the only SoC to use it, or that > > it will always behave like that. > > There is no doubt that many platforms need this. That many platform *may* need this, yeah, sure. We can probably even share the same driver for them. That all of those theretical platform will have the exact same behaviour, down to how the data is stored in the nvmem, and how many bins you have? I seriously doubt so. > > So having something like allwinner,sun50i-h6-operating-points would be > > great. > allwinner,cpu-operating-points-v2 Maybe better? No. You need to have the SoC name in there, and you can drop the v2. There's never been a v1. Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --ar5gkwcb4uiazh5y Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXK7xkgAKCRDj7w1vZxhR xaAhAP9mCtA9PL96fROyWgoWeKqRtTOzgxofM1fFfIWQI0WIYgEAjKbvK2Xm9ckT sy+VyxscwMnLi1Fb5bC3INUKJVbhhw8= =T5TI -----END PGP SIGNATURE----- --ar5gkwcb4uiazh5y-- --===============5976025105469740039== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============5976025105469740039==--