From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 716F2C10F14 for ; Thu, 11 Apr 2019 15:00:41 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3FAF42073F for ; Thu, 11 Apr 2019 15:00:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="O0iWi9uj" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3FAF42073F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=atomide.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hWj5A9p8oeavqKMEKdq06iO8xwg42SlblysE62xXfkw=; b=O0iWi9uj8Ey3R4 W4ekb4SgoyOAZP5khqtb82U90XxY36/kUkl/+yvww1deDNuO08zxANy5qAS6yArnR98aPGGThBjEP ud/JSe/1jUxurCwLMokW9X6ZpxM9fJT/ZHl6QQM+eA4clwc7NT/XDSuuEBOufJ+XeFlW+/Bz3omlO LrEpQ4/fdB92Y3u4w3HcmHDrNO5z6hiioHN0SPsEHxPUDRrt3q+a6wtk+dn1/+mrVKvMHGzfeGUN9 itqJjlR3xTSWcmwAnBUscMZIULs7tuiJiC6Tft3eCGVzEyhhtT9JIpEapQlgowPT/geJc9DMUyInc ribAYOoxRaTY2FGHe8gg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hEbBs-0004A0-ER; Thu, 11 Apr 2019 15:00:36 +0000 Received: from muru.com ([72.249.23.125]) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hEbBj-0003z0-7X for linux-arm-kernel@lists.infradead.org; Thu, 11 Apr 2019 15:00:28 +0000 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 71BC0810D; Thu, 11 Apr 2019 15:00:41 +0000 (UTC) Date: Thu, 11 Apr 2019 08:00:23 -0700 From: Tony Lindgren To: Lokesh Vutla Subject: Re: [PATCH v6 06/12] dt-bindings: irqchip: Introduce TISCI Interrupt router bindings Message-ID: <20190411150023.GQ2839@atomide.com> References: <20190410041358.16809-1-lokeshvutla@ti.com> <20190410041358.16809-7-lokeshvutla@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190410041358.16809-7-lokeshvutla@ti.com> User-Agent: Mutt/1.11.4 (2019-03-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190411_080027_308701_F4F24DDA X-CRM114-Status: UNSURE ( 8.30 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nishanth Menon , Device Tree Mailing List , Grygorii Strashko , jason@lakedaemon.net, Peter Ujfalusi , Marc Zyngier , Sekhar Nori , linux-kernel@vger.kernel.org, Tero Kristo , Rob Herring , Santosh Shilimkar , Linux ARM Mailing List Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, * Lokesh Vutla [190410 04:15]: > +Example: > +-------- > +The following example demonstrates both interrupt router node and the consumer > +node(main gpio) on the AM654 SoC: > + > +main_intr: interrupt-controller0 { > + compatible = "ti,sci-intr"; > + ti,intr-trigger-type = <1>; > + interrupt-controller; > + interrupt-parent = <&gic500>; > + #interrupt-cells = <3>; > + ti,sci = <&dmsc>; > + ti,sci-dst-id = <56>; > + ti,sci-rm-range-girq = <0x1>; > +}; To me it seems there should not be too many of these interrupt controller nodes for each SoC. Maybe you're already planning on doing it, but I suggest that you just add more specific compatibles and then look up the dst-id from a mapping table in the driver similar to what patch 04/12 in this series is already doing. That way you don't need to add custom TI specific (firmware defined) device tree properties listed above ;) Regards, Tony _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel