From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC47BC10F13 for ; Thu, 11 Apr 2019 15:03:44 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9DDD42184B for ; Thu, 11 Apr 2019 15:03:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="e9pN4gYo" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9DDD42184B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=aTH3KIgy/WmCgR3uL2Q5o4kVyBX1n2h6hXGifMVMC/E=; b=e9pN4gYoabCPmO 3BqsRn0tp1TFFQi7oMrQ/5d0TxZ+YRBQqZyzTiZ1BTPOed+U1EtEN+Ls8stEQqrO722b795lJTSof /3ZkUktE7qY7RzaSmhFD9a8e1/01RxnmWx/be5mjbnV6zKUqr7u0KW4Jj2djF8ujqNgZFfBIC0KJT EMK4pulsDzCfStIDGshL14wuMrNftNwHy8yOnNCmVh1Y4ecGxlNI8V5EUjG2WakG1O7q1p39RwHqf b6GSK/5IUPUfNWHtP7jE12bbtj5yy9n00/6vTJz1Rt0zm785k8V5ID0RLeo6GlFqT6Pf1jwB7rYVN p//zf1NxHAHSU609kW5A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hEbEr-0005Gj-0R; Thu, 11 Apr 2019 15:03:41 +0000 Received: from foss.arm.com ([217.140.101.70]) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hEbEo-0005GF-JJ for linux-arm-kernel@lists.infradead.org; Thu, 11 Apr 2019 15:03:39 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id ADD11A78; Thu, 11 Apr 2019 08:03:37 -0700 (PDT) Received: from red-moon (unknown [10.1.197.39]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B3C5A3F68F; Thu, 11 Apr 2019 08:03:34 -0700 (PDT) Date: Thu, 11 Apr 2019 16:03:32 +0100 From: Lorenzo Pieralisi To: Kishon Vijay Abraham I Subject: Re: [PATCH v3 12/26] PCI: keystone: Prevent ARM32 specific code to be compiled for ARM64 Message-ID: <20190411150332.GC6862@red-moon> References: <20190325093947.32633-1-kishon@ti.com> <20190325093947.32633-13-kishon@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190325093947.32633-13-kishon@ti.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190411_080338_643497_3DAE93F1 X-CRM114-Status: GOOD ( 18.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Jesper Nilsson , Arnd Bergmann , Greg Kroah-Hartman , Gustavo Pimentel , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@axis.com, Minghuan Lian , Rob Herring , Murali Karicheri , Jingoo Han , Bjorn Helgaas , Mingkai Hu , linux-omap@vger.kernel.org, Roy Zang , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Mar 25, 2019 at 03:09:33PM +0530, Kishon Vijay Abraham I wrote: > hook_fault_code is an ARM32 specific API for hooking into data abort. > Since pci-keystone.c will be used for AM65X platforms which is an > ARM64 platform, Hi Kishon, How is the problem plugged by the fault hook fixed on ARM64 ? Thanks, Lorenzo > allow hook_fault_code to be compiled only for ARM32. > > Signed-off-by: Kishon Vijay Abraham I > --- > drivers/pci/controller/dwc/pci-keystone.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/pci/controller/dwc/pci-keystone.c b/drivers/pci/controller/dwc/pci-keystone.c > index dfe54553d832..93296d434f40 100644 > --- a/drivers/pci/controller/dwc/pci-keystone.c > +++ b/drivers/pci/controller/dwc/pci-keystone.c > @@ -710,6 +710,7 @@ static int ks_pcie_config_legacy_irq(struct keystone_pcie *ks_pcie) > return ret; > } > > +#ifdef CONFIG_ARM > /* > * When a PCI device does not exist during config cycles, keystone host gets a > * bus error instead of returning 0xffffffff. This handler always returns 0 > @@ -729,6 +730,7 @@ static int ks_pcie_fault(unsigned long addr, unsigned int fsr, > > return 0; > } > +#endif > > static int __init ks_pcie_init_id(struct keystone_pcie *ks_pcie) > { > @@ -778,12 +780,14 @@ static int __init ks_pcie_host_init(struct pcie_port *pp) > if (ret < 0) > return ret; > > +#ifdef CONFIG_ARM > /* > * PCIe access errors that result into OCP errors are caught by ARM as > * "External aborts" > */ > hook_fault_code(17, ks_pcie_fault, SIGBUS, 0, > "Asynchronous external abort"); > +#endif > > ks_pcie_start_link(pci); > dw_pcie_wait_for_link(pci); > -- > 2.17.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel