From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A6EEC10F14 for ; Thu, 11 Apr 2019 15:32:51 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0AFDC2083E for ; Thu, 11 Apr 2019 15:32:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="oc/lB1l8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0AFDC2083E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=uF/ixLMNzE8VHvV1ezCUVE5aiFHNqMToOxPLJlnoy3w=; b=oc/lB1l8RtktNo 0ughwyAvdMWWiJ63cb1i3gJSHPh8Bpsm4MP19FxN66RZVJycZ5GuijrhWTIoQLUjbpuyDOCDSBXHv bWL7cjoJFO1wy7rxf8tWuV9Afj+temOnfkm0laxjkirmWyK+066E8E1Wo5LHVkNUIUMQ+/cYhcvZX AzNqGK0j+5KktugqpwAet2YCsdoAhnOInwgHCHcoo4pCv9oktfT47b7eqHU9VJZg3uQ6fT5d+DJyw FmFzsgirjbVXcCaCt0NtDNd0r8lYxYKjGei1hi6piUlf38XAp1PBXovLkuWKWK4Tf+xCYNVtdUMZy OG0EzrHcNxonbas1R5Zg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hEbh3-0004S5-6T; Thu, 11 Apr 2019 15:32:49 +0000 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70] helo=foss.arm.com) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hEbgz-0004RL-Jk for linux-arm-kernel@lists.infradead.org; Thu, 11 Apr 2019 15:32:47 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A90DF80D; Thu, 11 Apr 2019 08:32:44 -0700 (PDT) Received: from red-moon (unknown [10.1.197.39]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 84FE83F68F; Thu, 11 Apr 2019 08:32:41 -0700 (PDT) Date: Thu, 11 Apr 2019 16:32:39 +0100 From: Lorenzo Pieralisi To: Kishon Vijay Abraham I Subject: Re: [PATCH v3 18/26] PCI: endpoint: Add support to allocate aligned buffers to be mapped in BARs Message-ID: <20190411153238.GD6862@red-moon> References: <20190325093947.32633-1-kishon@ti.com> <20190325093947.32633-19-kishon@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190325093947.32633-19-kishon@ti.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190411_083245_672122_DAEA0B71 X-CRM114-Status: GOOD ( 26.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Jesper Nilsson , Arnd Bergmann , Greg Kroah-Hartman , Gustavo Pimentel , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@axis.com, Minghuan Lian , Rob Herring , Murali Karicheri , Jingoo Han , Bjorn Helgaas , Mingkai Hu , linux-omap@vger.kernel.org, Roy Zang , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Mar 25, 2019 at 03:09:39PM +0530, Kishon Vijay Abraham I wrote: > Modify pci_epf_alloc_space API to take alignment size as argument in > order to argument in order to allocate aligned buffers to be mapped to > BARs. > > Add 'align' parameter to epc_features which can be used by platform > drivers to specifiy the BAR allocation alignment requirements and use > this while invoking pci_epf_alloc_space. > > This is mainly required for Synopsys Designware PCIe core which masks > the lower bits based on the BAR size (See "I/O and MEM Match Modes" > section in DesignWare Cores PCI Express Controller Databook version > 4.90a). Hi Kishon, isn't this a generic PCI BAR requirement rather than a Designware specific one ? The patch is fine I just would like to understand the statement above. Thanks, Lorenzo > Signed-off-by: Kishon Vijay Abraham I > --- > drivers/pci/endpoint/functions/pci-epf-test.c | 5 +++-- > drivers/pci/endpoint/pci-epf-core.c | 10 ++++++++-- > include/linux/pci-epc.h | 2 ++ > include/linux/pci-epf.h | 3 ++- > 4 files changed, 15 insertions(+), 5 deletions(-) > > diff --git a/drivers/pci/endpoint/functions/pci-epf-test.c b/drivers/pci/endpoint/functions/pci-epf-test.c > index d0b91da49bf4..c0786ca74312 100644 > --- a/drivers/pci/endpoint/functions/pci-epf-test.c > +++ b/drivers/pci/endpoint/functions/pci-epf-test.c > @@ -438,7 +438,7 @@ static int pci_epf_test_alloc_space(struct pci_epf *epf) > epc_features = epf_test->epc_features; > > base = pci_epf_alloc_space(epf, sizeof(struct pci_epf_test_reg), > - test_reg_bar); > + test_reg_bar, epc_features->align); > if (!base) { > dev_err(dev, "Failed to allocated register space\n"); > return -ENOMEM; > @@ -453,7 +453,8 @@ static int pci_epf_test_alloc_space(struct pci_epf *epf) > if (!!(epc_features->reserved_bar & (1 << bar))) > continue; > > - base = pci_epf_alloc_space(epf, bar_size[bar], bar); > + base = pci_epf_alloc_space(epf, bar_size[bar], bar, > + epc_features->align); > if (!base) > dev_err(dev, "Failed to allocate space for BAR%d\n", > bar); > diff --git a/drivers/pci/endpoint/pci-epf-core.c b/drivers/pci/endpoint/pci-epf-core.c > index 8bfdcd291196..fb1306de8f40 100644 > --- a/drivers/pci/endpoint/pci-epf-core.c > +++ b/drivers/pci/endpoint/pci-epf-core.c > @@ -109,10 +109,12 @@ EXPORT_SYMBOL_GPL(pci_epf_free_space); > * pci_epf_alloc_space() - allocate memory for the PCI EPF register space > * @size: the size of the memory that has to be allocated > * @bar: the BAR number corresponding to the allocated register space > + * @align: alignment size for the allocation region > * > * Invoke to allocate memory for the PCI EPF register space. > */ > -void *pci_epf_alloc_space(struct pci_epf *epf, size_t size, enum pci_barno bar) > +void *pci_epf_alloc_space(struct pci_epf *epf, size_t size, enum pci_barno bar, > + size_t align) > { > void *space; > struct device *dev = epf->epc->dev.parent; > @@ -120,7 +122,11 @@ void *pci_epf_alloc_space(struct pci_epf *epf, size_t size, enum pci_barno bar) > > if (size < 128) > size = 128; > - size = roundup_pow_of_two(size); > + > + if (align) > + size = ALIGN(size, align); > + else > + size = roundup_pow_of_two(size); > > space = dma_alloc_coherent(dev, size, &phys_addr, GFP_KERNEL); > if (!space) { > diff --git a/include/linux/pci-epc.h b/include/linux/pci-epc.h > index c3ffa3917f88..f641badc2c61 100644 > --- a/include/linux/pci-epc.h > +++ b/include/linux/pci-epc.h > @@ -109,6 +109,7 @@ struct pci_epc { > * @reserved_bar: bitmap to indicate reserved BAR unavailable to function driver > * @bar_fixed_64bit: bitmap to indicate fixed 64bit BARs > * @bar_fixed_size: Array specifying the size supported by each BAR > + * @align: alignment size required for BAR buffer allocation > */ > struct pci_epc_features { > unsigned int linkup_notifier : 1; > @@ -117,6 +118,7 @@ struct pci_epc_features { > u8 reserved_bar; > u8 bar_fixed_64bit; > u64 bar_fixed_size[BAR_5 + 1]; > + size_t align; > }; > > #define to_pci_epc(device) container_of((device), struct pci_epc, dev) > diff --git a/include/linux/pci-epf.h b/include/linux/pci-epf.h > index ec02f58758c8..2d6f07556682 100644 > --- a/include/linux/pci-epf.h > +++ b/include/linux/pci-epf.h > @@ -149,7 +149,8 @@ void pci_epf_destroy(struct pci_epf *epf); > int __pci_epf_register_driver(struct pci_epf_driver *driver, > struct module *owner); > void pci_epf_unregister_driver(struct pci_epf_driver *driver); > -void *pci_epf_alloc_space(struct pci_epf *epf, size_t size, enum pci_barno bar); > +void *pci_epf_alloc_space(struct pci_epf *epf, size_t size, enum pci_barno bar, > + size_t align); > void pci_epf_free_space(struct pci_epf *epf, void *addr, enum pci_barno bar); > int pci_epf_bind(struct pci_epf *epf); > void pci_epf_unbind(struct pci_epf *epf); > -- > 2.17.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel