Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Rutland <mark.rutland@arm.com>
To: Raphael Gault <raphael.gault@arm.com>
Cc: will.deacon@arm.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm64: perf_event: Remove wrongfully used inline
Date: Thu, 11 Apr 2019 17:21:44 +0100	[thread overview]
Message-ID: <20190411162144.GC384@lakrids.cambridge.arm.com> (raw)
In-Reply-To: <20190411161646.22097-1-raphael.gault@arm.com>

On Thu, Apr 11, 2019 at 05:16:46PM +0100, Raphael Gault wrote:
> The functions armv8pmu_read_counter() and armv8pmu_write_counter()
> are `static inline` while they are only referenced when assigned
> to a function pointer field in a `struct arm_pmu` instance.
> 
> The inline keyword is thus counter intuitive and shouldn't be used.
> 
> Signed-off-by: Raphael Gault <raphael.gault@arm.com>

This looks like a sensible cleanup, so:

Acked-by: Mark Rutland <mark.rutland@arm.com>

Will, I assume you'll pick this up.

Thanks,
Mark.

> ---
>  arch/arm64/kernel/perf_event.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/kernel/perf_event.c b/arch/arm64/kernel/perf_event.c
> index 4addb38bc250..6164d389eed6 100644
> --- a/arch/arm64/kernel/perf_event.c
> +++ b/arch/arm64/kernel/perf_event.c
> @@ -431,7 +431,7 @@ static inline u64 armv8pmu_read_hw_counter(struct perf_event *event)
>  	return val;
>  }
>  
> -static inline u64 armv8pmu_read_counter(struct perf_event *event)
> +static u64 armv8pmu_read_counter(struct perf_event *event)
>  {
>  	struct arm_pmu *cpu_pmu = to_arm_pmu(event->pmu);
>  	struct hw_perf_event *hwc = &event->hw;
> @@ -468,7 +468,7 @@ static inline void armv8pmu_write_hw_counter(struct perf_event *event,
>  	}
>  }
>  
> -static inline void armv8pmu_write_counter(struct perf_event *event, u64 value)
> +static void armv8pmu_write_counter(struct perf_event *event, u64 value)
>  {
>  	struct arm_pmu *cpu_pmu = to_arm_pmu(event->pmu);
>  	struct hw_perf_event *hwc = &event->hw;
> -- 
> 2.17.1
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

      reply	other threads:[~2019-04-11 16:21 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-11 16:16 [PATCH] arm64: perf_event: Remove wrongfully used inline Raphael Gault
2019-04-11 16:21 ` Mark Rutland [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190411162144.GC384@lakrids.cambridge.arm.com \
    --to=mark.rutland@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=raphael.gault@arm.com \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox