From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B642C10F13 for ; Thu, 11 Apr 2019 16:26:09 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CD3772083E for ; Thu, 11 Apr 2019 16:26:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="EDEmoNev" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CD3772083E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1o5Ab85yZDaHxVrDGbPC7dkWGq8eHQgo8ofwHwcVBvY=; b=EDEmoNevxQd6vU Jnugw9VuoKq1iqPF6i68HRW9j2aVgWI8NBWJtwKNk7j0q1IN39vG8BIO+XfjLpTZXSvi8ZaAnBoQ5 LYNbT0xc6xoPSaIOx2vdBf+lYAuiNiFHvi1NLjkuCpcW/EEQpk8FMPrwYQpDNOce7r8LVO/WPoA7x QSm/l3turF+TiVsYUswYdSH0adUCNJZTBEOIRv9rdZoOBeEKOxAJue65rk668spdzpaN01svmcjI0 ybMnsAVll4KjMlDbhCObFOxKLJkj9pOb6JfCSL8z4mu+bMZybgIHl2AIa14iIZWuScmC4mN8Say6+ SAeAa6CaO4zKo71f+ldQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hEcWa-0002UL-W6; Thu, 11 Apr 2019 16:26:04 +0000 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70] helo=foss.arm.com) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hEcWS-0002Sm-Di for linux-arm-kernel@lists.infradead.org; Thu, 11 Apr 2019 16:26:01 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 95B0280D; Thu, 11 Apr 2019 09:25:54 -0700 (PDT) Received: from e107155-lin (e107155-lin.cambridge.arm.com [10.1.196.42]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 18FA33F59C; Thu, 11 Apr 2019 09:25:52 -0700 (PDT) Date: Thu, 11 Apr 2019 17:25:45 +0100 From: Sudeep Holla To: Mark Rutland Subject: Re: [RESEND][PATCH v2] firmware/psci: add support for SYSTEM_RESET2 Message-ID: <20190411162545.GA5327@e107155-lin> References: <20190411103346.22462-1-sudeep.holla@arm.com> <20190411110302.GA55959@lakrids.cambridge.arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190411110302.GA55959@lakrids.cambridge.arm.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190411_092556_462008_FFC569EF X-CRM114-Status: GOOD ( 21.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Florian Fainelli , Aaro Koskinen , Michal Simek , linux-kernel@vger.kernel.org, Lorenzo Pieralisi , Aaro Koskinen , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Apr 11, 2019 at 12:03:04PM +0100, Mark Rutland wrote: > On Thu, Apr 11, 2019 at 11:33:46AM +0100, Sudeep Holla wrote: > > PSCI v1.1 introduced SYSTEM_RESET2 to allow both architectural resets > > where the semantics are described by the PSCI specification itself as > > well as vendor-specific resets. Currently only system warm reset > > semantics is defined as part of architectural resets by the specification. > > > > This patch implements support for SYSTEM_RESET2 by making using of > > reboot_mode passed by the reboot infrastructure in the kernel. > > > > Cc: Mark Rutland > > Cc: Lorenzo Pieralisi > > Signed-off-by: Sudeep Holla > > --- > > drivers/firmware/psci.c | 21 +++++++++++++++++++++ > > include/uapi/linux/psci.h | 2 ++ > > 2 files changed, 23 insertions(+) > > > > Resending [1] based on the request. I hope to get some testing this time. > > Last time Xilinx asked multiple times but never got any review or testing > > https://lore.kernel.org/lkml/1525257003-8608-1-git-send-email-sudeep.holla@arm.com/ > > > > diff --git a/drivers/firmware/psci.c b/drivers/firmware/psci.c > > index c80ec1d03274..91748725534e 100644 > > --- a/drivers/firmware/psci.c > > +++ b/drivers/firmware/psci.c > > @@ -88,6 +88,7 @@ static u32 psci_function_id[PSCI_FN_MAX]; > > PSCI_1_0_EXT_POWER_STATE_TYPE_MASK) > > > > static u32 psci_cpu_suspend_feature; > > +static bool psci_system_reset2_supported; > > > > static inline bool psci_has_ext_power_state(void) > > { > > @@ -253,6 +254,15 @@ static int get_set_conduit_method(struct device_node *np) > > > > static void psci_sys_reset(enum reboot_mode reboot_mode, const char *cmd) > > { > > + if ((reboot_mode == REBOOT_WARM || reboot_mode == REBOOT_SOFT) && > > + psci_system_reset2_supported) > > + /* > > + * reset_type[31] = 0 (architectural) > > + * reset_type[30:0] = 0 (SYSTEM_WARM_RESET) > > + * cookie = 0 (ignored by the implementation) > > + */ > > + invoke_psci_fn(PSCI_FN_NATIVE(1_1, SYSTEM_RESET2), 0, 0, 0); > > Since the comment and invocation span multiple lines, could we please > wrap them in braces? > Yes, that would be better, will update it. > Other than that, this looks good to me, so: > > Acked-by: Mark Rutland > Thanks. -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel