From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A2C7C10F14 for ; Thu, 11 Apr 2019 16:49:46 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 69AB02133D for ; Thu, 11 Apr 2019 16:49:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="mindee0R" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 69AB02133D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=QdpDa70LRYnJ8hciwx6kri3+KugIp8jXedicA/ILW68=; b=mindee0RDnkbu1 vBZ1tsTV+xI4nOgLcVadDEc+ynZveils86XIw9hDlfiBuPVtMaDuqYpF0Dh6IXpIQDWlH5U8Lrhtz 7GWekjtqW7FlWHWWyCJe/3Xhi5rQoSB53u0GjUMh+fwHddGetO8YWKDGjXq4/0zJsMvaWwmg/AWwQ G2hgVXnL6cDX1+ANfDCvKKjf/E/T+AGYNmcwuJEHy2RZp20lzpddLCi8+7M3Qhx+aAdF6JBEJIXRa Ad89WvJnUqB6ZzMPzHF57MHJe9Wuqcd5agLYM0DU4/T/qDSXNWz2QfIemqj0BSbskC3JaXcA3yta2 EdlMeG7bj8NLvgkMasFg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hEctU-0002NZ-2K; Thu, 11 Apr 2019 16:49:44 +0000 Received: from foss.arm.com ([217.140.101.70]) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hEctR-0002ND-NN for linux-arm-kernel@lists.infradead.org; Thu, 11 Apr 2019 16:49:42 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 50221374; Thu, 11 Apr 2019 09:49:40 -0700 (PDT) Received: from e107155-lin (e107155-lin.cambridge.arm.com [10.1.196.42]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C74633F59C; Thu, 11 Apr 2019 09:49:38 -0700 (PDT) Date: Thu, 11 Apr 2019 17:49:36 +0100 From: Sudeep Holla To: "Koskinen, Aaro (Nokia - FI/Espoo)" Subject: Re: [RESEND][PATCH v2] firmware/psci: add support for SYSTEM_RESET2 Message-ID: <20190411164936.GB5327@e107155-lin> References: <20190411103346.22462-1-sudeep.holla@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190411_094941_766942_BC2613AD X-CRM114-Status: GOOD ( 14.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Florian Fainelli , Aaro Koskinen , Michal Simek , "linux-kernel@vger.kernel.org" , Lorenzo Pieralisi , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Apr 11, 2019 at 11:42:28AM +0000, Koskinen, Aaro (Nokia - FI/Espoo) wrote: > Hi, > > From: Sudeep Holla [sudeep.holla@arm.com]: > > static void psci_sys_reset(enum reboot_mode reboot_mode, const char *cmd) > > { > > + if ((reboot_mode == REBOOT_WARM || reboot_mode == REBOOT_SOFT) && > > I would omit the REBOOT_SOFT here. > I included REBOOT_SOFT for 2 reasons: 1. drivers/firmware/efi/reboot.c - efi_reboot treats WARM and SOFT reboots same 2. If the vendors specific reboots are added and handled in EFI, I assume it will be categorised under REBOOT_SOFT. If that's wrong I can drop REBOOT_SOFT. > > + psci_system_reset2_supported) > > + /* > > + * reset_type[31] = 0 (architectural) > > + * reset_type[30:0] = 0 (SYSTEM_WARM_RESET) > > + * cookie = 0 (ignored by the implementation) > > + */ > > + invoke_psci_fn(PSCI_FN_NATIVE(1_1, SYSTEM_RESET2), 0, 0, 0); > > + > > invoke_psci_fn(PSCI_0_2_FN_SYSTEM_RESET, 0, 0, 0); > > Use else here, so that we fall back to system halt if SYSTEM_RESET2 fails. > Will that not change current behaviour ? IOW, is that expected behaviour ? I am not sure if halt can be prefer over cold reboot in absence of warm/soft reboot when the system is request to reboot. From PSCI perspective, since SYSTEM_RESET is mandatory I prefer that unless Linux has any restriction on this behaviour. -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel