From: Douglas Anderson <dianders@chromium.org>
To: Heiko Stuebner <heiko@sntech.de>,
Elaine Zhang <zhangqing@rock-chips.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, briannorris@chromium.org,
amstan@chromium.org, dbasehore@chromium.org,
Douglas Anderson <dianders@chromium.org>,
Rob Herring <robh+dt@kernel.org>,
linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
mka@chromium.org, ryandcase@chromium.org,
Chris Zhong <zyw@rock-chips.com>,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/5] ARM: dts: rockchip: vcc33_ccd off in suspend for rk3288-veyron-chromebook
Date: Thu, 11 Apr 2019 16:21:56 -0700 [thread overview]
Message-ID: <20190411232157.55125-4-dianders@chromium.org> (raw)
In-Reply-To: <20190411232157.55125-1-dianders@chromium.org>
As per my comments when the device tree for rk3288-veyron-chromebook
first landed:
> Technically I think vcc33_ccd can be off since we have
> 'needs-reset-on-resume' down in the EHCI port (this regulator is for
> the USB webcam that's connected to the EHCI port).
>
> ...but leaving it on for now seems fine until we get suspend/resume
> more solid.
It's probably about time to do it right.
[1] https://lore.kernel.org/linux-arm-kernel/CAD=FV=U37Yx8Mqk75_x05zxonvdc3qRMhqp8TyTDPWGHqSuRqg@mail.gmail.com/
Signed-off-by: Douglas Anderson <dianders@chromium.org>
---
arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi b/arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi
index b9cc90f0f25c..fbef34578100 100644
--- a/arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi
+++ b/arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi
@@ -176,8 +176,7 @@
regulator-min-microvolt = <3300000>;
regulator-max-microvolt = <3300000>;
regulator-state-mem {
- regulator-on-in-suspend;
- regulator-suspend-microvolt = <3300000>;
+ regulator-off-in-suspend;
};
};
};
--
2.21.0.392.gf8f6787159e-goog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-04-11 23:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-11 23:21 [PATCH 1/5] clk: rockchip: Turn on "aclk_dmac1" for suspend Douglas Anderson
2019-04-11 23:21 ` [PATCH 2/5] ARM: rockchip: pm: Mark init functions __init Douglas Anderson
2019-04-12 11:16 ` Heiko Stübner
2019-04-11 23:21 ` [PATCH 3/5] ARM: dts: rockchip: Add DDR retention/poweroff to rk3288-veyron hogs Douglas Anderson
2019-04-12 11:16 ` Heiko Stübner
2019-04-11 23:21 ` Douglas Anderson [this message]
2019-04-12 1:53 ` [PATCH 4/5] ARM: dts: rockchip: vcc33_ccd off in suspend for rk3288-veyron-chromebook elaine.zhang
2019-04-12 11:16 ` Heiko Stübner
2019-04-11 23:21 ` [PATCH 5/5] ARM: dts: rockchip: vdd_gpu off in suspend for rk3288-veyron Douglas Anderson
2019-04-12 1:55 ` elaine.zhang
2019-04-12 11:17 ` Heiko Stübner
2019-04-12 1:56 ` [PATCH 1/5] clk: rockchip: Turn on "aclk_dmac1" for suspend elaine.zhang
2019-04-12 10:06 ` Heiko Stübner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190411232157.55125-4-dianders@chromium.org \
--to=dianders@chromium.org \
--cc=amstan@chromium.org \
--cc=briannorris@chromium.org \
--cc=dbasehore@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=mka@chromium.org \
--cc=robh+dt@kernel.org \
--cc=ryandcase@chromium.org \
--cc=zhangqing@rock-chips.com \
--cc=zyw@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).