From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,FSL_HELO_FAKE,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8765C10F0E for ; Fri, 12 Apr 2019 07:00:42 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 97AB020850 for ; Fri, 12 Apr 2019 07:00:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="TfnYFRPC"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PmlG1wAT" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 97AB020850 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DPKjyCksPhiAJSd3O1vPSxAFaqZZyCgQTw65Mmmjidw=; b=TfnYFRPCNZjU1x gfv+kUAqkEBwCZZcH8Nc1lEeNveH49PWAw3gjSjIV3Hy9pW8l/PytA3tpj1Lqfk/KeC3Sa6d+nA7/ Z4D/3MEK06iT6oiTixc8FyltVaBz33ZGjfxb1dq9eaBCHyWd21Mcid+NerLn5a4LFBTT9NoI5MR3Y 7GZ2ebZ8KNJX3jkWxoQIfNtt47lGU/XP9y8IO68PjshjgWzcBy8tSURyi4VLZpybHNw+SgdTKoGg6 K54W8yB0EoCLcgTNHdJY9KzkkEvkOTf5HOJVc+wbCbyj7+RC8AotdlXxQfJFxHsqAQlnltgpiRPER Dt+FNl06ynOyNnmL3vRQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hEqAw-0006T7-Q1; Fri, 12 Apr 2019 07:00:38 +0000 Received: from mail-wm1-x343.google.com ([2a00:1450:4864:20::343]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hEqAq-0006O0-Kc; Fri, 12 Apr 2019 07:00:36 +0000 Received: by mail-wm1-x343.google.com with SMTP id h18so9617288wml.1; Fri, 12 Apr 2019 00:00:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=4Bbk35aBCZESEHG5RuZnD1QaHFZgpzC3BQiZIJk+H7A=; b=PmlG1wATxN+yYRJGI5HrsADPBKacqPwGDNzYciIeJunLtv8rqYm9e0A2E0B7k4CcvF /h62GzJFu2wVaZmnPrE3zt7Zg4OW+CqUJC9Xdqxj2HAzq44uOCq/vsWYaMN7GMIU2rG3 HzGHDnmDnQcbhp3VJHLHOqst6veeJ39jtWd3aMiSPEAy8HSfwuHrA2I9rQc76i8vuTrz jBt0NuXlXe5gtFJUlsdV5ll6sCDHqFbG0wmPrFWdxnpz+yt6Miebxo17xWBArl7JJMKR X6kfUmjGaPivonV/ItIuu0tKBP0Gf/pt0ODYWDGIoEHbSodZ6HL+t9K9Aivy9k6gEFke Uy9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=4Bbk35aBCZESEHG5RuZnD1QaHFZgpzC3BQiZIJk+H7A=; b=i8wMvcd4FKZ2fcx49sNSP7qtkCugRB1gOCKpMLSlEUqM07x8q5kHOmeBjFEn7d8hUZ XBSuKAI9X5XGo0pLFlpKb16ihqsktsoi6EJwl1z+B8+c2bwu3ynZWf8DEMOxATBjHZTR kWrwpekKMH2kqj+V+NAT8ZRxbA5Bz0XTfsQF/kMU6qYPoNVTwQCXK0bUeoZAYhP7gpsZ C52HjSvJ4oPuHTHwmngC367cc+ZEYD8w4MkIO4pl5P+2BQPke7VTOxCi87wQn7m6ENFX m9CaIB4xbfY7DMZFLaNl8Rz+sfPAKRhtVPOsTSNa78xPaQaowgiqjLCtbalgO+eg1nWK tAZw== X-Gm-Message-State: APjAAAWz5UinSaSxjkkUtYStL1qO8I0yL0deT+30gFfUXtIYP+/v/Szi OV6URsFTfQn81XiY+tS1WmA= X-Google-Smtp-Source: APXvYqy7AAcYtxGhSgkFdnH8n+8rnMF9kvqttL6gxc+5XUNk3J1ebSQNRdh0sL1NtXBy6UNzvVdpvw== X-Received: by 2002:a1c:cb0f:: with SMTP id b15mr9176981wmg.88.1555052430515; Fri, 12 Apr 2019 00:00:30 -0700 (PDT) Received: from gmail.com (2E8B0CD5.catv.pool.telekom.hu. [46.139.12.213]) by smtp.gmail.com with ESMTPSA id q24sm6481754wmj.26.2019.04.12.00.00.28 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 12 Apr 2019 00:00:29 -0700 (PDT) Date: Fri, 12 Apr 2019 09:00:27 +0200 From: Ingo Molnar To: Chen Zhou Subject: Re: [PATCH v3 1/4] x86: kdump: move reserve_crashkernel_low() into kexec_core.c Message-ID: <20190412070027.GB129493@gmail.com> References: <20190409102819.121335-1-chenzhou10@huawei.com> <20190409102819.121335-2-chenzhou10@huawei.com> <20190410070914.GA10935@gmail.com> <31b41dcc-0d16-d1d0-bff9-dec3e77515c1@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <31b41dcc-0d16-d1d0-bff9-dec3e77515c1@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190412_000032_701358_FC2173B6 X-CRM114-Status: GOOD ( 11.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: wangkefeng.wang@huawei.com, akpm@linux-foundation.org, ard.biesheuvel@linaro.org, catalin.marinas@arm.com, takahiro.akashi@linaro.org, will.deacon@arm.com, linux-kernel@vger.kernel.org, rppt@linux.ibm.com, linux-mm@kvack.org, horms@verge.net.au, bp@alien8.de, ebiederm@xmission.com, kexec@lists.infradead.org, tglx@linutronix.de, mingo@redhat.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org * Chen Zhou wrote: > Hi Ingo, > > On 2019/4/10 15:09, Ingo Molnar wrote: > > > > * Chen Zhou wrote: > > > >> In preparation for supporting more than one crash kernel regions > >> in arm64 as x86_64 does, move reserve_crashkernel_low() into > >> kexec/kexec_core.c. > >> > >> Signed-off-by: Chen Zhou > >> --- > >> arch/x86/include/asm/kexec.h | 3 ++ > >> arch/x86/kernel/setup.c | 66 +++++--------------------------------------- > >> include/linux/kexec.h | 1 + > >> kernel/kexec_core.c | 53 +++++++++++++++++++++++++++++++++++ > >> 4 files changed, 64 insertions(+), 59 deletions(-) > > > > No objections for this to be merged via the ARM tree, as long as x86 > > functionality is kept intact. > > This patch has no affect on x86. In *principle*. In practice the series does change x86 code: > >> arch/x86/kernel/setup.c | 66 +++++--------------------------------------- > >> include/linux/kexec.h | 1 + > >> kernel/kexec_core.c | 53 +++++++++++++++++++++++++++++++++++ which is, *hopefully*, an identity transformation. :-) I.e. Ack, but only if it doesn't break anything. :-) Thanks, Ingo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel