From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4CFAEC10F0E for ; Fri, 12 Apr 2019 15:33:30 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1E51921872 for ; Fri, 12 Apr 2019 15:33:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="jFcTY6My" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1E51921872 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=atomide.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=OCJyhmfMlQhY6GpZ/WOa4SUDa124KK33P4YpUPuK6D8=; b=jFcTY6MyEGGhO2 9QYgGh5XHkL1xeVUAYStl8v7FYG3bWpm8BkwmGTd4ggLklbe42DU3hDDjK8WYXb3jPy2mtOk4iTWh ndE2UNxdF8mEooUPHmyEdS51DxE1CsasPR1XDLbnf97+zMFnQZGMuPq+zjUtbiqRMr1+zIeCOSUcu 0BBJexGXc1edj6OxK4W9Wim81kg16C46JASYd/CAJvd4nt1ST+9IfpgSiOK7pGBCQai7me+B0xz64 zSQ/T0DddtKF8kCSCf91UPKKWzi/fdJD95dyETt1xIgRDS7E1qBU6Ivj3snrl+KQPGSbZeKPV1tMu JRRXHGPs7EYyCOvOZwog==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hEyBE-0002lx-Op; Fri, 12 Apr 2019 15:33:28 +0000 Received: from muru.com ([72.249.23.125]) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hEyBC-0002lb-Bh for linux-arm-kernel@lists.infradead.org; Fri, 12 Apr 2019 15:33:27 +0000 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 803F880F3; Fri, 12 Apr 2019 15:33:40 +0000 (UTC) Date: Fri, 12 Apr 2019 08:33:21 -0700 From: Tony Lindgren To: Tero Kristo Subject: Re: [PATCH v6 06/12] dt-bindings: irqchip: Introduce TISCI Interrupt router bindings Message-ID: <20190412153321.GV2839@atomide.com> References: <20190410041358.16809-1-lokeshvutla@ti.com> <20190410041358.16809-7-lokeshvutla@ti.com> <20190411150023.GQ2839@atomide.com> <9cd4b818-905c-08a4-5675-a5ee763cea98@ti.com> <7e41405b-74e2-dc53-982a-766dee8a6884@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <7e41405b-74e2-dc53-982a-766dee8a6884@ti.com> User-Agent: Mutt/1.11.4 (2019-03-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190412_083326_440426_F32CB705 X-CRM114-Status: GOOD ( 15.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nishanth Menon , Device Tree Mailing List , Grygorii Strashko , jason@lakedaemon.net, Lokesh Vutla , Sekhar Nori , linux-kernel@vger.kernel.org, Peter Ujfalusi , Marc Zyngier , Rob Herring , Santosh Shilimkar , Linux ARM Mailing List Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org * Tero Kristo [190412 08:43]: > On 12/04/2019 07:24, Lokesh Vutla wrote: > > > > > > On 11/04/19 8:30 PM, Tony Lindgren wrote: > > > Hi, > > > > > > * Lokesh Vutla [190410 04:15]: > > > > +Example: > > > > +-------- > > > > +The following example demonstrates both interrupt router node and the consumer > > > > +node(main gpio) on the AM654 SoC: > > > > + > > > > +main_intr: interrupt-controller0 { > > > > + compatible = "ti,sci-intr"; > > > > + ti,intr-trigger-type = <1>; > > > > + interrupt-controller; > > > > + interrupt-parent = <&gic500>; > > > > + #interrupt-cells = <3>; > > > > + ti,sci = <&dmsc>; > > > > + ti,sci-dst-id = <56>; > > > > + ti,sci-rm-range-girq = <0x1>; > > > > +}; > > > > > > To me it seems there should not be too many of these interrupt > > > controller nodes for each SoC. Maybe you're already planning on > > > doing it, but I suggest that you just add more specific compatibles > > > and then look up the dst-id from a mapping table in the driver > > > similar to what patch 04/12 in this series is already doing. > > > > > > That way you don't need to add custom TI specific (firmware > > > defined) device tree properties listed above ;) > > > > < snip: I think Lokesh had a bad day or something :) > Certainly custom bindings need to be discussed properly on the lists :) > Anyways, the reason why we want these as custom properties in the DT is that > there are multiple instances of the routers within one SoC. On AM65x we have > MAIN NAVSS, MCU NAVSS, GPIOs for both etc., if we add driver data for each > of these, it easily explodes quite a bit. Especially going forward with new > SoCs. Yup and I keep getting worried about this every time I see it still. But like I've mentioned when we chatted offline, as long as Arnd, Marc and Rob ack this use, I can live with it. I'm just trying to avoid another "ti,hwmods" type custom property here.. We are still dealing with it to replace it with just standard use of "compatible" property, and every time Rob sees it he still comments on it :) Reagrds, Tony _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel