From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3102C10F11 for ; Sat, 13 Apr 2019 15:26:50 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C02CD2084D for ; Sat, 13 Apr 2019 15:26:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Iq1gTCJN"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="zw0VdTGd" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C02CD2084D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ezYSbLTU2xdFi6hoqSR18zy5XbeTP74LwerGmM0x03I=; b=Iq1gTCJNOI0hE9 QxfQ5xEtUFY/M/L5467w/fcnwkuebfRlQYZS6nRgIKU/PlWBPqdOHVf0lIkVKr/SiUY9HKSv8HGLS I3kpnDcV1MZUMerZWU3xpICaPqmUXxcoH4MtINhZnp6toLk68NJJcSva2MBaFHvdgTtGsgzhgsqvi aGVcWN3vBJaaT896ugK+d+afLpSuycFbQ+BoQc4eziRpWfVU5ODP8Rg5e8eoDknTbT7pFyV9VyZLG YAIj2T2ohINaU4OlAUElIFgKA91E55wg6Sw0VSu2TTw/zCEaweBLzFeHZs4YFF1mIwsBqoZaibNom VViwudt6BwbMc8cEtQHA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hFKYB-00043V-56; Sat, 13 Apr 2019 15:26:39 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hFKY8-00042p-1H for linux-arm-kernel@lists.infradead.org; Sat, 13 Apr 2019 15:26:37 +0000 Received: from localhost (unknown [69.71.4.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 28A642084D; Sat, 13 Apr 2019 15:26:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1555169195; bh=J/j6vTOFm0xDUgBr7NLnAvO6mXoT2NAdyDPHNpI1+n4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=zw0VdTGdBsTjJEaM2/P3VtsHeu6d1RYqHUgNTz5xKXfROkYL4D5pMILgx1HWrM42T ORjjQM+huuc4b6a0rIcS/MOhvxcuOqFDnxiHD77+zz5SAvfok8/geRRqk3KDBGdMpb vB+N9c7Fh0aRakETStrt634H1EJ9oYh9lUyU2Tc8= Date: Sat, 13 Apr 2019 10:26:33 -0500 From: Bjorn Helgaas To: Kishon Vijay Abraham I Subject: Re: [PATCH v3 14/26] PCI: keystone: Add support for PCIe RC in AM654x Platforms Message-ID: <20190413152633.GF126710@google.com> References: <20190325093947.32633-1-kishon@ti.com> <20190325093947.32633-15-kishon@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190325093947.32633-15-kishon@ti.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190413_082636_094987_6BD79DB3 X-CRM114-Status: GOOD ( 12.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Jesper Nilsson , Lorenzo Pieralisi , Arnd Bergmann , Greg Kroah-Hartman , Gustavo Pimentel , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Herring , Minghuan Lian , Murali Karicheri , linux-arm-kernel@axis.com, Jingoo Han , Mingkai Hu , linux-omap@vger.kernel.org, Roy Zang , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Mar 25, 2019 at 03:09:35PM +0530, Kishon Vijay Abraham I wrote: > Add PCIe RC support for AM654x Platforms in pci-keystone.c > +static int ks_pcie_am654_msi_host_init(struct pcie_port *pp) > +{ > + struct dw_pcie *pci = to_dw_pcie_from_pp(pp); > + struct device *dev = pci->dev; > + > + dev_vdbg(dev, "dummy function so that DW core doesn't configure MSI\n"); Drive-by nit: this is the first occurrence of dev_vdbg() in drivers/pci, and while dev_vdbg() might be useful somewhere, I'm not sure this is the place. It took me 10 minutes of archaeology to figure out what it is and how to use it. Apparently it does nothing at all unless you define VERBOSE_DEBUG, which can be set via Kconfig in a few cases: drivers/dma/Makefile:subdir-ccflags-$(CONFIG_DMADEVICES_VDEBUG) += -DVERBOSE_DEBUG drivers/usb/dwc2/Makefile:ccflags-$(CONFIG_USB_DWC2_VERBOSE) += -DVERBOSE_DEBUG drivers/usb/gadget/Makefile:subdir-ccflags-$(CONFIG_USB_GADGET_VERBOSE) += -DVERBOSE_DEBUG but is more commonly set by adding "#define VERBOSE_DEBUG" manually in a source file. Neither one applies here, so I don't think this actually does anything. Anyway, I suspect this particular message would make a lot of sense as a *comment*, but maybe not as a mysterious dev_vdbg() that never actually does anything. > + return 0; > +} _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel