From: Maxime Ripard <maxime.ripard@bootlin.com>
To: "Clément Péron" <peron.clem@gmail.com>
Cc: devicetree@vger.kernel.org,
Jernej Skrabec <jernej.skrabec@siol.net>,
linux-sunxi@googlegroups.com, linux-kernel@vger.kernel.org,
Chen-Yu Tsai <wens@csie.org>, Rob Herring <robh+dt@kernel.org>,
Jagan Teki <jagan@amarulasolutions.com>,
linux-arm-kernel@lists.infradead.org,
Icenowy Zheng <icenowy@aosc.io>
Subject: Re: [PATCH 1/4] dt-bindings: sound: sun4i-spdif: Add Allwinner H6 compatible
Date: Mon, 15 Apr 2019 10:04:43 +0200 [thread overview]
Message-ID: <20190415080443.frubh4ln4agrdsfe@flea> (raw)
In-Reply-To: <20190411214422.2267-2-peron.clem@gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 849 bytes --]
Hi,
On Thu, Apr 11, 2019 at 11:44:19PM +0200, Clément Péron wrote:
> Allwinner H6 has a SPDIF controller with an increase of the fifo
> size and the possibility to output the master clock.
> However it's still compatible with the already existing driver for
> Allwiner H3.
>
> Add this compatible in the device-tree bindings documentation.
How was this tested?
After looking at the datasheet, it looks like it's still significantly
different. In particular:
- The MCLK divider isn't at the same offset
- The bits to flush the FIFO aren't at the same offset
- The FIFO trigger levels aren't at the same offset
- The FIFO status register layout is almost entirely different
So it doesn't really look compatible to me
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-04-15 8:05 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-11 21:44 [PATCH 0/4] Allwinner H6 SPDIF support Clément Péron
2019-04-11 21:44 ` [PATCH 1/4] dt-bindings: sound: sun4i-spdif: Add Allwinner H6 compatible Clément Péron
2019-04-15 8:04 ` Maxime Ripard [this message]
2019-04-15 8:09 ` Clément Péron
2019-04-15 8:11 ` Clément Péron
2019-04-15 8:18 ` Maxime Ripard
2019-04-15 8:30 ` Clément Péron
2019-04-15 14:51 ` Maxime Ripard
2019-04-15 16:30 ` Clément Péron
2019-04-16 7:34 ` Maxime Ripard
2019-04-16 8:30 ` Clément Péron
2019-04-15 15:06 ` Ondřej Jirman
2019-04-11 21:44 ` [PATCH 2/4] arm64: dts: allwinner: Add SPDIF node for Allwinner H6 Clément Péron
2019-04-11 21:44 ` [PATCH 3/4] arm64: dts: allwinner: h6: Enable SPDIF for Beelink GS1 Clément Péron
2019-04-11 21:44 ` [PATCH 4/4] arm64: defconfig: Enable Sun4i SPDIF module Clément Péron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190415080443.frubh4ln4agrdsfe@flea \
--to=maxime.ripard@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=icenowy@aosc.io \
--cc=jagan@amarulasolutions.com \
--cc=jernej.skrabec@siol.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=peron.clem@gmail.com \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).