From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8265C10F0E for ; Mon, 15 Apr 2019 09:30:27 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A43DF20675 for ; Mon, 15 Apr 2019 09:30:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="KFiS3wDi"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="JyY6MKaj" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A43DF20675 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=rPXqnITuRF0cMjxRNfLFaaCn5vGXZIAl8zKWzG3TJHQ=; b=KFiS3wDiT5QsPh pY9QWiQ0yZzQWAJVcezCtbqMGnL5OptUkwRF1jlWOcDgsWMU0Tj9wg9jfP8bYMOSDuQxDg0RtKsqi NTN2/yIKqcziS6F5OZ7jns+KHJ0SJMvdby4Uh8oZhDW8Jn0Bmi+faZxW+p6rmiZ4C7RaW9NiIpGki lDyyiJxPP4v1FlQD5SSU188O/ETiTiUjPSDRYSZTnd1ytWn7a43wKHfUq9WkJ0mj9xzvL3fQfeoqU /4vMyCG3geAjzYF+XpwNXEIkuwFrbwADGQrRsx0UqSTfmdHhBJOkdekF9vRy0fnv81a8wU6DIE4MY y5pjGYl3ITix4njFBRqg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hFxwS-0004q6-U7; Mon, 15 Apr 2019 09:30:20 +0000 Received: from mail-ed1-x544.google.com ([2a00:1450:4864:20::544]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hFxwP-0004pj-2z for linux-arm-kernel@lists.infradead.org; Mon, 15 Apr 2019 09:30:18 +0000 Received: by mail-ed1-x544.google.com with SMTP id d46so9237230eda.7 for ; Mon, 15 Apr 2019 02:30:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=sender:date:from:to:cc:subject:message-id:mail-followup-to :references:mime-version:content-disposition:in-reply-to:user-agent; bh=5l4pZfeYVCgIufgTo6R8psP3r9rSQEmmZLpDCPOtF0s=; b=JyY6MKajUN9BMEB1et36TqA0OvogqYiKBxW2KDPayhIU0V2Oe1VKtP+WuCKSs8EmkD MEQvRpTYdC6zBHyPerWEfSHs8GlguDJJFlHv88Ny4MFiKYnQdMSFbo5oZ7nIt/WUXhVr kFRxGGlRYmaUQJ2eoqMYu7QsYXDDqGuOaGD5w= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to:user-agent; bh=5l4pZfeYVCgIufgTo6R8psP3r9rSQEmmZLpDCPOtF0s=; b=EUCXNZvwoEyLF71Lw519MEfgvM3g9F8jQG1Ah1Hh+w+GTRgoTvls/jpGmAAm91Y1U0 3vZFZ1ZAepqzp7kJDCCWvHmzfB9asyhzkIQSJ6HtdaMkDOsuwb3Mblde/6s8OLuEsAOf B9RBalyR6GXFLJ6uKkUkn2b3jagRy2MNnFaseP7PWyTi/UAyAinjYzrpdrnqhbIiE1Xs CNV2XVUscOOkT1CR1zadqMB7FJEVyxSX6v5EE7O7hTTHesKM7zU2BRWdAfUHQwd67RTt A0l8lYj1cIjoIMJ+NeQd1K+nuOMIQ3BsA0bx0XzsfuQV3uod+BqC3Vtdax7mzdGIPy1i PMVg== X-Gm-Message-State: APjAAAXCf8B8qE6NIjEDP8qQG5J447aiMmKupXNl5jkSO7E4XouY5T2b rzdZBcqC674Xmh2xAkxjCpM9RA== X-Google-Smtp-Source: APXvYqwOSqT+IrQ5iPzw+48vIYBra1hbx2/VCsTpdUnPeEnhUhNo5RGi49w2A6C+5dXOkiKn/2uBAQ== X-Received: by 2002:a17:906:b84c:: with SMTP id ga12mr37748570ejb.253.1555320615142; Mon, 15 Apr 2019 02:30:15 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:569e:0:3106:d637:d723:e855]) by smtp.gmail.com with ESMTPSA id j12sm1155842eda.71.2019.04.15.02.30.13 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 15 Apr 2019 02:30:14 -0700 (PDT) Date: Mon, 15 Apr 2019 11:30:12 +0200 From: Daniel Vetter To: Joel Stanley Subject: Re: [PATCH v2] drm: aspeed: Clean up Kconfig options Message-ID: <20190415093012.GX2665@phenom.ffwll.local> Mail-Followup-To: Joel Stanley , David Airlie , Andrew Jeffery , =?iso-8859-1?Q?C=E9dric?= Le Goater , Stephen Rothwell , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel test robot References: <20190405081117.27339-1-joel@jms.id.au> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190405081117.27339-1-joel@jms.id.au> X-Operating-System: Linux phenom 4.19.0-1-amd64 User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190415_023017_131169_92470E30 X-CRM114-Status: GOOD ( 19.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Stephen Rothwell , kernel test robot , David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Andrew Jeffery , =?iso-8859-1?Q?C=E9dric?= Le Goater , Daniel Vetter , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Apr 05, 2019 at 06:41:17PM +1030, Joel Stanley wrote: > The GFX IP is inside of the ASPEED BMC SoC so there is little use > enabling it on a kernel that does not support ASPEED. > > When building with COMPILE_TEST the architecture many not have CMA > support, so to avoid breaking the build we only select these options if > the architecture supports the contiguous allocator. > > I suspect the DRM_PANEL came from a cut/paste error. > > Fixes: 4f2a8f5898ec ("drm: Add ASPEED GFX driver") > Reported-by: Stephen Rothwell > Reported-by: kernel test robot > Signed-off-by: Joel Stanley Acked-by: Daniel Vetter Iirc you have commit rights, right? -Daniel > --- > This fixes the powerpc next-20190405 build. Sorry Stephen! > > v2: Clean up as well as fix the build > v1: https://lore.kernel.org/lkml/20190405052830.27899-1-joel@jms.id.au/ > > drivers/gpu/drm/aspeed/Kconfig | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/aspeed/Kconfig b/drivers/gpu/drm/aspeed/Kconfig > index 42b74d18a41b..cccab520e02f 100644 > --- a/drivers/gpu/drm/aspeed/Kconfig > +++ b/drivers/gpu/drm/aspeed/Kconfig > @@ -1,11 +1,11 @@ > config DRM_ASPEED_GFX > tristate "ASPEED BMC Display Controller" > depends on DRM && OF > + depends on (COMPILE_TEST || ARCH_ASPEED) > select DRM_KMS_HELPER > select DRM_KMS_CMA_HELPER > - select DRM_PANEL > - select DMA_CMA > - select CMA > + select DMA_CMA if HAVE_DMA_CONTIGUOUS > + select CMA if HAVE_DMA_CONTIGUOUS > select MFD_SYSCON > help > Chose this option if you have an ASPEED AST2500 SOC Display > -- > 2.20.1 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel