From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4301FC10F0E for ; Mon, 15 Apr 2019 12:05:38 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 14C15206BA for ; Mon, 15 Apr 2019 12:05:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ROAVylO+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 14C15206BA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=the-dreams.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=U5n4irFS0a5vMtRnuWNse4L7usROp+puKc/ldwxBZR4=; b=ROAVylO+eyyvRBzR1v0ANcyvX U+cGgCbhKlB11byl037iTWuag6c3StVYNzQhL5rHEWsTsVLL8D2jemTD/eD7x4rdmGUvId2u77w0y Vb5mjapPjuSSJ4VBqEVJtsSIieTMYbGB9EllC8/ShQUbS9UjkeRI6TokDtyY3vH0x/9wAMM342eH2 V4gqFXF1qPo3WvJLJCM33HZ8AllwW45EyycGkCdWPZSaBfKQzvtl3/gcR8sQOidypbU9uA5/0iiFR tw0L6sRHVYvJW8paliqu1/8jAWeMsK5QSlX2hg8OnvDhWoGDgQ4Nzk6BgOWdl4jab/vqb9xJEXHuq 4X8aIJyIw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hG0Md-0006JP-74; Mon, 15 Apr 2019 12:05:31 +0000 Received: from sauhun.de ([88.99.104.3] helo=pokefinder.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hG0Lq-0004EW-EO for linux-arm-kernel@lists.infradead.org; Mon, 15 Apr 2019 12:04:50 +0000 Received: from localhost (p54B331F8.dip0.t-ipconnect.de [84.179.49.248]) by pokefinder.org (Postfix) with ESMTPSA id 9A7942C0114; Mon, 15 Apr 2019 14:04:41 +0200 (CEST) Date: Mon, 15 Apr 2019 14:04:41 +0200 From: Wolfram Sang To: Peter Rosin Subject: Re: [PATCH 04/12] i2c: mux: populate the new *_atomic callbacks Message-ID: <20190415120441.ka65mytvxsuzul4v@ninjato> References: <20190403124019.8947-1-wsa+renesas@sang-engineering.com> <20190403124019.8947-5-wsa+renesas@sang-engineering.com> <59d32414-3859-d614-dc41-cc0a1bc63301@axentia.se> MIME-Version: 1.0 In-Reply-To: <59d32414-3859-d614-dc41-cc0a1bc63301@axentia.se> User-Agent: NeoMutt/20170113 (1.7.2) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190415_050442_999092_E13FA708 X-CRM114-Status: UNSURE ( 9.85 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andy Shevchenko , Linus Walleij , "linux-kernel@vger.kernel.org" , "linux-renesas-soc@vger.kernel.org" , Wolfram Sang , "linux-i2c@vger.kernel.org" , "linux-tegra@vger.kernel.org" , Stefan Lengfeld , "linux-omap@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Content-Type: multipart/mixed; boundary="===============8210464885173325117==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============8210464885173325117== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="lhxkp6eumrz5hzmr" Content-Disposition: inline --lhxkp6eumrz5hzmr Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable > I guess the question is if it is allowed to have .master_xfer_atomic > but not .master_xfer (and similarly for .smbus_xfer{,_atomic})? Maybe > that decision should be made explicit? And perhaps enforced? xfer_atomic callbacks are optional. One xfer callback is mandatory. I did a check for falling back to master_xfer_atomic if there is no suitable smbus_xfer_atomic. I will think about the vice-versa case you mentioned. Yet, this is indeed a super corner case, so I prefer to fix this incrementally. > I don't care deeply about the above though, so feel free to do > something about it, or >=20 > Reviewed-by: Peter Rosin Thanks for the review! --lhxkp6eumrz5hzmr Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAly0c1kACgkQFA3kzBSg KbY5og//XeihKLEc7DDv97Bd8+50Rbfgz2b1tUDb5iCLL0Ttpw1Kx/NFjesHZN2I saEndxnDFct6Pb9ygV/yYRkKckqIUXzG5DMp/bDhUw+aFeSwSn6nPhSSSU1hsXG3 yHhSJhKPb3oFr+hQhdZ8dz9skH6NhdZggxQ1pFcCeTOvZ9DcJllm3dxLqZWnGNxk +F1lyDyJBHyUWa2OzuMi908/nTR5DWPIy3rTUKYAq2teWyHMok3KR8v8FW8EsqTa AffUcR1KV9JgVVAm79S1J1H+3IOLtt6Arh9GXvwkgiiJqvXtiygTQbA6rgTPYi9K ZHKh3fv+T6wtOfSAPXSWacGz8k8NJoTsT64ge+IDNIV769/H7W6GgVGa8ScjEWYh zPjEV/P8lkfI8HQ1mbcFZebFLIhdg6ki1z4TVq4HADwbgoT3uZdYwzhgnlAO7uGm iWe9+rLUm1YXl9k5pOLpZYHkhvy2d/Rsm0WOMuQLXTDXP8yjMD+tWJcHKPy0rqDG LV1Eqo18K+FXwBYu4hFKhblVMOtkFeDI7rk90e+BDOiN6FMOqGNoo8PslcT1T9Qe Lv+ZJo3bjhHgJiZJsCtzZJD/JsopOptF7zEK7zh4j8TSgyWD1BPBgg80IRdwVKnF QKUYvkby2DOPx8dFWrfLxzC5EHsWtPaHq2NibN5HlMcBRB4WYlk= =lPUY -----END PGP SIGNATURE----- --lhxkp6eumrz5hzmr-- --===============8210464885173325117== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============8210464885173325117==--