From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60560C10F0E for ; Mon, 15 Apr 2019 14:54:13 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 30B5D20684 for ; Mon, 15 Apr 2019 14:54:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Gt/3h0wZ"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="oVnWCJa9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 30B5D20684 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=sMWnV3QiIV4KFDj2rJjrPRo7/o/vape3HGrznseCxzs=; b=Gt/3h0wZWFfF5OpCVpVlvQEM0 Lpl2C2xzfJ6KtVfAUaPwmNxPXSNahEeUNxYqLHj78DjiS2lY/xpvCZgD/ZEsGj0bOuiwPpNGnecrb PLfoVhvkQpca0WY9a36o1At6C2nfNUewhU8TeKAOdrJ4ZmY9X/uBTx7QsvDpsqxZV6cnmStZd3H3V xPfBl2dgkvARwJ0TIVjFc2jaWYPNaEkyhQD9mm4Y9GPoZ2KptuEUyyLuBMsWuoHZeDVJZfx2y/M6u Z0GaO2JUWT+p3nJ44t3WBeACFs1i3F/IWjE0vnXd3VqohGXqVcN0d56C+xZG9JhEOOrhIiY5hpgZL Inj3MTZ8A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hG2zp-0003T7-Cb; Mon, 15 Apr 2019 14:54:09 +0000 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hG2zm-0003Oj-Ti for linux-arm-kernel@lists.infradead.org; Mon, 15 Apr 2019 14:54:08 +0000 Received: by mail-wm1-x342.google.com with SMTP id a184so21041169wma.2 for ; Mon, 15 Apr 2019 07:54:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ayVZXxmDfE7CKIQmWWZoQmCuxGLlioaha5h/hXjT9z0=; b=oVnWCJa9H2wGFtHjM4efVKWOflYxL8xJ01hRJc+0DQWIlkGzU8AbIisM5M+WdkT5Hm Z6STYoPNOeW9HMShkNJ58dW71csC+M9+oHb7Qu5yS2SiCsgvZFNF9BZXiMBnurBW++J1 WxtVM6evym2OiRJkwlh9HHLqj/ccQqx7rWRah6jTIv/CwqBfx4hfyd/U0QBkLcb0SG4F nNyv5VDE4Vt2CL88BTAamuB5SBuCWqg1rZkgRLqgA3TuZC1CRYaieRH7g44TXiSySsjc jhqQDfy6bj6ZJM0HZlQCLQiMJJNQqv1tuMDO4me586A5WhnFAHlXGblrqptHK+SRG0IK p0bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ayVZXxmDfE7CKIQmWWZoQmCuxGLlioaha5h/hXjT9z0=; b=tucUAFywmGU9ZIucbMkKDaCDXnT6IfR4/vyy3P8nQ5oCGg9+noyA+XrA2QbCBgGy+M FA3rzbdykJfIJJTJrdFVaRq3GVeGDUa+K6dkAdL5NYtKaXXluQ8uU4ka1/py3QQIGoW/ Avw7D+lbTJF0lXMCN1vtFZgRagPDCShkSlkF+cyUOvCmw9OF0D+RASgQgK7wYCkz7OFP WLBNECCQCzEjPPcRxLr7CHFZKccSgzRo1Tt+nL+9D6yttz4DoMVTFzk2Pub8YzlW7KKp QOpmgiAZ2m5ztKVjwXgNCW5/zuIgScrAC1lxLwlC842NasQ7YO7/OaqiGI4gOPqKf0ai Jh/A== X-Gm-Message-State: APjAAAV5Aoo4HEodev8CEc8ELAFvuzkgE8FZL26qK9faHY3nXwROe7Kc iqLvMjGt+Y3fGEi08GygHOc= X-Google-Smtp-Source: APXvYqwa50kDHY1hgy7BL0arOAPNt2XIg8So3v6WgIr83tHXSi2YzHc1xlGmJ6vjWp9uEPY2DC7eVA== X-Received: by 2002:a1c:f413:: with SMTP id z19mr22995160wma.71.1555340044874; Mon, 15 Apr 2019 07:54:04 -0700 (PDT) Received: from localhost (p2E5BE61D.dip0.t-ipconnect.de. [46.91.230.29]) by smtp.gmail.com with ESMTPSA id a4sm36765263wmf.45.2019.04.15.07.54.03 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 15 Apr 2019 07:54:03 -0700 (PDT) Date: Mon, 15 Apr 2019 16:54:02 +0200 From: Thierry Reding To: Vidya Sagar Subject: Re: [PATCH V2 07/16] dt-bindings: PCI: designware: Add binding for CDM register check Message-ID: <20190415145402.GF29254@ulmo> References: <1554407683-31580-1-git-send-email-vidyas@nvidia.com> <1554407683-31580-8-git-send-email-vidyas@nvidia.com> MIME-Version: 1.0 In-Reply-To: <1554407683-31580-8-git-send-email-vidyas@nvidia.com> User-Agent: Mutt/1.11.4 (2019-03-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190415_075406_966807_006ACCFF X-CRM114-Status: GOOD ( 17.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, lorenzo.pieralisi@arm.com, mperttunen@nvidia.com, mmaddireddy@nvidia.com, linux-pci@vger.kernel.org, catalin.marinas@arm.com, will.deacon@arm.com, linux-kernel@vger.kernel.org, kthota@nvidia.com, kishon@ti.com, linux-tegra@vger.kernel.org, robh+dt@kernel.org, gustavo.pimentel@synopsys.com, jingoohan1@gmail.com, bhelgaas@google.com, jonathanh@nvidia.com, linux-arm-kernel@lists.infradead.org, sagar.tv@gmail.com Content-Type: multipart/mixed; boundary="===============7993215903296526933==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============7993215903296526933== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="wtUqn8XWZYmnPFNh" Content-Disposition: inline --wtUqn8XWZYmnPFNh Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Apr 05, 2019 at 01:24:34AM +0530, Vidya Sagar wrote: > Add support to enable CDM (Configuration Dependent Module) registers check > for any data corruption. CDM registers include standard PCIe configuration > space registers, Port Logic registers and iATU and DMA registers. > Refer Section S.4 of Synopsys DesignWare Cores PCI Express Controller Dat= abook > Version 4.90a >=20 > Signed-off-by: Vidya Sagar > --- > Changes since [v1]: > * This is a new patch in v2 series >=20 > Documentation/devicetree/bindings/pci/designware-pcie.txt | 4 ++++ > 1 file changed, 4 insertions(+) >=20 > diff --git a/Documentation/devicetree/bindings/pci/designware-pcie.txt b/= Documentation/devicetree/bindings/pci/designware-pcie.txt > index c124f9bc11f3..728281b5bcd5 100644 > --- a/Documentation/devicetree/bindings/pci/designware-pcie.txt > +++ b/Documentation/devicetree/bindings/pci/designware-pcie.txt > @@ -31,6 +31,10 @@ Optional properties: > - clock-names: Must include the following entries: > - "pcie" > - "pcie_bus" > +- cdm-check: This is a boolean property and if present enables automatic > + checking of CDM (Configuration Dependent Module) registers for data > + corruption. CDM registers include configuration space registers and i= ATU > + (internal Address Translation Unit) registers. By comparison the commit message also lists "Port Logic" and "DMA" registers as being part of the CDM registers. Shouldn't they be part of the bindings document as well? Perhaps it'd also be a good idea to rename this property to something more imperative, like "enable-cdm" or similar. Thierry > RC mode: > - num-viewport: number of view ports configured in hardware. If a platfo= rm > does not specify it, the driver assumes 2. > --=20 > 2.7.4 >=20 --wtUqn8XWZYmnPFNh Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAly0mwYACgkQ3SOs138+ s6FesxAApMVDuLHlIjYq7l6bKlBb4fa5bbXMIX7SnRy0GRIp585/YZ9j21gyDQhW IrO2pEeVogNhiTndF/QjSJ4SA0nkPeirMr2gYXjiFwGWDXx3L2UXHlbULgY0jCQY 3mprsgNzpQvHQsr8nH+uqIOjXxW4xSQaaFZeVYwhK1FOqZY/VwBfBho1tCJynXNL izZjuM1ijRBFzqcTmzjOTyk6v7wSPXokmQPFwxBe4sk9Q3JJqa8rMFH9tTv7XaVI t9l2d0lsH6+zJGuolqj0zF42kyoWrdFp/H75pQ6oh5NxbZyarpbJM0labiC8Ja/K 6+AprGEEqtg/Eu6LxeuLHBIaYoEQ7POtYI1oAufrxaQAt2PWsXqHMpKoTvfW24Q8 iW+47ijSI2fJ3rygSW//MOXHR0Z+EjwUi1ZlluiO7tV35YNqUmBKGzNB13hlm6W7 IRt/o9xbYbR4G+MHHBfKNCMbej5bmXFOvu7RxAhRAR2Tx9Hbo1I7guFcIk42Uvc/ loRQHU5Xg3evxfsjj7Tz3ulKom5GQA6lo8gZgX7+60BZQSNnYBSpz1dY3DA/JIf6 Inawqfn8FV9Q+35F2pjaoFKyFtQEDvmrOcbA6PrPafgXnlunGbGK6dEYL6RaLA6C TXWXOqbgoMuzqQXgObfEyWtEfJH7WkgJNlXK8yCyouItCvBWbco= =EtML -----END PGP SIGNATURE----- --wtUqn8XWZYmnPFNh-- --===============7993215903296526933== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============7993215903296526933==--