From: Bruno Thomsen <bruno.thomsen@gmail.com>
To: linux-arm-kernel@lists.infradead.org
Cc: devicetree@vger.kernel.org, laa@kamstrup.com, festevam@gmail.com,
s.hauer@pengutronix.de, clemens.ml@gmx.net,
bruno.thomsen@gmail.com, ksc@kamstrup.com, robh+dt@kernel.org,
linux-imx@nxp.com, kernel@pengutronix.de, shawnguo@kernel.org,
markus.niebel@tq-group.com
Subject: [PATCH v2] ARM: dts: bugfix tqma7 soft reset issue
Date: Tue, 16 Apr 2019 11:08:05 +0200 [thread overview]
Message-ID: <20190416090805.13166-1-bruno.thomsen@gmail.com> (raw)
In-Reply-To: <20190414120629.8912-1-bruno.thomsen@gmail.com>
Running reboot command on the TQMa7 board would just hang infinite
at the end of the system shutdown process.
Handling of i.MX7 errata e10574:
Watchdog: A watchdog timeout or software trigger will not reset the SOC.
Moved pinctrl from common mba7 to common tqma7 dtsi as it improves
readability of errata handling. Most integrators of this SoM will
likely use the development board as inspiration for handling this
SoC issue.
Signed-off-by: Bruno Thomsen <bruno.thomsen@gmail.com>
---
v2:
Moved pinctrl from common development board to common SoM.
Removed Markus reviewed-by as he only acked the fsl,ext-reset-output part.
arch/arm/boot/dts/imx7-mba7.dtsi | 11 -----------
arch/arm/boot/dts/imx7-tqma7.dtsi | 17 +++++++++++++++++
2 files changed, 17 insertions(+), 11 deletions(-)
diff --git a/arch/arm/boot/dts/imx7-mba7.dtsi b/arch/arm/boot/dts/imx7-mba7.dtsi
index 578341b6848b..50abf18ad30b 100644
--- a/arch/arm/boot/dts/imx7-mba7.dtsi
+++ b/arch/arm/boot/dts/imx7-mba7.dtsi
@@ -472,12 +472,6 @@
MX7D_PAD_LPSR_GPIO1_IO05__GPIO1_IO5 0x59
>;
};
-
- pinctrl_wdog1: wdog1grp {
- fsl,pins = <
- MX7D_PAD_LPSR_GPIO1_IO00__WDOG1_WDOG_B 0x30
- >;
- };
};
&pwm1 {
@@ -554,8 +548,3 @@
no-1-8-v;
status = "okay";
};
-
-&wdog1 {
- pinctrl-names = "default";
- pinctrl-0 = <&pinctrl_wdog1>;
-};
diff --git a/arch/arm/boot/dts/imx7-tqma7.dtsi b/arch/arm/boot/dts/imx7-tqma7.dtsi
index 85fe461e5e67..9aaed85138cb 100644
--- a/arch/arm/boot/dts/imx7-tqma7.dtsi
+++ b/arch/arm/boot/dts/imx7-tqma7.dtsi
@@ -209,6 +209,14 @@
};
};
+&iomuxc_lpsr {
+ pinctrl_wdog1: wdog1grp {
+ fsl,pins = <
+ MX7D_PAD_LPSR_GPIO1_IO00__WDOG1_WDOG_B 0x30
+ >;
+ };
+};
+
&sdma {
status = "okay";
};
@@ -228,5 +236,14 @@
};
&wdog1 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_wdog1>;
+ /*
+ * Errata e10574:
+ * WDOG reset needs to run with WDOG_RESET_B signal enabled.
+ * X1-51 (WDOG1#) signal needs carrier board handling to reset
+ * TQMa7 on X1-22 (RESET_IN#).
+ */
+ fsl,ext-reset-output;
status = "okay";
};
--
2.20.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-04-16 9:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-14 12:06 [PATCH] ARM: dts: bugfix tqma7 soft reset issue Bruno Thomsen
2019-04-14 15:32 ` Fabio Estevam
2019-04-14 16:10 ` Bruno Thomsen
2019-04-16 9:08 ` Bruno Thomsen [this message]
2019-04-22 0:52 ` [PATCH v2] " Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190416090805.13166-1-bruno.thomsen@gmail.com \
--to=bruno.thomsen@gmail.com \
--cc=clemens.ml@gmx.net \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=ksc@kamstrup.com \
--cc=laa@kamstrup.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=markus.niebel@tq-group.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).