From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A5D6C10F14 for ; Tue, 16 Apr 2019 10:39:11 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EFD9E2075B for ; Tue, 16 Apr 2019 10:39:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="RizoLqwM"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="q5bnxMle" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EFD9E2075B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=jLbEkTTogPCAJCsdSOSg3aUHv439dCKRWFFChsoOqyc=; b=RizoLqwMNMI5Uu zJpoO3pFQK/Gx2yUCjQLW+S/KS7fDwtnnaydNZZR5T/a046xPft6G7IA9V9hBzWXIxKtDHS93Vd18 3lSuPGGeEREd6SfgbjDGDEAPBQkTuOsIk37G4kSgjHuf3ncuSqTm561wgxKGyBlL9xX21zJqkZWhr X6IRLVdOwscE/aBJEjn8EELLUYYp03+zWsiBgn7YiSAWdM6qAPCUNNRHCfwXJKjvz+5xzEAQQgQwL lOyn9oSAik+0nN9pGsxn77DNs7XxZx5XEaoPaGUeBfIbuY2D7a8nx8tN19kY1Ruyw9tCJWDqr767d zyZ/A0kpC4lBOd0UkjNA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hGLUX-000479-T9; Tue, 16 Apr 2019 10:39:05 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hGLUG-0003oR-Lk; Tue, 16 Apr 2019 10:38:49 +0000 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E827C217F9; Tue, 16 Apr 2019 10:38:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1555411128; bh=dTCLOqJLgmceBABnPOvGU4HocMxOvoBRx6rxgvFEg5Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=q5bnxMleBXFUsq09ydLundcgYmmQMNKEtu702h+yRvUK5s810++ExYJxgNzvSs9Q4 ifkOcVlVknrbWaN+Oh7LtULvk+/D0YwuUoX0c1PuReuQhg98B20vGbHM+3Yzf/C4e6 x9omnw3aesCeC7vFYC4vUcYAr3niLarEGI3sHjzc= Date: Tue, 16 Apr 2019 12:15:06 +0200 From: Greg Kroah-Hartman To: Chunfeng Yun Subject: Re: [v2 PATCH 1/6] usb: xhci-mtk: get optional clock by devm_clk_get_optional() Message-ID: <20190416101506.GB26091@kroah.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.4 (2019-03-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190416_033848_725125_D5FE7730 X-CRM114-Status: GOOD ( 16.58 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mathias Nyman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, Matthias Brugger , linux-arm-kernel@lists.infradead.org, Marek Szyprowski Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Apr 10, 2019 at 02:47:24PM +0800, Chunfeng Yun wrote: > Use devm_clk_get_optional() to get optional clock > > Signed-off-by: Chunfeng Yun > --- > v2: no changes > --- > drivers/usb/host/xhci-mtk.c | 19 +++---------------- > 1 file changed, 3 insertions(+), 16 deletions(-) > > diff --git a/drivers/usb/host/xhci-mtk.c b/drivers/usb/host/xhci-mtk.c > index 60987c787e44..026fe18972d3 100644 > --- a/drivers/usb/host/xhci-mtk.c > +++ b/drivers/usb/host/xhci-mtk.c > @@ -206,19 +206,6 @@ static int xhci_mtk_ssusb_config(struct xhci_hcd_mtk *mtk) > return xhci_mtk_host_enable(mtk); > } > > -/* ignore the error if the clock does not exist */ > -static struct clk *optional_clk_get(struct device *dev, const char *id) > -{ > - struct clk *opt_clk; > - > - opt_clk = devm_clk_get(dev, id); > - /* ignore error number except EPROBE_DEFER */ > - if (IS_ERR(opt_clk) && (PTR_ERR(opt_clk) != -EPROBE_DEFER)) > - opt_clk = NULL; > - > - return opt_clk; > -} > - > static int xhci_mtk_clks_get(struct xhci_hcd_mtk *mtk) > { > struct device *dev = mtk->dev; > @@ -229,15 +216,15 @@ static int xhci_mtk_clks_get(struct xhci_hcd_mtk *mtk) > return PTR_ERR(mtk->sys_clk); > } > > - mtk->ref_clk = optional_clk_get(dev, "ref_ck"); > + mtk->ref_clk = devm_clk_get_optional(dev, "ref_ck"); > if (IS_ERR(mtk->ref_clk)) > return PTR_ERR(mtk->ref_clk); > > - mtk->mcu_clk = optional_clk_get(dev, "mcu_ck"); > + mtk->mcu_clk = devm_clk_get_optional(dev, "mcu_ck"); > if (IS_ERR(mtk->mcu_clk)) > return PTR_ERR(mtk->mcu_clk); > > - mtk->dma_clk = optional_clk_get(dev, "dma_ck"); > + mtk->dma_clk = devm_clk_get_optional(dev, "dma_ck"); Also, now that this clock (and the others here) are controlled by the devm infrastructure, do you have to change when you were cleaning up and stopping the clock? That logic seems to be the same here, which does not seem to be correct to me. Please also document that in your changelog comments when resending this series, as all of these patches have this issue as well. thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel