From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 152EDC10F13 for ; Tue, 16 Apr 2019 10:52:31 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D4CD220821 for ; Tue, 16 Apr 2019 10:52:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="D6bOnZlW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D4CD220821 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=the-dreams.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=M6FeEjLF2sJmkk6OASIcwagRzHUmsxun2IEscAjf+ok=; b=D6bOnZlW07S3BqlM97t7Wy8rK I5fCIEZRTNOi46gCy7GU6Sz0L0vTzHKGopXmWG0pD74yldgw0S9Dg5T8z1L8q0uz6ps6KYpH3MUnq vsc1/8/VlGtSxgYvJoFDHdh4J5P46W/uKqASIuymuI5m9zqKbFK3B78fCvwONfF/qMyMsmkEERvrL gttL08a/GNWEEe0+qiO3WBmJEh4gxM0gN1hiDe7eUZzII3eifq699Hm26b65nhqKWhcT8n6ysdvvC 6paZAPEVnSmZrukQgHuU2Isq8uzJjmKcxrQ80sUjOvhvL6mXVj+JcfBhh/cwG+yvOfmO/SMm+J4lC TvK5iSRKA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hGLhR-00028E-NB; Tue, 16 Apr 2019 10:52:25 +0000 Received: from sauhun.de ([88.99.104.3] helo=pokefinder.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hGLhO-00027t-Ju for linux-arm-kernel@lists.infradead.org; Tue, 16 Apr 2019 10:52:23 +0000 Received: from localhost (p54B332D3.dip0.t-ipconnect.de [84.179.50.211]) by pokefinder.org (Postfix) with ESMTPSA id DAB712C3637; Tue, 16 Apr 2019 12:52:21 +0200 (CEST) Date: Tue, 16 Apr 2019 12:52:21 +0200 From: Wolfram Sang To: Stefan Lengfeld Subject: Re: [PATCH 06/12] i2c: omap: Add the master_xfer_irqless hook Message-ID: <20190416105221.c7h4ktzzu4xmdht3@ninjato> References: <20190403124019.8947-1-wsa+renesas@sang-engineering.com> <20190403124019.8947-7-wsa+renesas@sang-engineering.com> <20190415220546.bvrp7jodgdq7phwg@porty> MIME-Version: 1.0 In-Reply-To: <20190415220546.bvrp7jodgdq7phwg@porty> User-Agent: NeoMutt/20170113 (1.7.2) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190416_035222_799404_583F6150 X-CRM114-Status: GOOD ( 13.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tero Kristo , Andy Shevchenko , Keerthy , Linus Walleij , linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Wolfram Sang , linux-i2c@vger.kernel.org, linux-tegra@vger.kernel.org, Simon Horman , linux-omap@vger.kernel.org, Peter Rosin , linux-arm-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============6717354613017491014==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============6717354613017491014== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="txtx6lpjzxgqvxdx" Content-Disposition: inline --txtx6lpjzxgqvxdx Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable > the subject line of this patch >=20 > i2c: omap: Add the master_xfer_irqless hook >=20 > still contains the old name of the callback '_irqless'. It should be > '_atomic' instead. >=20 >=20 > On Wed, Apr 03, 2019 at 02:40:13PM +0200, Wolfram Sang wrote: > > Add the master_xfer_irqless hook to enable i2c transactions >=20 > Here again. It should be 'master_xfer_atomic'. Yes, thanks, fixed! > > static int omap_i2c_xfer_msg(struct i2c_adapter *adap, > > - struct i2c_msg *msg, int stop) > > + struct i2c_msg *msg, int stop, bool polling) >=20 > Nitpick. In the patches for the other drivers the boolean flag is called > 'atomic' and not 'polling'. This patch originally is not from me, so I prefer to not change it. Also, I don't want to enforce strict naming within drivers. As long as it is readable, I am fine with it. > > static const struct i2c_algorithm omap_i2c_algo =3D { > > - .master_xfer =3D omap_i2c_xfer, > > + .master_xfer =3D omap_i2c_xfer_irq, > > + .master_xfer_atomic =3D omap_i2c_xfer_polling, >=20 > When consistency with other drivers is a goal, the functions should be > named like: >=20 > .master_xfe =3D omap_i2c_xfer, > .master_xfer_atomic =3D omap_i2c_xfer_atomic, >=20 > The first without a suffix and the second with the '_atomic' suffix. ditto. --txtx6lpjzxgqvxdx Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAly1s+UACgkQFA3kzBSg Kbbbzg/6AocTzfCzOeRPB/NVFcGqaiGYqcQk7Hy7UA6lLoQpit+Chf2zJb9XD2wn PmVDoRjkCLqX9nO6bZ7te2hayAVej50J/L7tdXWtV5icGbyQEEbAFR68Ipe+OQeB v7fAjShyYYwkUD/VuRospLZ7z3oYB5GFeu5FvHZ4IOdKAGhlaIRkcdHQAjb3L11P oMFCxS/WkKFeejPQChncWE0UkauM3ZT6ssE+mI55MdcK7OhG6QgTYwuYqaMK/k4E KCehQC2KvyT1TDxkDYGCHOWhSyO0DLjPNtRh8DF1I/NWh5GfsfaHDyOKJ7e9L6xa Y2JH4Y8pcb94B2hm831fedAuyf031gtYuZRxag3ZhfbZFGY55ubABk77lI+o6a+E 0ZJK3fMgQkZ4Iik0FFm+039vTwrcPLMZK4L2ZwreHyp7ER9kmlfxUT1Fi3ZonAcQ gy/juds3pyE/4T515+7WD7EAdbWIt1PC9oc3LgkJaEn1vbXGu4Nbg6XJ9ImaRsXs txDjlSClQgWBKuh76cIKR5oIhBD6vn6fzjxTN37Dwmc37lHXtC/X2qoQ3S+IcISv 0L47f1Jd53M6RVeLL1P89zH/CsmeByeqjYbNSTMnHoMEWw6g5VqaPGAfXgnbit83 3tW7UvQF0krApbKmJHZL0NCWVctO+tDmk7asjdnEn82uba3fGCg= =v1tF -----END PGP SIGNATURE----- --txtx6lpjzxgqvxdx-- --===============6717354613017491014== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============6717354613017491014==--