From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28FC1C10F13 for ; Tue, 16 Apr 2019 13:01:41 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EF61220693 for ; Tue, 16 Apr 2019 13:01:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="YGiF2TL+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EF61220693 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=/x9uYQNtdGHKILNEReRzZxI1wOzsj0Jo+yOpOK8wHSw=; b=YGiF2TL+i9t7teUlwP4H8n7mQ /O/8gt0vgFupFXTB7xiaYdsmJNmd+UHpxntIgMstreAOuuyhYL4Nt7dVErjSiRgnzpff4qJ+Fil5y bpi1ugxC1eghABjHtv7M/nFM3lqbtA30b9sn+8bDx5DAEZgLtYgg1fv62r1B90/sAjOnHe7dA2caI QlBzcOUQ4Dr9jXDDld+w87c/p65yCduH2Epo4MxTUkWtGIAmiRfTwj7GoKApY6BVbs5fjhywypXiM UDWuBSZkr7T/vMa8HhCWZpLGCvnOU4I4sP1CvyjBJoWG+FZds9iu+MQT4Rez0iWAxL3ehTNkOjU9d C5Xrqmtfw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hGNiR-0005ND-I4; Tue, 16 Apr 2019 13:01:35 +0000 Received: from relay12.mail.gandi.net ([217.70.178.232]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hGNiM-0005HS-2l for linux-arm-kernel@lists.infradead.org; Tue, 16 Apr 2019 13:01:34 +0000 Received: from localhost (aaubervilliers-681-1-42-238.w90-88.abo.wanadoo.fr [90.88.160.238]) (Authenticated sender: maxime.ripard@bootlin.com) by relay12.mail.gandi.net (Postfix) with ESMTPSA id 84DE320002B; Tue, 16 Apr 2019 13:00:57 +0000 (UTC) Date: Tue, 16 Apr 2019 15:00:57 +0200 From: Maxime Ripard To: Pablo =?utf-8?Q?Sebasti=C3=A1n?= Greco Subject: Re: [PATCH v2 2/6] ARM: dts: sun8i: v40: bananapi-m2-berry: Enable GMAC ethernet controller Message-ID: <20190416130057.bjaweorywikaa6ig@flea> References: <1555065186-8154-1-git-send-email-pgreco@centosproject.org> <1555065186-8154-3-git-send-email-pgreco@centosproject.org> <20190415075309.p7pgj62mmtmxsnnr@flea> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20180716 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190416_060130_420856_2873CA1D X-CRM114-Status: GOOD ( 19.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Chen-Yu Tsai , linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com, Rob Herring , linux-arm-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============3152561363914518750==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============3152561363914518750== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="2w42a2v2c5vbfesk" Content-Disposition: inline --2w42a2v2c5vbfesk Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable 65;5600;1c On Tue, Apr 16, 2019 at 07:47:09AM -0300, Pablo Sebasti=E1n Greco wrote: > > El 15/4/19 a las 04:53, Maxime Ripard escribi=F3: > > On Fri, Apr 12, 2019 at 07:33:01AM -0300, Pablo Greco wrote: > > > Just like the Bananapi M2 Ultra, the Bananapi M2 Berry has a Realtek > > > RTL8211E RGMII PHY tied to the GMAC. > > > The PMIC's DC1SW output provides power for the PHY, while the ALDO2 > > > output provides I/O voltages on both sides. > > > > > > Signed-off-by: Pablo Greco > > > --- > > > arch/arm/boot/dts/sun8i-v40-bananapi-m2-berry.dts | 30 ++++++++++++= +++++++++++ > > > 1 file changed, 30 insertions(+) > > > > > > diff --git a/arch/arm/boot/dts/sun8i-v40-bananapi-m2-berry.dts b/arch= /arm/boot/dts/sun8i-v40-bananapi-m2-berry.dts > > > index f05cabd..0d79e91 100644 > > > --- a/arch/arm/boot/dts/sun8i-v40-bananapi-m2-berry.dts > > > +++ b/arch/arm/boot/dts/sun8i-v40-bananapi-m2-berry.dts > > > @@ -50,6 +50,7 @@ > > > compatible =3D "sinovoip,bpi-m2-berry", "allwinner,sun8i-r40"; > > > > > > aliases { > > > + ethernet0 =3D &gmac; > > > serial0 =3D &uart0; > > > }; > > > > > > @@ -92,6 +93,22 @@ > > > status =3D "okay"; > > > }; > > > > > > +&gmac { > > > + pinctrl-names =3D "default"; > > > + pinctrl-0 =3D <&gmac_rgmii_pins>; > > > + phy-handle =3D <&phy1>; > > > + phy-mode =3D "rgmii"; > > > + phy-supply =3D <®_dc1sw>; > > > + status =3D "okay"; > > > +}; > > > + > > > +&gmac_mdio { > > > + phy1: ethernet-phy@1 { > > > + compatible =3D "ethernet-phy-ieee802.3-c22"; > > > + reg =3D <1>; > > > + }; > > > +}; > > > + > > > &i2c0 { > > > status =3D "okay"; > > > > > > @@ -123,6 +140,13 @@ > > > status =3D "okay"; > > > }; > > > > > > +®_aldo2 { > > > + regulator-always-on; > > > + regulator-min-microvolt =3D <2500000>; > > > + regulator-max-microvolt =3D <2500000>; > > > + regulator-name =3D "vcc-pa"; > > > +}; > > > + > > If this one provides power to the pins, it should be tied to the PIO > > node. > > In that case, I should fix the bananapi-m2-ultra the same way. Do you pre= fer > me to add those fixes to this series? If you have that board, then please add that yep. > Or is it better to apply this like it is, and I fix both together in a > separated series? No, please resend a new version. Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --2w42a2v2c5vbfesk Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXLXSCQAKCRDj7w1vZxhR xSSuAQCQ/kkSRgvp8XeaTQsZFfcjmgEBvvtjYDzpMrPJdVpClwD/Q3IuzuS0sWoE nYcAS9VzOQTUlt9QAbaD7EeaL/sdOQg= =0e9z -----END PGP SIGNATURE----- --2w42a2v2c5vbfesk-- --===============3152561363914518750== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============3152561363914518750==--