From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46270C10F13 for ; Tue, 16 Apr 2019 14:15:38 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1700B223DC for ; Tue, 16 Apr 2019 14:15:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="fLfGvFoz" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1700B223DC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Pw8lWiRYfEdvLPhe9G6HbsaoDGh7m2Ya+YiirxeR8mk=; b=fLfGvFoz7Hzh0b i76jh7ZiXoG/q/4gwRg1woOD4Z7ovxjniYVLkv7xug6Qhnpc7xSpYyxu0hFyRdOadRul5p/quPeCu EOqpqNCnFvRro7OxYHX1pXJJW7E5Y1wILnrxEQnu2WK/fQEYdEM5oY6BdH4UYjH1VAqCWGDTNHtrU jT1OZUvw8rz4O5vF+3tbuyc2/DcqHQ1HNZDJpM1HcQ9G5Tw3OuQQ9gmfGtHmRtEjN8HLb6Z5u1bQb lCmAh2Rju7CASJUlEQ74RxQmUnhpKI+3mM7ldgqZYDl/G8ohIKG1wEIcs306ERfuoaczZgjjQW+Li 5YC4jedikHg2KMSMFrGg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hGOrz-000366-Hr; Tue, 16 Apr 2019 14:15:31 +0000 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70] helo=foss.arm.com) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hGOrw-00035R-6H for linux-arm-kernel@lists.infradead.org; Tue, 16 Apr 2019 14:15:29 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B95BEEBD; Tue, 16 Apr 2019 07:15:27 -0700 (PDT) Received: from red-moon (unknown [10.1.197.39]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C58003F59C; Tue, 16 Apr 2019 07:15:24 -0700 (PDT) Date: Tue, 16 Apr 2019 15:15:25 +0100 From: Lorenzo Pieralisi To: Bjorn Helgaas Subject: Re: [PATCH v3 14/26] PCI: keystone: Add support for PCIe RC in AM654x Platforms Message-ID: <20190416141525.GD14705@red-moon> References: <20190325093947.32633-1-kishon@ti.com> <20190325093947.32633-15-kishon@ti.com> <20190413152633.GF126710@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190413152633.GF126710@google.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190416_071528_233497_686F75D2 X-CRM114-Status: GOOD ( 19.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Jesper Nilsson , Arnd Bergmann , Greg Kroah-Hartman , Jingoo Han , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@axis.com, Kishon Vijay Abraham I , Minghuan Lian , Rob Herring , Murali Karicheri , Gustavo Pimentel , Mingkai Hu , linux-omap@vger.kernel.org, Roy Zang , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Apr 13, 2019 at 10:26:33AM -0500, Bjorn Helgaas wrote: > On Mon, Mar 25, 2019 at 03:09:35PM +0530, Kishon Vijay Abraham I wrote: > > Add PCIe RC support for AM654x Platforms in pci-keystone.c > > > +static int ks_pcie_am654_msi_host_init(struct pcie_port *pp) > > +{ > > + struct dw_pcie *pci = to_dw_pcie_from_pp(pp); > > + struct device *dev = pci->dev; > > + > > + dev_vdbg(dev, "dummy function so that DW core doesn't configure MSI\n"); > > Drive-by nit: this is the first occurrence of dev_vdbg() in > drivers/pci, and while dev_vdbg() might be useful somewhere, I'm not > sure this is the place. > > It took me 10 minutes of archaeology to figure out what it is and how > to use it. Apparently it does nothing at all unless you define > VERBOSE_DEBUG, which can be set via Kconfig in a few cases: > > drivers/dma/Makefile:subdir-ccflags-$(CONFIG_DMADEVICES_VDEBUG) += -DVERBOSE_DEBUG > drivers/usb/dwc2/Makefile:ccflags-$(CONFIG_USB_DWC2_VERBOSE) += -DVERBOSE_DEBUG > drivers/usb/gadget/Makefile:subdir-ccflags-$(CONFIG_USB_GADGET_VERBOSE) += -DVERBOSE_DEBUG > > but is more commonly set by adding "#define VERBOSE_DEBUG" manually > in a source file. Neither one applies here, so I don't think this > actually does anything. > > Anyway, I suspect this particular message would make a lot of sense as > a *comment*, but maybe not as a mysterious dev_vdbg() that never > actually does anything. I agree. Kishon ? I would do what Bjorn suggests here, please let me know. Lorenzo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel