From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD587C10F13 for ; Wed, 17 Apr 2019 00:10:34 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A85C22177B for ; Wed, 17 Apr 2019 00:10:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="BTvDDHBz"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="fOEziz36" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A85C22177B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=11iUQ68Kt4oD7sSkFjR+xRkChKXcXPW/U3BmPw1FwAw=; b=BTvDDHBz4H0Npt 7ThWbDX8Hiyexc3tcnI9ARLUP4IkXBRiMR0GgQef+qvsH0mrBrwmcebOolqfV0PjhLj4GarfO4RNx otIArfb98ZjfNijFgYbOT5nmFKgpgXECDyf97vlNb5MHX+gDLkbu47TTI45xMOWTHQ96eaZt6kJAj ICm3iNKAd68W3ZTKDdyVBQExo4Jwm9ooE4OU6renvg5FgScObmJA8t4lhyhUctSPQgLZyLSPXQB0F +r8ZTjv9s2cPiKmNyqgEGPAC+Jduf6lBDsbk4EYmr4hl/j/aMJD0eytMY7pb79biTu4/VdgtvDAwk F771DZQAuQ9DIsnZR2Yw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hGY9X-0008WG-FH; Wed, 17 Apr 2019 00:10:15 +0000 Received: from mail-oi1-x242.google.com ([2607:f8b0:4864:20::242]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hGY9S-000887-RJ for linux-arm-kernel@lists.infradead.org; Wed, 17 Apr 2019 00:10:12 +0000 Received: by mail-oi1-x242.google.com with SMTP id e5so18580033oii.0 for ; Tue, 16 Apr 2019 17:10:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=tG11UApdE0fZ4fVm41WgSBkQ06LNXRSNBVicUfVujoU=; b=fOEziz36jffSVEOWsf1VF+wDilWAyDEP7f5cuS7YOeGKMvNglWFiCeJgJT4CZXSA7K q224hGCSQlQJwXjReHij8tD9J/KBh0w2aUH2jLbt/qRJ+50yGoxrxxvse9TlkROC3ghl oC0A/yVS5LFpith7m7/BdrAwy++1++xst85PnIj0daoojkMoXWWuAIrzlISd55CHrcku 85FA2pEz8gVyScOYAkfVaqHKnY/gsBFtKZAWV/sRP4HlhfsJl26gRSyXtayUp38GyulC A1cFhgClHImUTthA3JdTm6VIw1kJdniqqlU3PL1jWAK16jtuoFfXvyuHDHQbQuGsfe+O 6yqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=tG11UApdE0fZ4fVm41WgSBkQ06LNXRSNBVicUfVujoU=; b=Ed1WGpUwDl7ZysML7L7f/n48WlaAx7a0cerdBlCW1dzVHGBcjyl1JmxknsXMHnV8wi U9EwbDfgcMkmIQV0eXeywq5YPtY32yvvE+/0OtY1I1msfLEAn3GdKR2kifwx2t94Vqim Nga/Ioz1Xvvov82jTzYZIcjKqVElHPisyp0AZk91oCKMxGIyRK2Hvu0825T+TYmaBgd9 aZeYc8svlujncyB5OetBcay+UiDbh0wpar8iORXNuYcvLBVEMiMOnunuPXBbegcQIJNS PkS3M+Kt9dAqnNta7ZDHsrf0yCs7wIYVPDGLvD5GltWZZ5yheX5PLQVakA+uNV8xnqN+ K4og== X-Gm-Message-State: APjAAAXyo9w4Ha9mykPj6X1hN5NPih2158IMryIjiBjxLoEg+UNKhPtz CYwe4tefURAOdf60sXshOf91OQ== X-Google-Smtp-Source: APXvYqzG9eUioj55pOe05u86Q4URqNNLOizYdSOIkbebbmiHcoErmhEqLUSgeubaBc90wPLp18e48Q== X-Received: by 2002:aca:5184:: with SMTP id f126mr24879419oib.44.1555459806092; Tue, 16 Apr 2019 17:10:06 -0700 (PDT) Received: from leoy-ThinkPad-X240s (li808-42.members.linode.com. [104.237.132.42]) by smtp.gmail.com with ESMTPSA id q23sm22714722oic.45.2019.04.16.17.10.02 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 16 Apr 2019 17:10:04 -0700 (PDT) Date: Wed, 17 Apr 2019 08:09:59 +0800 From: Leo Yan To: Mathieu Poirier Subject: Re: [PATCH v5 1/4] dt-bindings: arm: coresight: Add new compatible for static replicator Message-ID: <20190417000959.GB6202@leoy-ThinkPad-X240s> References: <20190412102738.12679-1-leo.yan@linaro.org> <20190412102738.12679-2-leo.yan@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190416_171010_889209_EE55D8C1 X-CRM114-Status: GOOD ( 26.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Suzuki K Poulose , Alexander Shishkin , Linux Kernel Mailing List , Rob Herring , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Apr 16, 2019 at 02:18:40PM -0600, Mathieu Poirier wrote: > Hi Leo, > > On Fri, 12 Apr 2019 at 04:28, Leo Yan wrote: > > > > CoreSight uses below bindings for replicator: > > > > Dynamic replicator, aka. configurable replicator: > > "arm,coresight-dynamic-replicator", "arm,primecell"; > > > > Static replicator, aka. non-configurable replicator: > > "arm,coresight-replicator"; > > > > The compatible string "arm,coresight-replicator" is not an explicit > > naming to express the replicator is 'static'. To unify the naming > > convention, this patch introduces a new compatible string > > "arm,coresight-static-replicator" for the static replicator; the > > compatible string "arm,coresight-replicator" is kept for backward > > compatibility, but tag it as obsolete and suggest to use the new > > compatible string. > > > > As result CoreSight replicator have below bindings: > > > > Dynamic replicator: > > "arm,coresight-dynamic-replicator", "arm,primecell"; > > > > Static replicator: > > "arm,coresight-static-replicator"; > > "arm,coresight-replicator"; (obsolete) > > > > Signed-off-by: Leo Yan > > --- > > Documentation/devicetree/bindings/arm/coresight.txt | 7 +++++-- > > 1 file changed, 5 insertions(+), 2 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/arm/coresight.txt b/Documentation/devicetree/bindings/arm/coresight.txt > > index f8aff65ab921..d02d160fa8ac 100644 > > --- a/Documentation/devicetree/bindings/arm/coresight.txt > > +++ b/Documentation/devicetree/bindings/arm/coresight.txt > > @@ -69,7 +69,10 @@ its hardware characteristcs. > > > > * compatible: Currently supported value is (note the absence of the > > AMBA markee): > > - - "arm,coresight-replicator" > > + - Coresight Non-configurable Replicator: > > + "arm,coresight-static-replicator"; > > + "arm,coresight-replicator"; (OBSOLETE. For backward > > + compatibility and will be removed) > > > > * port or ports: see "Graph bindings for Coresight" below. > > > > @@ -169,7 +172,7 @@ Example: > > /* non-configurable replicators don't show up on the > > * AMBA bus. As such no need to add "arm,primecell". > > */ > > - compatible = "arm,coresight-replicator"; > > + compatible = "arm,coresight-static-replicator"; > > > > out-ports { > > #address-cells = <1>; > > -- > > 2.17.1 > > Since this is a binding patch it needs to be sent on its own. Thanks for reminding, Mathieu. Since this is the second time you remind me to send DT binding related patches separately, so I may misunderstand your meaning and want to get clarification to avoid making the same mistake for many times. Before I remembered in one patch set we need to organise patches with sending document patch (or document changing patch) ahead and then followed by the corresponding code change patch. So this can give the reviewers more clear context; and this also can present the merging dependency between document change patches and the code change patches. This is the rule I followed in this patch set and I sent to CoreSight and DT maintainers (and mailing lists) together. Please let me know what you think about this? And also welcome Rob/Mark's suggestions. Thanks, Leo Yan _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel