From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0369C10F12 for ; Wed, 17 Apr 2019 10:18:15 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BEADA21773 for ; Wed, 17 Apr 2019 10:18:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="fgAapYeS" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BEADA21773 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=dk0VMIWNUsT671K2Gue8WCsP0lC7pgBgjWwfKB+wilA=; b=fgAapYeSB9vFTK88sMohpfMcJ Gi0vO0uQxThDcI+ATCE2rSXdxPygpTeBHbrzf1tSxjlIU43H9AzqtpCGohGDqM5ZGq0XFtJARJlbR QKFW9Vr0VVor1ZueveapQpb4SaHEKYoRmYLh66w88kpjDC/rReM8wIiu7iSjCHdBuY/Qgknf31w6V 4CiMxHbcCQ1c6ZGGr4zLJSAg8M0nd0jIa6XziHmwHsPn18YLX9sVxjnF32RPfn30mg0/ChDbshVri jVlr6J1aPnMvqVUAPprrWfWhY3TO526xfcoHVOK327idAiFbpUulzgy51a/BJKQqIioBiyNxlWIxw sJHh3KB/Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hGhdn-00063O-Im; Wed, 17 Apr 2019 10:18:07 +0000 Received: from relay9-d.mail.gandi.net ([217.70.183.199]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hGhdk-00062Q-Qz for linux-arm-kernel@lists.infradead.org; Wed, 17 Apr 2019 10:18:06 +0000 X-Originating-IP: 90.88.160.238 Received: from localhost (aaubervilliers-681-1-42-238.w90-88.abo.wanadoo.fr [90.88.160.238]) (Authenticated sender: maxime.ripard@bootlin.com) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 107A5FF803; Wed, 17 Apr 2019 10:17:57 +0000 (UTC) Date: Wed, 17 Apr 2019 12:17:57 +0200 From: Maxime Ripard To: Pablo Greco Subject: Re: [PATCH v3 1/7] ARM: dts: sun8i: r40: bananapi-m2-ultra: Tie GMAC regulators to the PIO Message-ID: <20190417101757.traviffiulwnzr6x@flea> References: <1555492863-88860-1-git-send-email-pgreco@centosproject.org> <1555492863-88860-2-git-send-email-pgreco@centosproject.org> MIME-Version: 1.0 In-Reply-To: <1555492863-88860-2-git-send-email-pgreco@centosproject.org> User-Agent: NeoMutt/20180716 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190417_031805_018952_06A2694D X-CRM114-Status: GOOD ( 15.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Chen-Yu Tsai , linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com, Rob Herring , linux-arm-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============1033397310698597477==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============1033397310698597477== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="fdmpm7svpq5cq27l" Content-Disposition: inline --fdmpm7svpq5cq27l Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi, On Wed, Apr 17, 2019 at 06:20:56AM -0300, Pablo Greco wrote: > When the GMAC support was added to the bananapi-m2-ultra, regulators > weren't tied to the pinctrl. Fix that. > > Signed-off-by: Pablo Greco > --- > arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts b/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts > index c488aaa..3da3598 100644 > --- a/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts > +++ b/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts > @@ -201,6 +201,8 @@ > &pio { > pinctrl-names = "default"; > pinctrl-0 = <&clk_out_a_pin>; > + vcc-pa-supply = <®_aldo2>; You should list all the regulators that are needed for all the pin banks to operate properly, not just PA > + vcc-gmac-phy-supply = <®_dc1sw>; I'm not sure what that is supposed to do? Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --fdmpm7svpq5cq27l Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXLb9VQAKCRDj7w1vZxhR xf8xAP9/tBCV3pqWsdx40Wbj9v3n+77u5fjcUOjSXXpFHqRjvgD/V7U+fC3LiZK5 hhmuRwxUo1vmChUUFEH6SV+U/YsaHwg= =DIQ/ -----END PGP SIGNATURE----- --fdmpm7svpq5cq27l-- --===============1033397310698597477== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============1033397310698597477==--