From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1FE7C282DA for ; Wed, 17 Apr 2019 11:50:47 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7025C20872 for ; Wed, 17 Apr 2019 11:50:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Va60grr/"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Y+URAciQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7025C20872 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=kTvMtYcSHWJDCjiT4FiXPquv8H1u36Esa9hSxRkihGk=; b=Va60grr/Q0m0sc pAvmKm1p/OSEebTz1pyOOmXkj1UAXpCWlJfuBs9nBbEPEeJjH+M4oSH1mcFZ5r7hVv6P6iUIc3mEn iV9kuQsjhs/FcIFudCTG9EW6om/XB92XneSfBXPJ6QBm2mZyudy201890XSvObWK+07w9Zh9Wacfj cCzj5Mb+37A2RqPgM5T2dWIDq0C/schyb3JDLIHcNrPUQoIwrSjgq7c/wg5PFNchyzm5Gnroy87Z4 yM7TA7ZzDC6aS4yywaXpquOa4N/8o8dHUsiTPcK7XFEKY28N9/TGEQaIDni8KGbfGDJs8gOs2fnSY zMCHqDHoyOpjf8HN2L1g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hGj5J-0001of-Ll; Wed, 17 Apr 2019 11:50:37 +0000 Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hGj5G-0001oA-MN for linux-arm-kernel@lists.infradead.org; Wed, 17 Apr 2019 11:50:36 +0000 Received: by mail-wr1-x441.google.com with SMTP id w16so1585806wrl.1 for ; Wed, 17 Apr 2019 04:50:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=qXkceclKYogbXCLoeXJVlPi06thLC4AnNmyU4U76yv0=; b=Y+URAciQ+M8cmBS5dBKlsu+WhtMaPf7js4UjsiWn1RNagP6DfNTkIXBZB65yVLFgx1 dfs8AA+IZNEDxXIoinkKYo6Wi9cQOGMHfjmmmkEJrhY7KKaVPNZDH+80n5ihOJWzFr2o TaUwx+enLeKiPx35cCrIV84XH4UDS45GpApGV0pQQAHQR3MOYxdKQzdQoUFZyfz1qTH4 Csd0SmPg4Qd5K9YNCql477FVYlcBWULpCJit8zGrX7sf9MfdU1TRCScRsGZiM8H6chuV F+hen7472dLNuWdAumgrbuynaBeC14h3zR2N0qCysuU2dnzse3z4VnbaYD2WSnmXKgY9 tDiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=qXkceclKYogbXCLoeXJVlPi06thLC4AnNmyU4U76yv0=; b=m3Q5isia36PkVPn888unjTIQ1ZJO7WOAF7R7EHkY9Q0NXyCcGX3jFpF9SilsmtZVFm 8KWBiOxT1JBMBsgIKxcU3RoA+JcBXH1nCJqd8/WUfFfVZUgNmiMqRYP6Qf2psrHpBE2/ uO/SZf9az8xGdddX++wSOWms+B188NoeAmkmiQIYUKT/pHki48F/BlbvzZ74nlAHvv/d QPKBWAZ+v6ONv+5j00EtjB2m5rGIAT7OSiQi6e5fRCUqNEjeEOLLEbCl0oYyn2BNGeis S7NwBq2+pZs1/mpx2U/4NSHi857/6ukrTyMt8Orve68m3zbxMv4Fm8g+Km9lBhAKBKvE YUAw== X-Gm-Message-State: APjAAAWH9ofM+b3F1hV1L2vAuVgMt38XS7GemNmuLp6qLlCW0wVGgeYA GzYPjsNlWOZ8ZZQ11v3PczQ= X-Google-Smtp-Source: APXvYqwuGyhQU4JfmZ+mKtKc73dPprmppDk33S0gj+yhJiGjOazmrIIy6v2Mvk131dsFzqqeYpUhcw== X-Received: by 2002:a5d:62cc:: with SMTP id o12mr2266249wrv.142.1555501832488; Wed, 17 Apr 2019 04:50:32 -0700 (PDT) Received: from 5WDYG62 (static-css-cqn-143221.business.bouyguestelecom.com. [176.149.143.221]) by smtp.gmail.com with ESMTPSA id f128sm3778167wme.28.2019.04.17.04.50.31 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 17 Apr 2019 04:50:31 -0700 (PDT) Date: Wed, 17 Apr 2019 13:50:25 +0200 From: Romain Izard To: Alexandre Belloni Subject: Re: [PATCH v2 9/9] misc: atmel_tclib: do not probe already used TCBs Message-ID: <20190417114934.GA28520@5WDYG62> References: <20190415150856.9384-1-alexandre.belloni@bootlin.com> <20190415150856.9384-10-alexandre.belloni@bootlin.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190415150856.9384-10-alexandre.belloni@bootlin.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190417_045034_733601_D583F0AC X-CRM114-Status: GOOD ( 16.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Arnd Bergmann , Alexander Dahl , Sebastian Andrzej Siewior , Daniel Lezcano , linux-kernel@vger.kernel.org, Thomas Gleixner , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Apr 15, 2019 at 05:08:56PM +0200, Alexandre Belloni wrote: > The TCBs that have children are using the proper DT bindings and don't need > to be handled by tclib. > > Cc: Arnd Bergmann > Signed-off-by: Alexandre Belloni > --- > drivers/misc/atmel_tclib.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/misc/atmel_tclib.c b/drivers/misc/atmel_tclib.c > index 194f774ab3a1..c1f5aba1c6f2 100644 > --- a/drivers/misc/atmel_tclib.c > +++ b/drivers/misc/atmel_tclib.c > @@ -111,6 +111,9 @@ static int __init tc_probe(struct platform_device *pdev) > struct resource *r; > unsigned int i; > > + if (of_get_child_count(pdev->dev.of_node)) > + return 0; > + > irq = platform_get_irq(pdev, 0); > if (irq < 0) > return -EINVAL; This lead to a panic during shutdown, as tc_shutdown is called on the device that has not been initialized and it has not been designed for this. -- Romain Izard _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel