From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8361C282DA for ; Wed, 17 Apr 2019 12:14:09 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 98F9720872 for ; Wed, 17 Apr 2019 12:14:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="q5/uF+MB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 98F9720872 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=hofr.at Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=saqzH5Bqtqa97ksKozNTZJy46/k+UJjDjTQjY/P3Y7U=; b=q5/uF+MBmqe6th SeWmsjxTD0vJWcRAn8LTwDN4fGRPS6Cyrem5ARbscPpAfblX5bTXQ4yULZ5IK3Ky9lSHzgJDrVlqX aa4Y/gcxMJl8puYOx/Yl6BWbfxMSnZOa6ETBMALOWBL8DmFVDcz2NbyV4WlGBa64/ykPlG/uXdugI yu+JPMpG4YzPIulC8sgJL9Q+nPSIeFf1o1OKtLp6Xi0UfoE1SebDFp4h+uWNQxhdV5OTp1Alk3Hda Tx/hud+2NlTv8uo0yIHU7bE03uaie4So1fiBTqorTVqa+DoU+K+Zwbj24cfWH21YZeqfcyijRsmsV n8vS2m041iZatKE5G8oQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hGjS0-0002RW-Ue; Wed, 17 Apr 2019 12:14:04 +0000 Received: from 178.115.242.59.static.drei.at ([178.115.242.59] helo=mail.osadl.at) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hGjRy-0002Qc-5T for linux-arm-kernel@lists.infradead.org; Wed, 17 Apr 2019 12:14:03 +0000 Received: by mail.osadl.at (Postfix, from userid 1001) id BFA075C2F68; Wed, 17 Apr 2019 14:13:09 +0200 (CEST) Date: Wed, 17 Apr 2019 14:13:09 +0200 From: Nicholas Mc Guire To: Gregory CLEMENT Subject: Re: [PATCH V2] ARM: mvebu: at least report the kzalloc failure Message-ID: <20190417121309.GA20864@osadl.at> References: <1555386991-8855-1-git-send-email-hofrat@osadl.org> <20190416133957.GB29190@lunn.ch> <20190417114228.GA20280@osadl.at> <877ebsal7z.fsf@FE-laptop> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <877ebsal7z.fsf@FE-laptop> User-Agent: Mutt/1.5.23 (2014-03-12) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190417_051402_402003_2CE402FD X-CRM114-Status: GOOD ( 17.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , Jason Cooper , linux-kernel@vger.kernel.org, Russell King , Nicholas Mc Guire , linux-arm-kernel@lists.infradead.org, Sebastian Hesselbarth Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Apr 17, 2019 at 02:07:44PM +0200, Gregory CLEMENT wrote: > Hi Nicholas, > > Nicholas Mc Guire writes: > > > On Tue, Apr 16, 2019 at 03:39:57PM +0200, Andrew Lunn wrote: > >> On Tue, Apr 16, 2019 at 05:56:31AM +0200, Nicholas Mc Guire wrote: > >> > >> > Note that this will trigger a checkpatch WARNING > >> > "WARNING: Possible unnecessary 'out of memory' message" > >> > but comparing the oops with an without the one-line pr_err I would > >> > argue that it makes sense to include it: > >> > >> Hi Nicholas > >> > >> It might be worth adding this as a comment, so that newbies don't > >> submit patches removing the pr_err() because of the checkpatch > >> warning. > >> > > hmm... I think if we start doing that we would make quite a mess of > > documentation in the kernel. Also note its a warning stating "possible > > unneceessary" - so I would not see the necessity. > > > > At most I would include a note on this in the commit message so that > > anyone checking the origin would see that this is intenttional - assuming > > that people modifying code would be using git blame to locate the > > origin of any code... > > Don't bother to send a new version I don't attempt to take this > patch. As you pointed it is very unlikely that we get an error so early > during the boot for a very small amount of memory. > > If it happened then we have serious trouble and the message provided by > the BUG() call will be more than enough. > yup - its a corner case - I'm trying to filter out those cases that are actually in __init function returning void - as those cases are, it seems, are generally cases where k{m,z}allocs will not have explicit checking. thx! hofrat _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel