From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6626C282DA for ; Wed, 17 Apr 2019 20:14:33 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 71A8A217D7 for ; Wed, 17 Apr 2019 20:14:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="UB8CaAlO"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Xp1npuED" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 71A8A217D7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=q9HiCK8vuhVYXcnH4gh7VGFU9k6+egovNuH8Kx9/rfg=; b=UB8CaAlOl4Xo8n +kxXCd7Gm2sjoKbrI1b4408quMKtonnT/m3/pMsSdKgiTAO/9dhA21AOSjwOF/GEXZTg3m686rLT9 C70yXqgPR93MMAV61uC984OuRFfhNkOPbH8LbfDEt0rqNyeWAQKeEksNiuxkaGDJZ0Oyizxg+SMrD H9v//sxNzXvU4ZGaOvm1swW5jZErpv5zJRD8kjR4nmR8KpNqDvClOdGdybDVyAkXSn7ZNUhRVMCc5 nhbw/y3rqaPU4RVGyRWqs8N0joVp5mQzfC50NRF9fHRFVxLt6JwcIvLNpATaM9cUFnCCeqvKfNZ+r zc4N0XQmYkx01P/pOm4w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hGqwt-00023s-St; Wed, 17 Apr 2019 20:14:27 +0000 Received: from mail-pg1-x541.google.com ([2607:f8b0:4864:20::541]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hGqwr-00023V-Jh for linux-arm-kernel@lists.infradead.org; Wed, 17 Apr 2019 20:14:26 +0000 Received: by mail-pg1-x541.google.com with SMTP id k19so63156pgh.0 for ; Wed, 17 Apr 2019 13:14:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=JC9yE9af9U2pjoW4U5FTdo35gfxjQacok5B8LzuugEg=; b=Xp1npuEDfQM5yQ8o38lrgZXhNchh+lFGixQKIsPhWNR4eYtjSFDoMZGiZfo7rAz1+Y iLypeviky4swWurmPF00UWhyRT1DnBvt4TiO5uJdhXPipKUMqOXUFSyUdXCZEzb37nS7 C6cHUBb1/iPis0exByaGpw1Em+UZZbq09sHf7lATPqBDGC4r6xZvuLi/gGfjag8aTivg ayaoD20t+GflGDi0vF2oya6IIeVj/UcdLmUd0z6CrDxJsjOMfwjVJmQ4CQ2h7soYhscL CXowtbkGQnx5Wr9H8TuArXOMr1QABEbHHM5z0C4k/UIN0KgAGGgfETTufVmweI+OsKuT +abw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=JC9yE9af9U2pjoW4U5FTdo35gfxjQacok5B8LzuugEg=; b=CTRFtE1QvAfxqBQisNvOeBbuanfQarBrREwL5Ud32498dtZPi2xxJ8W4h9bQ6HGTKK nlwFU/wMoiIcW/0W9WPXbAp7qaUbJbhUjUcjzEp3Tq9if2qdULss24YOuvdz/lEcE/7z fFNRdJJM43KG9POxUIqW6CJhYY6AUs1hTxAjh+8zyTlC89+iU48i4VKPsxaA0zjgNfiH IWGDGs00ZLMDz4/Cfv6pc77NfFnGg33FIUlOVStk9rt6fSWmenwbtyk1yaZ7vDK3kHfw lM0Vkodd+RL1/pvDq5O80hm1zoxKw6TkHspA5JjM/CAtC+VLxSPT9DvMgG++7ZJvKGFQ Kstw== X-Gm-Message-State: APjAAAU8OUfdaJV5L6muQTQNiveEWYbyClFJeECDYXyazKMwfVfATajI pFYjrtnLgfGDcEyUrTl73QOexg== X-Google-Smtp-Source: APXvYqyFgWSqZZj7Wgvce0yQqH+MvtD/uGa5qgRRsbnk/36/kOunYTaSzfgElO9q6jVDiU8t+1RnbQ== X-Received: by 2002:a65:494b:: with SMTP id q11mr1663726pgs.444.1555532063782; Wed, 17 Apr 2019 13:14:23 -0700 (PDT) Received: from xps15 (S0106002369de4dac.cg.shawcable.net. [68.147.8.254]) by smtp.gmail.com with ESMTPSA id p7sm31035pfp.70.2019.04.17.13.14.22 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 17 Apr 2019 13:14:23 -0700 (PDT) Date: Wed, 17 Apr 2019 14:14:21 -0600 From: Mathieu Poirier To: Suzuki K Poulose Subject: Re: [PATCH v2 06/36] coresight: funnel: Clean up device book keeping Message-ID: <20190417201421.GA14163@xps15> References: <1555344260-12375-1-git-send-email-suzuki.poulose@arm.com> <1555344260-12375-7-git-send-email-suzuki.poulose@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1555344260-12375-7-git-send-email-suzuki.poulose@arm.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190417_131425_655519_AD34F59E X-CRM114-Status: GOOD ( 18.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: coresight@lists.linaro.org, rjw@rjwysocki.net, linux-kernel@vger.kernel.org, robert.walker@arm.com, linux-arm-kernel@lists.infradead.org, mike.leach@linaro.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Apr 15, 2019 at 05:03:49PM +0100, Suzuki K Poulose wrote: > In preparation to use a consistent device naming scheme, > clean up the device link tracking in funnel driver. > Use the "coresight" device instead of the "real" parent device > for all internal purposes. All other requests (e.g, power management, > DMA operations) must use the "real" device which is the parent device. > > Cc: Mathieu Poirier > Signed-off-by: Suzuki K Poulose > --- > drivers/hwtracing/coresight/coresight-funnel.c | 10 ++++------ > 1 file changed, 4 insertions(+), 6 deletions(-) > > diff --git a/drivers/hwtracing/coresight/coresight-funnel.c b/drivers/hwtracing/coresight/coresight-funnel.c > index 9279251..1085f31 100644 > --- a/drivers/hwtracing/coresight/coresight-funnel.c > +++ b/drivers/hwtracing/coresight/coresight-funnel.c > @@ -37,7 +37,6 @@ > */ > struct funnel_drvdata { > void __iomem *base; > - struct device *dev; Please remove @dev from the structure documentation. With that: Reviewed-by: Mathieu Poirier > struct clk *atclk; > struct coresight_device *csdev; > unsigned long priority; > @@ -77,7 +76,7 @@ static int funnel_enable(struct coresight_device *csdev, int inport, > rc = funnel_enable_hw(drvdata, inport); > > if (!rc) > - dev_dbg(drvdata->dev, "FUNNEL inport %d enabled\n", inport); > + dev_dbg(&csdev->dev, "FUNNEL inport %d enabled\n", inport); > return rc; > } > > @@ -105,7 +104,7 @@ static void funnel_disable(struct coresight_device *csdev, int inport, > > funnel_disable_hw(drvdata, inport); > > - dev_dbg(drvdata->dev, "FUNNEL inport %d disabled\n", inport); > + dev_dbg(&csdev->dev, "FUNNEL inport %d disabled\n", inport); > } > > static const struct coresight_ops_link funnel_link_ops = { > @@ -160,11 +159,11 @@ static ssize_t funnel_ctrl_show(struct device *dev, > u32 val; > struct funnel_drvdata *drvdata = dev_get_drvdata(dev->parent); > > - pm_runtime_get_sync(drvdata->dev); > + pm_runtime_get_sync(dev->parent); > > val = get_funnel_ctrl_hw(drvdata); > > - pm_runtime_put(drvdata->dev); > + pm_runtime_put(dev->parent); > > return sprintf(buf, "%#x\n", val); > } > @@ -199,7 +198,6 @@ static int funnel_probe(struct amba_device *adev, const struct amba_id *id) > if (!drvdata) > return -ENOMEM; > > - drvdata->dev = &adev->dev; > drvdata->atclk = devm_clk_get(&adev->dev, "atclk"); /* optional */ > if (!IS_ERR(drvdata->atclk)) { > ret = clk_prepare_enable(drvdata->atclk); > -- > 2.7.4 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel