From: "Leonidas P. Papadakos" <papadakospan@gmail.com>
To: Rob Herring <robh+dt@kernel.org>,
Heiko Stuebner <heiko@sntech.de>,
Jose Abreu <jose.abreu@synopsys.com>,
Robin Murphy <robin.murphy@arm.com>
Cc: devicetree@vger.kernel.org,
"Leonidas P. Papadakos" <papadakospan@gmail.com>,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org
Subject: [PATCH] arm64: dts: rockchip: set TX PBL for rk3328-roc-cc gmac
Date: Thu, 18 Apr 2019 00:01:00 +0300 [thread overview]
Message-ID: <20190417210059.26262-1-papadakospan@gmail.com> (raw)
Some rockchip boards have issues with tx checksumming for packets
larger than 1498 B.
An iperf test will tell you that transmissions stop almost immediately.
A workaround to this issue is disabling TX checksumming offload,
and one of the ways to do that is snps,force_thresh_dma_mode.
But after some discussion here it seems there is another path:
https://lkml.org/lkml/2019/4/5/148
Setting txpbl is a better-performing (maybe temporary) solution
compared to disabling T offload.
In my testing with a Libre Computer Renegade, this was the best
all-around option, and increasing the MTU doesn't cause a queue timeout anymore.
Signed-off-by: Leonidas P. Papadakos <papadakospan@gmail.com>
---
arch/arm64/boot/dts/rockchip/rk3328-roc-cc.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3328-roc-cc.dts b/arch/arm64/boot/dts/rockchip/rk3328-roc-cc.dts
index 5d499c908..974f2dcdf 100644
--- a/arch/arm64/boot/dts/rockchip/rk3328-roc-cc.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3328-roc-cc.dts
@@ -141,10 +141,10 @@
phy-mode = "rgmii";
pinctrl-names = "default";
pinctrl-0 = <&rgmiim1_pins>;
- snps,force_thresh_dma_mode;
snps,reset-gpio = <&gpio1 RK_PC2 GPIO_ACTIVE_LOW>;
snps,reset-active-low;
snps,reset-delays-us = <0 10000 50000>;
+ snps,txpbl = <0x4>;
tx_delay = <0x24>;
rx_delay = <0x18>;
status = "okay";
--
2.21.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next reply other threads:[~2019-04-17 21:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-17 21:01 Leonidas P. Papadakos [this message]
2019-04-21 16:00 ` [PATCH] arm64: dts: rockchip: set TX PBL for rk3328-roc-cc gmac Peter Geis
2019-04-22 6:43 ` Leonidas P. Papadakos
2019-04-22 11:57 ` Peter Geis
2019-04-22 13:13 ` Leonidas P. Papadakos
2019-05-23 0:00 ` Peter Geis
2019-06-14 9:26 ` Heiko Stuebner
2019-06-15 12:27 ` Peter Geis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190417210059.26262-1-papadakospan@gmail.com \
--to=papadakospan@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=jose.abreu@synopsys.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).