From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E868AC282DA for ; Wed, 17 Apr 2019 21:40:54 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B64E620872 for ; Wed, 17 Apr 2019 21:40:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="i5WVOoob"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="LpYtswht" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B64E620872 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Jg0OiUqrtBV6YBg0K/Ln8DSPctrsPkmGexvurYTRWng=; b=i5WVOoobyM4icM e61AdA2hHq+keU3o5eQrt8gWzlj1ceErsXKOuoagtDnj1SBkERSAn0h1ThrKm+Y4qxQRIA+0Sgkh0 wefaugw1tzR48HPISzYQYMxqc5tE+iwYTnPiLotfuCxpJlbTjP/l/E3jAuV8kgB9iwjAZl9RqCGe+ b/qcLesGfvUs/r32ePp7LeyPduWU8AR9ltOSfVL375GC573qIguzaKlzfoGf1vjO6hcfknFsCzD4Y wrGvT3Dhpfema/gAUl/um2VTkCw4eMXPEognAkLaQgOqy6UO8znYlUzz3WCYns/GSYXHn2Ad8a7lX CN+Um164N33AJ5Eq0dPQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hGsIS-0004Jy-Pz; Wed, 17 Apr 2019 21:40:48 +0000 Received: from mail-pl1-x644.google.com ([2607:f8b0:4864:20::644]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hGsIP-0004JU-M9 for linux-arm-kernel@lists.infradead.org; Wed, 17 Apr 2019 21:40:47 +0000 Received: by mail-pl1-x644.google.com with SMTP id g12so97937pll.11 for ; Wed, 17 Apr 2019 14:40:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=MConUnIDofKdP9/LKRQO9enfwB2tflTa4i6eF064n+E=; b=LpYtswhtzAnN9/OmBZ9Uw7y3vra4vyZyVP4S7xrrD6JjbcR0U9FhN1pcX6F1l9MPKC RPvzCW5t3XT/4wzdOg4qv6m7Rrpt22pDQwHPu89zYMLDnzNpLejLer6SngXOKAqUGHum AE61ivem6y7pgzFEpqc4YsMcWT+n0SpEc0GaSYqRQkJSjpN3/P9G+Y2T1rU/rexHRL9z hlnzbWC04QhuFUyWmbQWyb1xKaCVLGTBOnlAMwVMaZR0EJIvVQ/wJJ1On54RmlxbzXne rbPSn7lZBOb1bkwofm+jJwvOhJaYT50yoDZKqTLyr7wpxLCPRVtAquckLe7ZvD/iU/YH xWhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=MConUnIDofKdP9/LKRQO9enfwB2tflTa4i6eF064n+E=; b=eRHHpE9Zn86o2uyo9ISbheFfhkfHMQ/tXjw+G3Z2hP5zHSBjOOqfdyYVFESIykfcPH 9TDAlJIMQ528Okez0nLSENfljF9j2+GavIM1zz71CXQYgvgnOpkT3h9FaV8oARnR68VM 1lpYdvI4G1Y8MQXPOEEe+xED6S10fzdwdxW3GvZqcinYwd/AcoqySUsAMr8xcDjecvut Mlwx7j4vl9VKFAA6yviBdLTERVllpOZFNYgajELMg9fcRg7FEJeSXNi+Gr2NHaKWkyLP ameXiSrb1KuzWJaAsWx3BeZVGfy5UiX4R2WBnQ7hrUEYwEhOkx93/CH9ANVXxKziaVfA vsvQ== X-Gm-Message-State: APjAAAWaJhOgHMuafh2E8DvSIepIhkLZlF5k3E4oPsWmNUiLoXHM0f+e L0bSA0Y/iShK9yVoNboVaYmcfA== X-Google-Smtp-Source: APXvYqwYHC0jsOIkLvpmHhjZMw4P4Nd3XzTucVvy6DXPiWcTSIhYvtEJoQUJ8nS9c/DPT3TXU1EVNQ== X-Received: by 2002:a17:902:364:: with SMTP id 91mr78552321pld.72.1555537245019; Wed, 17 Apr 2019 14:40:45 -0700 (PDT) Received: from xps15 (S0106002369de4dac.cg.shawcable.net. [68.147.8.254]) by smtp.gmail.com with ESMTPSA id t5sm163668pfh.141.2019.04.17.14.40.43 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 17 Apr 2019 14:40:43 -0700 (PDT) Date: Wed, 17 Apr 2019 15:40:41 -0600 From: Mathieu Poirier To: Suzuki K Poulose Subject: Re: [PATCH v2 09/36] coresight: catu: Cleanup device specific data Message-ID: <20190417214041.GD14163@xps15> References: <1555344260-12375-1-git-send-email-suzuki.poulose@arm.com> <1555344260-12375-10-git-send-email-suzuki.poulose@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1555344260-12375-10-git-send-email-suzuki.poulose@arm.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190417_144045_729514_8B17DA40 X-CRM114-Status: GOOD ( 17.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: coresight@lists.linaro.org, rjw@rjwysocki.net, linux-kernel@vger.kernel.org, robert.walker@arm.com, linux-arm-kernel@lists.infradead.org, mike.leach@linaro.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Apr 15, 2019 at 05:03:52PM +0100, Suzuki K Poulose wrote: > Switch to using the CoreSight device instead of the real > amba device. > > Cc: Mathieu Poirier > Signed-off-by: Suzuki K Poulose > --- > drivers/hwtracing/coresight/coresight-catu.c | 13 +++++++------ > drivers/hwtracing/coresight/coresight-catu.h | 1 - > 2 files changed, 7 insertions(+), 7 deletions(-) > > diff --git a/drivers/hwtracing/coresight/coresight-catu.c b/drivers/hwtracing/coresight/coresight-catu.c > index ba3c005..14d1cf5 100644 > --- a/drivers/hwtracing/coresight/coresight-catu.c > +++ b/drivers/hwtracing/coresight/coresight-catu.c > @@ -408,13 +408,14 @@ static int catu_enable_hw(struct catu_drvdata *drvdata, void *data) > int rc; > u32 control, mode; > struct etr_buf *etr_buf = data; > + struct device *dev = &drvdata->csdev->dev; > > if (catu_wait_for_ready(drvdata)) > - dev_warn(drvdata->dev, "Timeout while waiting for READY\n"); > + dev_warn(dev, "Timeout while waiting for READY\n"); > > control = catu_read_control(drvdata); > if (control & BIT(CATU_CONTROL_ENABLE)) { > - dev_warn(drvdata->dev, "CATU is already enabled\n"); > + dev_warn(dev, "CATU is already enabled\n"); > return -EBUSY; > } > > @@ -440,7 +441,7 @@ static int catu_enable_hw(struct catu_drvdata *drvdata, void *data) > catu_write_irqen(drvdata, 0); > catu_write_mode(drvdata, mode); > catu_write_control(drvdata, control); > - dev_dbg(drvdata->dev, "Enabled in %s mode\n", > + dev_dbg(dev, "Enabled in %s mode\n", > (mode == CATU_MODE_PASS_THROUGH) ? > "Pass through" : > "Translate"); > @@ -461,15 +462,16 @@ static int catu_enable(struct coresight_device *csdev, void *data) > static int catu_disable_hw(struct catu_drvdata *drvdata) > { > int rc = 0; > + struct device *dev = &drvdata->csdev->dev; > > catu_write_control(drvdata, 0); > coresight_disclaim_device_unlocked(drvdata->base); > if (catu_wait_for_ready(drvdata)) { > - dev_info(drvdata->dev, "Timeout while waiting for READY\n"); > + dev_info(dev, "Timeout while waiting for READY\n"); > rc = -EAGAIN; > } > > - dev_dbg(drvdata->dev, "Disabled\n"); > + dev_dbg(dev, "Disabled\n"); > return rc; > } > > @@ -519,7 +521,6 @@ static int catu_probe(struct amba_device *adev, const struct amba_id *id) > goto out; > } > > - drvdata->dev = dev; > dev_set_drvdata(dev, drvdata); > base = devm_ioremap_resource(dev, &adev->res); > if (IS_ERR(base)) { > diff --git a/drivers/hwtracing/coresight/coresight-catu.h b/drivers/hwtracing/coresight/coresight-catu.h > index 1b281f0..96ea8c4 100644 > --- a/drivers/hwtracing/coresight/coresight-catu.h > +++ b/drivers/hwtracing/coresight/coresight-catu.h > @@ -61,7 +61,6 @@ > #define CATU_IRQEN_OFF 0x0 > > struct catu_drvdata { > - struct device *dev; > void __iomem *base; > struct coresight_device *csdev; > int irq; Reviewed-by: Mathieu Poirier > -- > 2.7.4 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel