From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41D16C282DA for ; Wed, 17 Apr 2019 21:41:52 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1160D20872 for ; Wed, 17 Apr 2019 21:41:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="igBYJfk4"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="AazDcyvO" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1160D20872 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=IRjlUZHV9vzsF7IuIzM2zyvjK7o8frIvSFeLQcBBjOs=; b=igBYJfk4a6pDVP fNGNnEiKROmcyoBXd0BV/BC3UO7/EIr/tn4T3AkP7GnAmWruMBwh40P/ht7G7aYwQTpW8EgeEaZ1q gZbCdYQBr1B1741s/AXt0Ec34HHRdNME8bxunkAg8XpocZOkBN8riYPzxknDK1jOfA7OffLrNLBDv 4qnZyuU2gv9X22hC86P+bcrtVikfZnexkKaRqUbOuzIh5MPdBTbMR3NMNEnZVXWe0FMT8tfjZhbQ3 6FJQxvJ0zzcmYGn3Iyq4xYXFT4/LzNFtqbEf2ClAKhOgeDbtZbEJGNxvp/w/k+foY88e9McRNV4fR 5HwCKBUjbokU5Z/YcwEA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hGsJR-0004ap-M0; Wed, 17 Apr 2019 21:41:49 +0000 Received: from mail-pg1-x543.google.com ([2607:f8b0:4864:20::543]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hGsJP-0004aW-Ax for linux-arm-kernel@lists.infradead.org; Wed, 17 Apr 2019 21:41:48 +0000 Received: by mail-pg1-x543.google.com with SMTP id y3so133889pgk.12 for ; Wed, 17 Apr 2019 14:41:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=yZ9SeRh+I92cdeR9Te1IKI13XPUurU8AmNT0L6J6l2w=; b=AazDcyvOSGwA8SDsYtFFXnJ/yiaj4PyxS4h943e8NaOM/znrvtUHVXUlC436zH7kPU snJaIOuZjzriu3VXFMAdmzkg82LOKP6fL7YD8yb/5dmLI9prQBjOxZlL/3SJCva4pEix kz0Q3GLPL9YlxGNQzMnhew2t2hOBHplbkgRxYhaKhOulpo7e+VLvaRXwsSYXFLQ5Mx1L g8CJr0ajy/ccK4IyCugnJCyWCVMQoUOFFSr/GuU+4ElxMv2g/7U14smifbaiPJl8be/x Wgoit2DaBL79s9X33hFxdCGdVEBLZi3fbCtaNB0w9Ej5ZQR9vomfu9lwkaJ4m55KGFAE qBFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=yZ9SeRh+I92cdeR9Te1IKI13XPUurU8AmNT0L6J6l2w=; b=QLs/ZDIUPAkqo8MNBbSEiYZaQgJ6halWhV5uDOYmj+3yBiTYl3pNlLX2CIqzsScXc2 UaiP+eLTNC84MA8ivTLqmFEFO+kDVm5pnmmhUqw7EJGwEhTiH4+b7rF0doMi7+1tscs8 +HHPFmG4FT7/LNHIomAvEJSqlmwhmW6fTnTfGbU/eVcLjIwDWraBegmPs/vXkmbiLBNY ZDzEsIRo6sS6HHB0gVz0q9I8xdFBDFmNM+ySwHn1QQMjVLXfb4Iv18M4wDc45w8EG15L HXwp5GcqnEc4Z64Cl+gvd9BdtMVBA59LTRq7zuf4RwCs85Nt+4PtbWlOMHLXy1h6cP7v ZUbA== X-Gm-Message-State: APjAAAWBdKuND+r/VqqeTrigDXM2WQvuMkZSot5U2LoF1zVK+W9Dhc7I uqQ/Zwc18KCMPrIz0nGc0MBo/ea9mtk= X-Google-Smtp-Source: APXvYqwtI0/zVunq/pSmVDxSCRBW5aK+JP1iUbpjsluC8AzIc5NsNcYQGenpKUugOxpGKQism88Vlg== X-Received: by 2002:a65:6649:: with SMTP id z9mr5907536pgv.392.1555537306100; Wed, 17 Apr 2019 14:41:46 -0700 (PDT) Received: from xps15 (S0106002369de4dac.cg.shawcable.net. [68.147.8.254]) by smtp.gmail.com with ESMTPSA id 6sm174760pfp.143.2019.04.17.14.41.44 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 17 Apr 2019 14:41:45 -0700 (PDT) Date: Wed, 17 Apr 2019 15:41:43 -0600 From: Mathieu Poirier To: Suzuki K Poulose Subject: Re: [PATCH v2 10/36] coresight: tpiu: Clean up device specific data Message-ID: <20190417214143.GE14163@xps15> References: <1555344260-12375-1-git-send-email-suzuki.poulose@arm.com> <1555344260-12375-11-git-send-email-suzuki.poulose@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1555344260-12375-11-git-send-email-suzuki.poulose@arm.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190417_144147_379974_668C5064 X-CRM114-Status: GOOD ( 16.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: coresight@lists.linaro.org, rjw@rjwysocki.net, linux-kernel@vger.kernel.org, robert.walker@arm.com, linux-arm-kernel@lists.infradead.org, mike.leach@linaro.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Apr 15, 2019 at 05:03:53PM +0100, Suzuki K Poulose wrote: > Switch to using the coresight device instead of the parent > amba device. > > Cc: Mathieu Poirier > Signed-off-by: Suzuki K Poulose > --- > drivers/hwtracing/coresight/coresight-tpiu.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/hwtracing/coresight/coresight-tpiu.c b/drivers/hwtracing/coresight/coresight-tpiu.c > index 4977467..96af7d5 100644 > --- a/drivers/hwtracing/coresight/coresight-tpiu.c > +++ b/drivers/hwtracing/coresight/coresight-tpiu.c > @@ -54,7 +54,6 @@ > */ > struct tpiu_drvdata { > void __iomem *base; > - struct device *dev; Please cleanup structure documentation. With that: Reviewed-by: Mathieu Poirier > struct clk *atclk; > struct coresight_device *csdev; > }; > @@ -74,7 +73,7 @@ static int tpiu_enable(struct coresight_device *csdev, u32 mode, void *__unused) > > tpiu_enable_hw(drvdata); > > - dev_dbg(drvdata->dev, "TPIU enabled\n"); > + dev_dbg(&csdev->dev, "TPIU enabled\n"); > return 0; > } > > @@ -100,7 +99,7 @@ static void tpiu_disable(struct coresight_device *csdev) > > tpiu_disable_hw(drvdata); > > - dev_dbg(drvdata->dev, "TPIU disabled\n"); > + dev_dbg(&csdev->dev, "TPIU disabled\n"); > } > > static const struct coresight_ops_sink tpiu_sink_ops = { > @@ -134,7 +133,6 @@ static int tpiu_probe(struct amba_device *adev, const struct amba_id *id) > if (!drvdata) > return -ENOMEM; > > - drvdata->dev = &adev->dev; > drvdata->atclk = devm_clk_get(&adev->dev, "atclk"); /* optional */ > if (!IS_ERR(drvdata->atclk)) { > ret = clk_prepare_enable(drvdata->atclk); > -- > 2.7.4 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel