From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,URIBL_RHS_DOB,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80245C10F0E for ; Thu, 18 Apr 2019 12:45:57 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 519082183E for ; Thu, 18 Apr 2019 12:45:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="E2qg9wCS"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="OGq2T9Oy" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 519082183E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=qGXtk6oxfshu9CqupCWNPfrTmXbDsvuoVPnhWsAcv5o=; b=E2qg9wCSKUqp1oNKA51I3c/26 Zua8RnJ62yTqFmEnXrNsBK5qWdc1iW/zgq3AukR3NzWNikBbRH9lGZcodsig2WbcJil6Uc3FjI8DT JblJxl5Js7lvF+ImqvXAPSoiGDKtK66QC5DneBAPJM4dMn6Ab/EgiWLmGScnvfDPi4alLxVZO+pft IeubnJjS5SG2VZPkyGuxF2AnuVLUNZAY06reKJ8JuZWrBC//b19DbxTTu1xXIqG9UxPASk6to81vn 6jpQrPqeBOa9/DdsP7ER2gjs9yzY6sSnZqP0M+lLOtl1EB19Qh8i8j2nu0w+LBiI1DtGOhFOGgNg2 /2y5mgooA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hH6QI-0003UF-7y; Thu, 18 Apr 2019 12:45:50 +0000 Received: from merlin.infradead.org ([2001:8b0:10b:1231::1]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hH6QF-0003TL-IB for linux-arm-kernel@bombadil.infradead.org; Thu, 18 Apr 2019 12:45:47 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=X3mxIhJwMWhUS04CEhXvfQfQ3v5ODLuO4GSoUPIBlyo=; b=OGq2T9Oyn4pDh1UTGk4trSPNV vrqm/HHJuW2P7FXJUZkmFGyzbXW6nEytr7DwVIjMUnUlnNWHFP6ftaAck0adtw3WzYVwPx4qh+eVW 63eM2HmtpXcAiRynox6bhks4jSDbrjZK8dlkGtN89TYnaYwxpk4Wje/bVx7y87PB5wf0wZmIwfgH7 wLKavgxdCdwPG/0ZJiw1O0O23sMwewkGqyy149OhW53LD3UmbRenmf09NXh/f31lLGz51cqmaHcfG RhUkAEKbwk3b2rTuKkC5K5VsyuZ2IJ7M+utlAfEGYjQXO15O3cFEDoHWUd99esbqqv1LSKf5KPV4J uDOTdqWSg==; Received: from relay10.mail.gandi.net ([217.70.178.230]) by merlin.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hH6QC-0002BE-04 for linux-arm-kernel@lists.infradead.org; Thu, 18 Apr 2019 12:45:45 +0000 Received: from localhost (aaubervilliers-681-1-42-238.w90-88.abo.wanadoo.fr [90.88.160.238]) (Authenticated sender: maxime.ripard@bootlin.com) by relay10.mail.gandi.net (Postfix) with ESMTPSA id CB1A6240004; Thu, 18 Apr 2019 12:45:12 +0000 (UTC) Date: Thu, 18 Apr 2019 14:45:12 +0200 From: Maxime Ripard To: Pablo =?utf-8?Q?Sebasti=C3=A1n?= Greco Subject: Re: [linux-sunxi] Re: [PATCH v3 1/7] ARM: dts: sun8i: r40: bananapi-m2-ultra: Tie GMAC regulators to the PIO Message-ID: <20190418124512.theixlxnsghidpjp@flea> References: <1555492863-88860-1-git-send-email-pgreco@centosproject.org> <1555492863-88860-2-git-send-email-pgreco@centosproject.org> <20190417101757.traviffiulwnzr6x@flea> <666caeac-4297-17b0-065e-00b7fd9623b4@centosproject.org> MIME-Version: 1.0 In-Reply-To: <666caeac-4297-17b0-065e-00b7fd9623b4@centosproject.org> User-Agent: NeoMutt/20180716 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190418_084544_271963_99327917 X-CRM114-Status: GOOD ( 23.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Chen-Yu Tsai , linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com, Rob Herring , linux-arm-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============1961203837405502292==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============1961203837405502292== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="zqgbvc2dvbkaqti4" Content-Disposition: inline --zqgbvc2dvbkaqti4 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Thu, Apr 18, 2019 at 09:25:19AM -0300, Pablo Sebasti=E1n Greco wrote: > El 17/4/19 a las 07:17, Maxime Ripard escribi=F3: > > On Wed, Apr 17, 2019 at 06:20:56AM -0300, Pablo Greco wrote: > > > When the GMAC support was added to the bananapi-m2-ultra, regulators > > > weren't tied to the pinctrl. Fix that. > > > > > > Signed-off-by: Pablo Greco > > > --- > > > arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff --git a/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts b/arch= /arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts > > > index c488aaa..3da3598 100644 > > > --- a/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts > > > +++ b/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts > > > @@ -201,6 +201,8 @@ > > > &pio { > > > pinctrl-names =3D "default"; > > > pinctrl-0 =3D <&clk_out_a_pin>; > > > + vcc-pa-supply =3D <®_aldo2>; > > You should list all the regulators that are needed for all the pin > > banks to operate properly, not just PA > Ok, I "think" I finally understand what you mean, so according to schemat= ics > in https://drive.google.com/file/d/0B4PAo2nW2KfndFpmZG1OOWJ5NEU/view, it > should look like this > diff --git a/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts > b/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts > index c488aaa..699579d 100644 > --- a/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts > +++ b/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts > @@ -201,6 +201,12 @@ > =A0&pio { > =A0=A0=A0=A0 pinctrl-names =3D "default"; > =A0=A0=A0=A0 pinctrl-0 =3D <&clk_out_a_pin>; > +=A0=A0=A0 vcc-pa-supply =3D <®_aldo2>; > +=A0=A0=A0 vcc-pc-supply =3D <®_dcdc1>; > +=A0=A0=A0 vcc-pd-supply =3D <®_dcdc1>; > +=A0=A0=A0 vcc-pe-supply =3D <®_eldo1>; > +=A0=A0=A0 vcc-pf-supply =3D <®_dcdc1>; > +=A0=A0=A0 vcc-pg-supply =3D <®_dldo1>; > =A0}; That makes sense yep > =A0®_aldo2 { > -- > > I couldn't find vcc-pb, vcc-ph or vcc-pi. The R40 doesn't have them, so there's no suprise there :) (if you ever want to find that info again in the future, the various vcc-p* that you need to find are in the datasheet) > If this is ok, I'll generate a v4 based on v2, and throw v3 in the trash > where it belongs Sounds good, thanks! Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --zqgbvc2dvbkaqti4 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXLhxWAAKCRDj7w1vZxhR xYjxAP96S50pe+i0RxcXurVb6Gq6P3wILPZgfw2YZfFlBOqBVQD/Y3JUzQSgyTUg sFcR27YRufsmqYO5Euh1nl5UpP4MDAE= =6Yuo -----END PGP SIGNATURE----- --zqgbvc2dvbkaqti4-- --===============1961203837405502292== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============1961203837405502292==--