From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,URIBL_RHS_DOB,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD649C10F0E for ; Thu, 18 Apr 2019 14:56:59 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9C6E42183E for ; Thu, 18 Apr 2019 14:56:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="qLu56HLZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9C6E42183E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=UhFYwu1vtOa8iCEBHNLPuyBXs6/137nXUmCiuD5QUGk=; b=qLu56HLZce2nvM7G6MHQnOYLD USkHH4UsET3U0moPPHRwNVEWwlJlgW1ADkDNECQdRKdkzoQH3lIsK97qKRAVwdJxa0V/LdAwP+OUN r3XYxXTvGatDdj4DbnHnwY36AJP5m9eeCuuPfME2/OQqnTjTadoG4SBLJzd2gjM9ykzpUqi6Sdn4W ApCcFkZOO3eHdh+RxArgNZY7wQh7h4iFlQwX/G80woE1tQQ4I7YMZiHixEVmCzdHZeI+GrY+QPUiz KTYR32gzilS+kCoBjkgcRc8ii3+UVr0uAFAm4Vx5zOc5d5gsQH1T962NUK464ailQ1WztcmEEbiy9 6E+KoBXfw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hH8T8-0001DP-UE; Thu, 18 Apr 2019 14:56:54 +0000 Received: from relay2-d.mail.gandi.net ([217.70.183.194]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hH8T5-0001CG-K9 for linux-arm-kernel@lists.infradead.org; Thu, 18 Apr 2019 14:56:53 +0000 X-Originating-IP: 90.88.160.238 Received: from localhost (aaubervilliers-681-1-42-238.w90-88.abo.wanadoo.fr [90.88.160.238]) (Authenticated sender: maxime.ripard@bootlin.com) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id BC80C4000C; Thu, 18 Apr 2019 14:56:41 +0000 (UTC) Date: Thu, 18 Apr 2019 16:56:41 +0200 From: Maxime Ripard To: Jagan Teki Subject: Re: [PATCH] arm64: dts: allwinner: a64-oceanic-5205-5inmfd: Enable CAN Message-ID: <20190418145641.q23tupopz2czjzc5@flea> References: <20190418141658.10868-1-jagan@amarulasolutions.com> MIME-Version: 1.0 In-Reply-To: <20190418141658.10868-1-jagan@amarulasolutions.com> User-Agent: NeoMutt/20180716 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190418_075651_807761_0D1FDD70 X-CRM114-Status: GOOD ( 14.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, linux-sunxi@googlegroups.com, linux-kernel@vger.kernel.org, Chen-Yu Tsai , Rob Herring , Michael Trimarchi , linux-amarula@amarulasolutions.com, linux-arm-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============2749960635462670840==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============2749960635462670840== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ubqlaoup2nr4gj7m" Content-Disposition: inline --ubqlaoup2nr4gj7m Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Apr 18, 2019 at 07:46:58PM +0530, Jagan Teki wrote: > Oceanic 5205 5inMFD has MCP2515 CAN device connected via SPI1. > > - via SPI1 bus > - vdd supplied by 5V supply along with PL2 enable pin > - xceiver supply same as vdd > - can oscillator connected at 20MHz > - PB2 gpio as interrupt pin > - PD6 gpio as RX_BUF1_CAN0 > - PD7 gpio as RX_BUF0_CAN0 > > Tested-by: Tamas Papp > Signed-off-by: Jagan Teki > --- > .../sun50i-a64-oceanic-5205-5inmfd.dts | 43 +++++++++++++++++++ > 1 file changed, 43 insertions(+) > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-oceanic-5205-5inmfd.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-oceanic-5205-5inmfd.dts > index f0cd6587f619..22535a297f51 100644 > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-oceanic-5205-5inmfd.dts > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-oceanic-5205-5inmfd.dts > @@ -21,6 +21,24 @@ > chosen { > stdout-path = "serial0:115200n8"; > }; > + > + can_osc: can-osc { > + compatible = "fixed-clock"; > + #clock-cells = <0>; > + clock-frequency = <20000000>; > + }; > + > + reg_can_v5v: reg-can-v5v { > + compatible = "regulator-fixed"; > + regulator-name = "reg-can-v5v"; > + regulator-min-microvolt = <5000000>; > + regulator-max-microvolt = <5000000>; > + regulator-boot-on; > + enable-active-high; > + gpio = <&r_pio 0 2 GPIO_ACTIVE_HIGH>; /* CAN_3V3_EN: PL2 */ > + status = "okay"; You don't need the status property here. > + }; > + > }; > > &ehci0 { > @@ -77,6 +95,31 @@ > status = "okay"; > }; > > +&pio { > + can_pins: can-pins { > + pins = "PD6", /* RX_BUF1_CAN0 */ > + "PD7"; /* RX_BUF0_CAN0 */ > + function = "gpio_in"; > + }; > +}; That isn't needed. What are they used for, you're not tying them to anything? Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --ubqlaoup2nr4gj7m Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXLiQKQAKCRDj7w1vZxhR xRf+AP9HjPtUm9E6M4+r2qWke+5hMF4d+A4bbuD9FzCcaMEJnAD/arISN0KgRAnn 8+tjI3HkIRFz/RZaKY8qQg1257S15QE= =YwZr -----END PGP SIGNATURE----- --ubqlaoup2nr4gj7m-- --===============2749960635462670840== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============2749960635462670840==--