From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6818AC10F0E for ; Thu, 18 Apr 2019 16:35:38 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3AEC020821 for ; Thu, 18 Apr 2019 16:35:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="OsG8cHig" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3AEC020821 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=znnzy0yn0v9FdHpesG3INC8t+kQLHPupKb+OltHX6pY=; b=OsG8cHigt5ceNs S24DBZjgCiaRLc9V0gacdfA0WsRQsSGyYexwk4R2U15gg4J+cKZqrx4xIkFjhYmspNOysPQub3Hjx GWu+/e/B5Kyp/OH28MJrBxjY4UjniTbe7a+bVYpTSIpU+DNkz0AbuX5Zcbc9kHay1OilbtmQat3Uh UsURwNvUFz3JnQ3mzj3i1G2DbFFQ5KRpLSDcAkLiZZNtKXVSFyqOxV2kt/0uZSUUqLmK4a8VfBsEB F8wPC9aRHfZDHWBjPO4ocnkbn6L+8T8AwwTTq6IrKdk2pSKGT1nj0cr6ybZaXKnAFcnsasj5OJfFJ 3a+hZO8TbYMZmPs1Sg7w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hHA0b-0007gY-MU; Thu, 18 Apr 2019 16:35:33 +0000 Received: from verein.lst.de ([213.95.11.211] helo=newverein.lst.de) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hHA0X-0007fp-UL for linux-arm-kernel@lists.infradead.org; Thu, 18 Apr 2019 16:35:31 +0000 Received: by newverein.lst.de (Postfix, from userid 2407) id E434368AFE; Thu, 18 Apr 2019 18:35:12 +0200 (CEST) Date: Thu, 18 Apr 2019 18:35:12 +0200 From: Christoph Hellwig To: Robin Murphy Subject: Re: [PATCH 12/21] dma-iommu: factor atomic pool allocations into helpers Message-ID: <20190418163512.GA25347@lst.de> References: <20190327080448.5500-1-hch@lst.de> <20190327080448.5500-13-hch@lst.de> <20190410061157.GA5278@lst.de> <20190417063358.GA24139@lst.de> <83615173-a8b4-e0eb-bac3-1a58d61ea4ef@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <83615173-a8b4-e0eb-bac3-1a58d61ea4ef@arm.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190418_093530_128728_21F1A37D X-CRM114-Status: GOOD ( 11.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tom Lendacky , Catalin Marinas , Joerg Roedel , Will Deacon , linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, Christoph Hellwig , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Apr 18, 2019 at 04:06:56PM +0100, Robin Murphy wrote: > OK, I'm still looking at mmap and get_sgtable, but for now I've pushed out > a partial branch that consolidates alloc and free in a way which makes > sense to me: > > git://linux-arm.org/linux-rm dma/rework > > Please let me know what you think. >From a very high level POV this looks ok, but sometimes a bit to convoluted to me. The major issue why I went with the version I posted is that I can cleanly ifdef out the remap code in just a few sections. In this version it is spread out a lot more, and the use of IS_ENABLED means that we'd need a lot more stubs for functionality that won't ever be called but needs to be compilable. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel