From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC569C10F0E for ; Thu, 18 Apr 2019 16:50:49 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9CE6B21479 for ; Thu, 18 Apr 2019 16:50:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="MtHWmFGP"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="BcxbJRv6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9CE6B21479 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7nA7yeDgFRpJHH6QjlJ1MXLHRfDaJQ8bZhOIkr7YONw=; b=MtHWmFGPde+3S/ m+5NXeGOheW4UIqMyyrLM87WWQjNmqIIUt1erFYSa+8ceXj4Bt8r/QynZy4z0YvO72aPsbGN2r2jS D5zuWu9mAiJHA9yR1MByYBtDv70QrSQq4dHFN9S1WfG1Oi55SRoFM+cutMNlMWtZTkSafqv4llV03 zEve580GhBCzL3jPRJTU8cz/IrNB3QcCrSxoITFZM8jxWA9966tyKfhAFbRHUG8kQvnS+Bqdb9XDX q5N/x8oFwz2sRCDJCdcq2f0rqp0okMkVZtxEgTLfyg8FvIAWbYXXD1f0GH4oLgNPcAsuKyczn+PVQ ysBFffSCQf8Lu9N0mVgw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hHAFG-0005KQ-2p; Thu, 18 Apr 2019 16:50:42 +0000 Received: from mail-pg1-x543.google.com ([2607:f8b0:4864:20::543]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hHAF9-0005Gt-IA for linux-arm-kernel@lists.infradead.org; Thu, 18 Apr 2019 16:50:40 +0000 Received: by mail-pg1-x543.google.com with SMTP id e6so1464369pgc.4 for ; Thu, 18 Apr 2019 09:50:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ckm25HFpHOCsBiC4iTMsYZI+aUwZkDKtbZRGsrwYOGY=; b=BcxbJRv6bqPOZjAjmxBZ08bJwvlqhWPaZXkRxdoPHKMscTjaEFiudDSzehDwWy5J/X n7Ol4ETdWQhIdbbtF2BiBKGuwKVbkKU2vsfsR/sNiXhD3B6DkmJVq3UwpUIayRWkSuKQ Bh8IbFTaATjjCH7HDmUNvOSXkiWr5YA8B/obt95zdf3T/yVfuVSbQMEuBvc0LXFGQvYu MiUs7tFGCmbh3tLlx+LN/VBnN7iAqiC0LLbjHBdzY5JWbPciLwsveVx6xs5OWl88mp9J yGb5ZFRAKteWmS82/yQv7VGKN/1PArallj44TmFoNYI1zqwMDhBLoSSuPRU4zyHFHdZX eZ+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ckm25HFpHOCsBiC4iTMsYZI+aUwZkDKtbZRGsrwYOGY=; b=EafqVbmjftYCDLzdZCB4CkwPiuwTMtvqRpJBPyWUUPZjioBxCD/nKi6Eyu5AYrMD+b efAkznkdkjfPL65QP63vCs0mLWggjXwALnnO1u/pOzcyFsSFnwTRgeRWb2qbzF+R5CtP 0I9ItDdr/K3axXmQFfXYBwLditHYXjJnAGhHcbqJQQP+9/T5G7fEjYDcgSh3jVAOcBpc DS6yVeuIEJrcNBvMlWGLVPwYTKAHQXrWLlhxQ3GswDuBsLkdNtKM/ybP+6XSdmoJUkd8 NQYMoHIpMMlgfgBFvFBPeXKgj8AbtTit+u7WvUUBb/sw42eJqxe9v67oNRHAWOPIHn4h YFzQ== X-Gm-Message-State: APjAAAXn1Y+H71esDNNBPH9s37tnTMhM4XuAoSQ3l3kRUnhpjOTF6nzc N4tT+uTfhyike/jVFOzomNORXg== X-Google-Smtp-Source: APXvYqxzYiVKlNqGtj3DgSJB6XN2U81bkT7crEERUhx5M8IDR3cEeY1W1oEOgF0j2cQTBx3mR0k6wQ== X-Received: by 2002:a63:84c7:: with SMTP id k190mr88126788pgd.255.1555606234093; Thu, 18 Apr 2019 09:50:34 -0700 (PDT) Received: from xps15 (S0106002369de4dac.cg.shawcable.net. [68.147.8.254]) by smtp.gmail.com with ESMTPSA id a9sm3554035pfo.17.2019.04.18.09.50.32 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 18 Apr 2019 09:50:32 -0700 (PDT) Date: Thu, 18 Apr 2019 10:50:30 -0600 From: Mathieu Poirier To: Suzuki K Poulose Subject: Re: [PATCH v2 11/36] coresight: stm: Cleanup device specific data Message-ID: <20190418165030.GA10675@xps15> References: <1555344260-12375-1-git-send-email-suzuki.poulose@arm.com> <1555344260-12375-12-git-send-email-suzuki.poulose@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1555344260-12375-12-git-send-email-suzuki.poulose@arm.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190418_095035_611652_BAEC115B X-CRM114-Status: GOOD ( 21.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: coresight@lists.linaro.org, rjw@rjwysocki.net, linux-kernel@vger.kernel.org, robert.walker@arm.com, linux-arm-kernel@lists.infradead.org, mike.leach@linaro.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Apr 15, 2019 at 05:03:54PM +0100, Suzuki K Poulose wrote: > Keep track of the STM coresight device which is a child device > of the AMBA device. Since we can get to the coresight_device > from the "device" instance, remove the explicit field. > > Cc: Mathieu Poirier > Signed-off-by: Suzuki K Poulose > --- > drivers/hwtracing/coresight/coresight-stm.c | 21 ++++++++++----------- > 1 file changed, 10 insertions(+), 11 deletions(-) > > diff --git a/drivers/hwtracing/coresight/coresight-stm.c b/drivers/hwtracing/coresight/coresight-stm.c > index 9f8a844..8f50484 100644 > --- a/drivers/hwtracing/coresight/coresight-stm.c > +++ b/drivers/hwtracing/coresight/coresight-stm.c > @@ -110,7 +110,6 @@ struct channel_space { > /** > * struct stm_drvdata - specifics associated to an STM component > * @base: memory mapped base address for this component. > - * @dev: the device entity associated to this component. > * @atclk: optional clock for the core parts of the STM. > * @csdev: component vitals needed by the framework. > * @spinlock: only one at a time pls. > @@ -128,7 +127,6 @@ struct channel_space { > */ > struct stm_drvdata { > void __iomem *base; > - struct device *dev; > struct clk *atclk; > struct coresight_device *csdev; > spinlock_t spinlock; > @@ -205,13 +203,13 @@ static int stm_enable(struct coresight_device *csdev, > if (val) > return -EBUSY; > > - pm_runtime_get_sync(drvdata->dev); > + pm_runtime_get_sync(csdev->dev.parent); > > spin_lock(&drvdata->spinlock); > stm_enable_hw(drvdata); > spin_unlock(&drvdata->spinlock); > > - dev_dbg(drvdata->dev, "STM tracing enabled\n"); > + dev_dbg(&csdev->dev, "STM tracing enabled\n"); > return 0; > } > > @@ -271,10 +269,10 @@ static void stm_disable(struct coresight_device *csdev, > /* Wait until the engine has completely stopped */ > coresight_timeout(drvdata->base, STMTCSR, STMTCSR_BUSY_BIT, 0); > > - pm_runtime_put(drvdata->dev); > + pm_runtime_put(csdev->dev.parent); > > local_set(&drvdata->mode, CS_MODE_DISABLED); > - dev_dbg(drvdata->dev, "STM tracing disabled\n"); > + dev_dbg(&csdev->dev, "STM tracing disabled\n"); > } > } > > @@ -763,9 +761,10 @@ static void stm_init_default_data(struct stm_drvdata *drvdata) > bitmap_clear(drvdata->chs.guaranteed, 0, drvdata->numsp); > } > > -static void stm_init_generic_data(struct stm_drvdata *drvdata) > +static void stm_init_generic_data(struct stm_drvdata *drvdata, > + const char *name) > { > - drvdata->stm.name = dev_name(drvdata->dev); > + drvdata->stm.name = name; > > /* > * MasterIDs are assigned at HW design phase. As such the core is > @@ -807,7 +806,6 @@ static int stm_probe(struct amba_device *adev, const struct amba_id *id) > if (!drvdata) > return -ENOMEM; > > - drvdata->dev = &adev->dev; > drvdata->atclk = devm_clk_get(&adev->dev, "atclk"); /* optional */ > if (!IS_ERR(drvdata->atclk)) { > ret = clk_prepare_enable(drvdata->atclk); > @@ -848,7 +846,7 @@ static int stm_probe(struct amba_device *adev, const struct amba_id *id) > spin_lock_init(&drvdata->spinlock); > > stm_init_default_data(drvdata); > - stm_init_generic_data(drvdata); > + stm_init_generic_data(drvdata, dev_name(dev)); > > if (stm_register_device(dev, &drvdata->stm, THIS_MODULE)) { > dev_info(dev, > @@ -870,7 +868,8 @@ static int stm_probe(struct amba_device *adev, const struct amba_id *id) > > pm_runtime_put(&adev->dev); > > - dev_info(dev, "%s initialized\n", (char *)coresight_get_uci_data(id)); > + dev_info(&drvdata->csdev->dev, "%s initialized\n", > + (char *)coresight_get_uci_data(id)); > return 0; > > stm_unregister: Reviewed-by: Mathieu Poirier > -- > 2.7.4 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel