From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4A74C10F14 for ; Fri, 19 Apr 2019 00:25:15 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6C5C3205ED for ; Fri, 19 Apr 2019 00:25:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="cKFt36du"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="hxRW4+KX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6C5C3205ED Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=nlwiS1XUnzSIqZDm1fBwVa4CGqfdvLdlCNnnI2JgBjY=; b=cKFt36duqZ8tpe k9iVk9zLNJbND+V8fHGCd/jYyBN079Gc73sXISKkJppyv4gu27f4c8KsNZ2MBq34eHjZXr5n1puvL cfdi8ICwerN9sItLVqOKZDlxQx/YIGJFsB4+2teb1FIK9wQBAKfplp/bjJ/MCv+p937mE/FgvXN72 W4zCKSOmDU//gUjb/i2nPM6rYFVG4S0agPhsaUpLxMEeZRXnZ7S0a/I1Pew/Podl+zf9VDwVF/z9d F49AMc+mXQk8ETcaHHnng7GaM/40pue+rwQ+Xhx/auuVbPKXc9JeAay7BdHU73i1JVF1/9obi7zHl FKwKHHuWjaaHpnTZltEg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hHHL0-0002Fy-5X; Fri, 19 Apr 2019 00:25:06 +0000 Received: from mail-pg1-x541.google.com ([2607:f8b0:4864:20::541]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hHHKw-0001kA-Ll for linux-arm-kernel@lists.infradead.org; Fri, 19 Apr 2019 00:25:04 +0000 Received: by mail-pg1-x541.google.com with SMTP id y3so1903189pgk.12 for ; Thu, 18 Apr 2019 17:25:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=aBpZyaS+ZmDCtg5dDjJTAz16MJIF3r/OZvt6uyCX5no=; b=hxRW4+KXFLn/f3c5kN3LpTmaastUMsuL8zLEvsIiRwd2vDGrrZIaAkVkjXRVAhK+vR FjQUelPoyHwoMpGKx12GOz3Yb8uUHf2p8zDlteqKzwzGE1JR56m6NXbzVwFHI3h4cK2Q SAAebPG0TElmFxsYTBobrbnan/XCdb0/XE95wSsRzjiutTpRCpfrq2y34zURyiys4q/Q YUjHoye9wBjNN5QzUexD9bZK/55tSeFX0Sn1Di/bEE1YIpfBRUghA8i9XnS870h6y2Ud aOQeGf4ATN3AP9athzkogumnkpaOz9nk3VfZxXemu8GH3VOWK15kvUqdt+WhzOyK6un/ Xs0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=aBpZyaS+ZmDCtg5dDjJTAz16MJIF3r/OZvt6uyCX5no=; b=g4hzotxnwvlBNvntty1rx48/uVofllHohIcec/qOgehPh90r1VX5+W4+in6tZlWuHN HWipfuq7pKBRs9VfMpUuX0xaN/nXzXU4VPNR1o0bwm/sEgTAnaR1gyTsR1wtRIzeWPFA 2pyCDq4R3V/WzMCmAuV1CKv+fsd9Ic//CsTV15PmTgMLTQ37hGb5bv0N03mQnID7zmho V5TbhyOaCWzJt6olpmuDBWVmFwhdFlm0hUGHTzfdV5oQBHczuQTv5K0ft8y+RO+/iV7V 0irgdA/nH12xR5c+di1X4owFB8eid2GpCoGM+0UqEqZydt2Esn7/Zae0FHpn9yOBf8JH Oosg== X-Gm-Message-State: APjAAAU2LXqcaORNYFPaASkkGqS0lakeN1yZRwBdNpdkM2iJfLcyXsY6 gAUeld7cz24Hb/HPTcp4s9yBdg== X-Google-Smtp-Source: APXvYqxHtM1ZtkLyXCCakQ1g/LH3mkpXMOlDZpFODTjlKy94Bqy7XYBlwE6UXVcSYMn1qNpIg1TEfA== X-Received: by 2002:a63:c34c:: with SMTP id e12mr878940pgd.279.1555633500911; Thu, 18 Apr 2019 17:25:00 -0700 (PDT) Received: from builder (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id n65sm11068363pfb.160.2019.04.18.17.24.59 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 18 Apr 2019 17:24:59 -0700 (PDT) Date: Thu, 18 Apr 2019 17:24:57 -0700 From: Bjorn Andersson To: Vivek Gautam Subject: Re: [PATCH 1/1] iommu/arm-smmu: Log CBFRSYNRA register on context fault Message-ID: <20190419002457.GA3137@builder> References: <4cfc7b3b-bc74-6b37-19f5-40b6394fa762@codeaurora.org> <20190415173758.22112-1-vivek.gautam@codeaurora.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190415173758.22112-1-vivek.gautam@codeaurora.org> User-Agent: Mutt/1.10.0 (2018-05-17) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190418_172502_756264_FF6E995C X-CRM114-Status: GOOD ( 17.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-msm@vger.kernel.org, joro@8bytes.org, will.deacon@arm.com, linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, robin.murphy@arm.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon 15 Apr 10:37 PDT 2019, Vivek Gautam wrote: > Bits[15:0] in CBFRSYNRA register contain information about > StreamID of the incoming transaction that generated the > fault. Dump CBFRSYNRA register to get this info. > This is specially useful in a distributed SMMU architecture > where multiple masters are connected to the SMMU. > SID information helps to quickly identify the faulting > master device. > > Signed-off-by: Vivek Gautam > --- > > V1 of the patch available @ > https://lore.kernel.org/patchwork/patch/1061615/ > > Changes from v1: > - Dump the raw register value of CBFRSYNRA register in the > context fault log rather than extracting the SID inforamtion > and dumping that. > > drivers/iommu/arm-smmu-regs.h | 2 ++ > drivers/iommu/arm-smmu.c | 8 ++++++-- > 2 files changed, 8 insertions(+), 2 deletions(-) > > diff --git a/drivers/iommu/arm-smmu-regs.h b/drivers/iommu/arm-smmu-regs.h > index a1226e4ab5f8..e9132a926761 100644 > --- a/drivers/iommu/arm-smmu-regs.h > +++ b/drivers/iommu/arm-smmu-regs.h > @@ -147,6 +147,8 @@ enum arm_smmu_s2cr_privcfg { > #define CBAR_IRPTNDX_SHIFT 24 > #define CBAR_IRPTNDX_MASK 0xff > > +#define ARM_SMMU_GR1_CBFRSYNRA(n) (0x400 + ((n) << 2)) > + > #define ARM_SMMU_GR1_CBA2R(n) (0x800 + ((n) << 2)) > #define CBA2R_RW64_32BIT (0 << 0) > #define CBA2R_RW64_64BIT (1 << 0) > diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c > index 045d93884164..a4773e8c6b0e 100644 > --- a/drivers/iommu/arm-smmu.c > +++ b/drivers/iommu/arm-smmu.c > @@ -575,7 +575,9 @@ static irqreturn_t arm_smmu_context_fault(int irq, void *dev) > struct arm_smmu_domain *smmu_domain = to_smmu_domain(domain); > struct arm_smmu_cfg *cfg = &smmu_domain->cfg; > struct arm_smmu_device *smmu = smmu_domain->smmu; > + void __iomem *gr1_base = ARM_SMMU_GR1(smmu); > void __iomem *cb_base; > + u32 cbfrsynra; > > cb_base = ARM_SMMU_CB(smmu, cfg->cbndx); > fsr = readl_relaxed(cb_base + ARM_SMMU_CB_FSR); > @@ -585,10 +587,12 @@ static irqreturn_t arm_smmu_context_fault(int irq, void *dev) > > fsynr = readl_relaxed(cb_base + ARM_SMMU_CB_FSYNR0); > iova = readq_relaxed(cb_base + ARM_SMMU_CB_FAR); > + cbfrsynra = readl_relaxed(gr1_base + > + ARM_SMMU_GR1_CBFRSYNRA(cfg->cbndx)); The 80 char limit is more like a guideline anyways...please don't wrap this. > > dev_err_ratelimited(smmu->dev, > - "Unhandled context fault: fsr=0x%x, iova=0x%08lx, fsynr=0x%x, cb=%d\n", > - fsr, iova, fsynr, cfg->cbndx); > + "Unhandled context fault: fsr=0x%x, iova=0x%08lx, fsynr=0x%x, cbfrsynra = 0x%x, cb=%d\n", Drop the spaces around '='. With those addressed, you have my Reviewed-by: Bjorn Andersson Regards, Bjorn > + fsr, iova, fsynr, cbfrsynra, cfg->cbndx); > > writel(fsr, cb_base + ARM_SMMU_CB_FSR); > return IRQ_HANDLED; > -- > QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member > of Code Aurora Forum, hosted by The Linux Foundation > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel