From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0C62C282E0 for ; Fri, 19 Apr 2019 21:23:32 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7983F217F9 for ; Fri, 19 Apr 2019 21:23:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="uPG5Pleh"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nMlbNLU8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7983F217F9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=53p4nzOEuQMsRhY5I4iBoKtnpwc4ZG1ZrCwD83XbiSg=; b=uPG 5Plehgqb2oReHucKTbNS7AROS7kosj8bgTwidcK3adygvP+ULK9irWDp9Inoi3wZ8UheE/h4Mt81g P2vlbGlVYD3IlGZ34SoCUbmzKEaci0WNEN0sLHgQGTfg2VGDQQJBfb/EXOypPBCzasdmhOy1I8Wi7 EAqaAaG0hResY6aL/ezWlv92lUFGaBSwb8ZQWQIJi2pAaFy4gGCjaxYVFV6mrgIAOxdGEPDcRimdP hgTwx04zIg73DlYP1UqBJ/MPSp2Tc5Q4DkIb8FIeoJVzglfvigLh79x/ZmTHXlIXNISqdjCVkrjF/ 8hx7Ihk6760/ELts9hJW50MT1F4SdRw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hHayp-00060V-Pr; Fri, 19 Apr 2019 21:23:31 +0000 Received: from mail-oi1-x241.google.com ([2607:f8b0:4864:20::241]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hHayk-0005zk-PY; Fri, 19 Apr 2019 21:23:29 +0000 Received: by mail-oi1-x241.google.com with SMTP id e5so4832165oii.0; Fri, 19 Apr 2019 14:23:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=zyKRDcUH7uLbLXC7F5+i2ZLE7UEgE3LLZr7KeS/yAcc=; b=nMlbNLU8/dtKuZ4O8eAeKpGastYsWbCi4GG/9ih+epUAQAxmbubLKuLfU54olIA6aI vCYc3BpmqQtaT98EFLcvM1JGucRvjI/yHy8RE6CJJJQMq/G1Zd8MBVKnm67G1JmTcnZ2 yfmz06ZMjBIltMI8SeP9y45Ts4CJfhuTyqgi2pDOq373ynueMlYezIZgYUbLMgT6K3XF /eNc6zhKIHT2NB6pZ1Z14aAe6bLGPCwI7twQfeAasNwY723dCmdtIEkgn48fcTFOqmP1 PgtzMGcrYxYDcDHnZwyffTJC1uA/1g0a3AydpoTIlN4ByFkJ2Z8Fc4fAKHchH1CbxIYg +3qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=zyKRDcUH7uLbLXC7F5+i2ZLE7UEgE3LLZr7KeS/yAcc=; b=B6lsz2oZWawbGJocI+lBPNCcxty/cQkkkkLvBtH/Q+J1dgYv+zGRPArLcK9T9fHDQq Fq3Aq8najQzgJa37SAgAW0x7oJAnoO/X+G6RPBWeb2INEnVWNq6+ArkMCl+Y/rtfFnSR 33R91vqaub2DBetJd8rcSHl1C8JlbS845Am5gEbvepJ9Ejaf0xbLO9+c4qgZmE7jth7J 84lrkWY+MnX//kIRU6jO4T4P5EZZ3gdj4A/Mq2il8vxUlhToDGWV4yJfgfs3lt7/IOVU hgAIvhfpyneB/AYMskiEvR6aZBKFcFgTa8K0+MOKc/ynlYWxLnmtCqW4Ts8WARhFC2it 3C+g== X-Gm-Message-State: APjAAAVAU0KeWpZDDUnBBhAUiNh2/ixQmj58PuiTi4uZFKzeF1aCHgmE xZuAyCUNdfeHaA4fg0eNu+4= X-Google-Smtp-Source: APXvYqwgcY7gSzTyTx0Q7SsHiu3LZ/nSkASn25fog7A3QF2y1uPfHp482cFUCosx5ihb9Dc8UjJS8w== X-Received: by 2002:aca:5d8b:: with SMTP id r133mr3196348oib.72.1555709005370; Fri, 19 Apr 2019 14:23:25 -0700 (PDT) Received: from madhuleo ([2605:6000:1023:606d:151b:11be:d797:d50]) by smtp.gmail.com with ESMTPSA id n3sm2459066oia.46.2019.04.19.14.23.24 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 19 Apr 2019 14:23:24 -0700 (PDT) From: Madhumitha Prabakaran To: eric@anholt.net, stefan.wahren@i2se.com, gregkh@linuxfoundation.org, f.fainelli@gmail.com, rjui@broadcom.com, sbranden@broadcom.com, bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH] Staging: vc04_services: Cleanup in ctrl_set_bitrate() Date: Fri, 19 Apr 2019 16:23:21 -0500 Message-Id: <20190419212321.7325-1-madhumithabiw@gmail.com> X-Mailer: git-send-email 2.17.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190419_142328_241494_9736AC83 X-CRM114-Status: UNSURE ( 9.54 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Madhumitha Prabakaran MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Remove unnecessary variable and replace return type. Issue suggested by Coccinelle. Signed-off-by: Madhumitha Prabakaran --- drivers/staging/vc04_services/bcm2835-camera/controls.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/staging/vc04_services/bcm2835-camera/controls.c b/drivers/staging/vc04_services/bcm2835-camera/controls.c index e39ab5fae724..f87fa7f61db3 100644 --- a/drivers/staging/vc04_services/bcm2835-camera/controls.c +++ b/drivers/staging/vc04_services/bcm2835-camera/controls.c @@ -607,18 +607,13 @@ static int ctrl_set_bitrate(struct bm2835_mmal_dev *dev, struct v4l2_ctrl *ctrl, const struct bm2835_mmal_v4l2_ctrl *mmal_ctrl) { - int ret; struct vchiq_mmal_port *encoder_out; dev->capture.encode_bitrate = ctrl->val; encoder_out = &dev->component[MMAL_COMPONENT_VIDEO_ENCODE]->output[0]; - ret = vchiq_mmal_port_parameter_set(dev->instance, encoder_out, - mmal_ctrl->mmal_id, - &ctrl->val, sizeof(ctrl->val)); - ret = 0; - return ret; + return 0; } static int ctrl_set_bitrate_mode(struct bm2835_mmal_dev *dev, -- 2.17.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel