From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3D09C282E1 for ; Sat, 20 Apr 2019 03:12:52 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 911D221479 for ; Sat, 20 Apr 2019 03:12:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="B44X4aRo"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="D0Az7iHb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 911D221479 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=N4stF94Bob4yCixnML8bUZ3l02FJ9b3tvyE3/z0QEmg=; b=B44X4aRogDMs3i ZBiQdUtuab5HrZag7IKmSzgsDVxaI4GYPGjaFY0HHpNxOUQreLwt/ZvylLC3vFXskF29LOIYWyZIZ bN1sRZ/41MAZz7Jv1Fla5b3RICw+ajGQTPnQqayxiEEs3P6/jK0Qhd47MEI4jYiSqx//thIBaT5Ea HeL45Nsq9wy7AKH2ML/1QcVF9/2adWAE0LRvH3hEasSBn4UANmIrLDCTGfZGYiSBFCT6wn2Az7mU/ 1+2w1VGXc0Cr1J1kUI4EFVb6DO1xm2WF7V5a5pAOshCVdPKrIDavtGyrEPTSp5each6joQZCllo1r jdZKxkVVN0rcmXB7PYKg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hHgQo-0004QZ-Fl; Sat, 20 Apr 2019 03:12:46 +0000 Received: from mail-ot1-x342.google.com ([2607:f8b0:4864:20::342]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hHgQl-0004Py-B8; Sat, 20 Apr 2019 03:12:44 +0000 Received: by mail-ot1-x342.google.com with SMTP id e5so5606123otk.12; Fri, 19 Apr 2019 20:12:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Nsby3r1McbkZMSmZ0BcydHpE4vwRehK0xlPN+cMJu4k=; b=D0Az7iHb04B8XyJHQUHkwI8CbDwXf7k+3c47Wb2P1VSXZhmTpG5b9+CiAPCDo+uNB1 fHA8Kj3BvEOSWyInsSGRbZvMHxUXhNGow2UsEhLHQJoXGs+fzD2VCJ0o+3dzxSplBVjA edS06G6brffhFZal+xH6LT7rSF7SQCBGDo6tYX8fYOsOjge75Uh2KG9ZKx2JdhmMP1Oo I9yagGNmTgZ986MFG1KHKFrtBDBndn+5NVVCjYiblA+twD6HapCkMTrGLzp+5yo8ZAg9 EXWTsS5A7eSPxT97h9Wi+UyXQonxvi6gLBVszjo+k9S6Mse62EDR1Hi85RZeTgTBvtw4 Lh7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Nsby3r1McbkZMSmZ0BcydHpE4vwRehK0xlPN+cMJu4k=; b=LcZsNb9oBO+x5fTCj8RY2jBOHW3dDNk4pY/XlJrejBZDfuIb9fo3Scl//1wjC+iyws +JllfoDxOUeRvaRHnPKg2iIUDYpC1/1ApEXfuTMnTICbyVdnFlkPgfY823rxohkDSpmQ 4wWZmjUF81I4V4ow/yswhI8cXJO+hwNwdHlCtaRCI3pBexdnrJyniTyA0EVvXO1tfUFj EMR1D9zPwv8Pu1h+9zSOrqKCyR3M29htUyC4/WjQiZl2kOXbWSKUthrs8leFCWM/is5E QK3LcFj3Le6/O/Fdq7azmPTWDBzvleoO2yTxeOy0s4l/6SlT9jJ6Ezt+n1kOSg3/j/V7 7QDA== X-Gm-Message-State: APjAAAVvEsKPoz5AOnwA1pQTix18f5HAAoW3xBWXXgOEbetiWO+vpFjZ 1Afvp+VtuixfCW5qkdh72bs= X-Google-Smtp-Source: APXvYqyE6z5iBDwilt6A035qktTnQNM/6pwZLyj0msq00MnYfx+yCrHS2FD/ZEvukHQUI/LrcnnybQ== X-Received: by 2002:a05:6830:1051:: with SMTP id b17mr3835750otp.341.1555729961626; Fri, 19 Apr 2019 20:12:41 -0700 (PDT) Received: from madhuleo ([2605:6000:1023:606d:151b:11be:d797:d50]) by smtp.gmail.com with ESMTPSA id 189sm2895721oii.58.2019.04.19.20.12.39 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 19 Apr 2019 20:12:40 -0700 (PDT) Date: Fri, 19 Apr 2019 22:12:38 -0500 From: Madhumitha Prabakaran To: Stefan Wahren Subject: Re: [PATCH] Staging: vc04_services: Cleanup in ctrl_set_bitrate() Message-ID: <20190420031236.GA23925@madhuleo> References: <20190419212321.7325-1-madhumithabiw@gmail.com> <2d48664a-eb36-4fcc-7bc5-b1b480dbce9a@i2se.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <2d48664a-eb36-4fcc-7bc5-b1b480dbce9a@i2se.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190419_201243_416014_6C0FA8E8 X-CRM114-Status: GOOD ( 14.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, f.fainelli@gmail.com, sbranden@broadcom.com, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, eric@anholt.net, bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, rjui@broadcom.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 04/19 :49, Stefan Wahren wrote: > Hi Madhumitha, > > Am 19.04.19 um 23:23 schrieb Madhumitha Prabakaran: > > Remove unnecessary variable and replace return type. > > > > Issue suggested by Coccinelle. > > > > Signed-off-by: Madhumitha Prabakaran > > --- > > drivers/staging/vc04_services/bcm2835-camera/controls.c | 7 +------ > > 1 file changed, 1 insertion(+), 6 deletions(-) > > > > diff --git a/drivers/staging/vc04_services/bcm2835-camera/controls.c b/drivers/staging/vc04_services/bcm2835-camera/controls.c > > index e39ab5fae724..f87fa7f61db3 100644 > > --- a/drivers/staging/vc04_services/bcm2835-camera/controls.c > > +++ b/drivers/staging/vc04_services/bcm2835-camera/controls.c > > @@ -607,18 +607,13 @@ static int ctrl_set_bitrate(struct bm2835_mmal_dev *dev, > > struct v4l2_ctrl *ctrl, > > const struct bm2835_mmal_v4l2_ctrl *mmal_ctrl) > > { > > - int ret; > > struct vchiq_mmal_port *encoder_out; > > > > dev->capture.encode_bitrate = ctrl->val; > > > > encoder_out = &dev->component[MMAL_COMPONENT_VIDEO_ENCODE]->output[0]; > > > > - ret = vchiq_mmal_port_parameter_set(dev->instance, encoder_out, > > - mmal_ctrl->mmal_id, > > - &ctrl->val, sizeof(ctrl->val)); > > - ret = 0; > > - return ret; > > + return 0; > > i don't understand why we can remove here the function call. I overlooked the function call. I will fix it. > > Stefan > > > } > > > > static int ctrl_set_bitrate_mode(struct bm2835_mmal_dev *dev, _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel