From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D655C282DD for ; Sat, 20 Apr 2019 10:17:34 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D8D3D2087B for ; Sat, 20 Apr 2019 10:17:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="EY+jP6Us" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D8D3D2087B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Gr066mDTLXBnzVgeT/+Gs0JBRR1cDGOj2AnEE09/HWc=; b=EY+jP6Us4J4f+n O1zz6GKmG1kDOXajIgL78y/cUcJCw2ZSGYKUthrvmNudHF3Mwpl9o/0VTXFQzJvMyYjDrpxTnD9BT K+gDpbiAWPN0ZpJ3blgeidn7+x2K0ZkMjZtclKYDHzUEJ8aUQv5COOzYilh2kfDdzAqtu33MVn50T gyu1XZrhFIWOsltHs/DQxfoHxXuxP3xy8Aq9iBaZvGejaa7DksSvl7RIDG2ua5r/5Lw8oyGIBSsMh 76a1T6F3CCTgGdfQ4B2HIruUYlGQTFjbXkaxyNKMqh4oyBf5A36ukxjwOgmjJAIJcqSoECSdzyymQ rIy7ZGfdO5Jqh+a8NwbA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hHn3o-0006Sd-FO; Sat, 20 Apr 2019 10:17:28 +0000 Received: from relay11.mail.gandi.net ([217.70.178.231]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hHn3l-0006SM-Hr for linux-arm-kernel@lists.infradead.org; Sat, 20 Apr 2019 10:17:27 +0000 Received: from bootlin.com (lfbn-tou-1-417-253.w86-206.abo.wanadoo.fr [86.206.242.253]) (Authenticated sender: maxime.chevallier@bootlin.com) by relay11.mail.gandi.net (Postfix) with ESMTPSA id ADD6A10000B; Sat, 20 Apr 2019 10:17:14 +0000 (UTC) Date: Sat, 20 Apr 2019 12:17:14 +0200 From: Maxime Chevallier To: David Miller Subject: Re: [PATCH net-next] net: mvpp2: cls: Add Classification offload support Message-ID: <20190420121714.387f160b@bootlin.com> In-Reply-To: <20190419.150950.1875022930637674395.davem@davemloft.net> References: <20190419133027.8012-1-maxime.chevallier@bootlin.com> <20190419.150950.1875022930637674395.davem@davemloft.net> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190420_031725_745413_1AA25C13 X-CRM114-Status: UNSURE ( 9.06 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: antoine.tenart@bootlin.com, netdev@vger.kernel.org, gregory.clement@bootlin.com, linux-kernel@vger.kernel.org, linux@armlinux.org.uk, nadavh@marvell.com, thomas.petazzoni@bootlin.com, miquel.raynal@bootlin.com, stefanc@marvell.com, mw@semihalf.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi David, On Fri, 19 Apr 2019 15:09:50 -0700 (PDT) David Miller wrote: >From: Maxime Chevallier >Date: Fri, 19 Apr 2019 15:30:27 +0200 > >> +/* Internal represention of a Flow Steering rule */ >> +struct mvpp2_rfs_rule { >> + /* Rule location inside the flow*/ >> + int loc; >> + >> + /* Flow type, such as TCP_V4_FLOW, IP6_FLOW, etc. */ >> + int flow_type; >> + >> + /* The lookup type used by this flow. This allows the classification >> + * engines to differentiate between entries that match the same >> + * parameters >> + */ >> + int lu_type; >> + >> + /* Index of the entry handling this rule in the flow table */ >> + int flt_index; >> + >> + /* Index of the C2 TCAM entry handling this rule */ >> + int c2_index; > >On 64-bit there will be a 32-bit hole here. Why not put hek_fields >and engine here? You're right, I'll re-arrange that. Thanks, Maxime _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel