From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E034C282DD for ; Sat, 20 Apr 2019 13:33:58 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 102C221479 for ; Sat, 20 Apr 2019 13:33:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="iwaooSgL"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="C8kv3jAb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 102C221479 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WeZXoGUnxTIp+cGgXqZXafq9uARvOjSdq6XIeuepo6Q=; b=iwaooSgL427Ygc UvP+PHk5eP9fH06d3KqsHjOvd+4LmpudnADfhrK3X1SAZqIoxd3GKnnuAcdXA2ZjmevbRrSIyMUbI Z8yZ0s4FsbOcxShbwBNms54FF/laTViLHIpiZJcPwmvzeXRrz++5G83omngbTAiZyiTZhmLbKIne6 BGFH0wCxpyYRe3/QjA0ROT7iK+0xUcDD1wJKOMnk7ojX3ZqOPgLnB38Z3szFRU1aJdfYSnk3Po92s 40RlmzqnO2LM3fXSnNlQrnGuDYQq9HiKqafPl9LGLWIaAYjVOGkt1yhMKlq/j4OgpmWl3wmLNVFjk IRG2VSkwxQv+SbPz3F0A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hHq7x-0004du-D6; Sat, 20 Apr 2019 13:33:57 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hHq7u-0004cU-JD for linux-arm-kernel@lists.infradead.org; Sat, 20 Apr 2019 13:33:55 +0000 Received: from dragon (98.142.130.235.16clouds.com [98.142.130.235]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6C66E21479; Sat, 20 Apr 2019 13:33:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1555767234; bh=uv9UMcb4koHXzC+O2iZ4IX/kI0rURgmQss4GjE9TCNc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=C8kv3jAbL73OANYUFSdPoMHloXvQaaVMOBSy0Qf4ng1XtgdcJnZFYtHcXFSu1SVWI 0LZXwmugw5ttG17EsCkWvO0FENxph6CKJG4Lwu0aU9BJ4UuKPQmP+NBqmT+iyRY+Sg KOLF5Qf8M3SGqtVwpyWtJSibhwBN/sC4oA0wUD48= Date: Sat, 20 Apr 2019 21:33:43 +0800 From: Shawn Guo To: Adam Ford Subject: Re: [PATCH v3 1/9] ARM: dts: imx6qdl: Specify IMX6QDL_CLK_IPG as "ipg" clock to SDMA Message-ID: <20190420133342.GB14187@dragon> References: <20190329064924.8728-1-andrew.smirnov@gmail.com> <20190411023008.GK26817@dragon> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190420_063354_652256_9A2BBB2C X-CRM114-Status: GOOD ( 14.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrey Smirnov , Angus Ainslie , Linux Kernel Mailing List , arm-soc , Fabio Estevam , Chris Healy , Lucas Stach Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Apr 20, 2019 at 07:14:26AM -0500, Adam Ford wrote: > On Wed, Apr 10, 2019 at 9:30 PM Shawn Guo wrote: > > > > On Thu, Mar 28, 2019 at 11:49:16PM -0700, Andrey Smirnov wrote: > > > Since 25aaa75df1e6 SDMA driver uses clock rates of "ipg" and "ahb" > > > clock to determine if it needs to configure the IP block as operating > > > at 1:1 or 1:2 clock ratio (ACR bit in SDMAARM_CONFIG). Specifying both > > > clocks as IMX6QDL_CLK_SDMA results in driver incorrectly thinking that > > > ratio is 1:1 which results in broken SDMA funtionality(this at least > > > breaks RAVE SP serdev driver on RDU2). Fix the code to specify > > > IMX6QDL_CLK_IPG as "ipg" clock for SDMA, to avoid detecting incorrect > > > clock ratio. > > > > > > Fixes: 25aaa75df1e6 ("dmaengine: imx-sdma: add clock ratio 1:1 check") > > > > Since we have a fix in the dma driver, I dropped the Fixes tag here. > > > > Applied all, thanks. > > Do you know if the SDMA fixes will be back-ported to 5.0.y branch? To > get 5.0 working, I need to manually apply the patches. I'm confused here. The regression was caused by 25aaa75df1e6 ("dmaengine: imx-sdma: add clock ratio 1:1 check"), which only lands on mainline with v5.1-rc1. How would 5.0.y branch need fixing? Shawn _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel