From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 817FAC282DD for ; Sat, 20 Apr 2019 16:57:04 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 47B3120821 for ; Sat, 20 Apr 2019 16:57:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="bpdqFrFf"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SOYRxci5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 47B3120821 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=LKRuC6KG5FnB03DNKwXKQf/DFMU3q0Qmw9BB7PKHbYo=; b=bpd qFrFfebZ6zSY0r+j8BCujJlpVAOE3GzRI2aeGRwvEABw2LoaAkLJq6PPpsOFOjNeY7gzDK0ihRErW Ur7yvwbQGpHDfqEOk6YbuRhLtfUZZcPambvZp31RD2boC22MgsJfnbKn0oaytU97PEA1ieof9GJ74 /rXsg7NItl8OBvXr0hiCPWgTxSYEZw/nzX3StDIbltv326hJj5GgQvJR7/18acvI8O6NxfIjCDMSt NQbG1Z2MBVY/O800cF5DnjMXZLHwhU4J9k3vVA4LxhCkkxw3l4gTSNX/dZI+yuEvalzFqKowEdQNK wr5FzGy1CEV9rP1Pt3rEqv4kMMwfqtg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hHtIP-00069c-2M; Sat, 20 Apr 2019 16:56:57 +0000 Received: from mail-ot1-x343.google.com ([2607:f8b0:4864:20::343]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hHtIL-00068t-QG; Sat, 20 Apr 2019 16:56:55 +0000 Received: by mail-ot1-x343.google.com with SMTP id o74so6544021ota.3; Sat, 20 Apr 2019 09:56:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=oThT7uOJYj+D0UqYv7lT6L2LxoANKCg7LyACp/+if0s=; b=SOYRxci5ZsYcqpFBMNbq2HW5IhcQbkHUznBK1kzDFmcTe0OU3HhmeZMmKt70xetYzy WdEjsXaYT7IPmKv7d1lOr/zvuHoDJlWPHQKJCq+icDpdQQiECaa85RVNJ92B35rdI6PL QMrjMdzbjLw4HQ01o4KsQL1EhvgICRQbRtcOoH7OrkBohP8DzsxBwRfpbH9XySq+praO X3BR3o6AY9tbvXCBgeemlT5W90IJ2Ac3DQWf4YdIAnv8hxlQ17/aUDr2PJFa4+Q3Vvcw iNaQ/eR/CoIQeXwEKcARZUtu0OADNhrnFznA+8PybhiceTZRoFE/O/FIIu0zKCBP/FcQ BwvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=oThT7uOJYj+D0UqYv7lT6L2LxoANKCg7LyACp/+if0s=; b=oryxkWNQDAqw8DizEkumjAtd7maf0Syn6dvAmirhrd3jWKVhImUJZgUoUeKB5NkAc+ XJWFbk7r7YewOdnGJ+gbIaX7CwWpr2veOTnbGMJSjd5EWUF7i1Bn7/kPcDY3SOErWWtP 4QkZMcgopHZrb3QRiqMd2itjM9ruZTDG+HIX5G85hpqf3SgSx7akrscLeQT21HHs+uLX EoX6T6wcraxYBvo51mISpG/Q+XqezcgUcqynZdr4O81X4Poo5p4Ucza/tCRwMtK+QGyK ATJUQaZCSb9+DLSdMGMntMXnEGWMA82ewrHslBR6kjDbAbNG55m02Z9NcD/rWCph2Jtu S9zg== X-Gm-Message-State: APjAAAWuHSxDSBR5BA2lY2ZKTln1gCez09Loh9pupv037WbiGlKQiKeH KUJvB+BAPoxwe1Ynsu5eIvE= X-Google-Smtp-Source: APXvYqwES6UIDA1i/g29atJ5cFlrjw91I0PtImp8n0cy6UxeoVV2mctnJnsBLUaB+5w2vq9ct1b1Vg== X-Received: by 2002:a9d:4799:: with SMTP id b25mr5861103otf.264.1555779411562; Sat, 20 Apr 2019 09:56:51 -0700 (PDT) Received: from madhuleo ([2605:6000:1023:606d:151b:11be:d797:d50]) by smtp.gmail.com with ESMTPSA id o1sm3740746otj.11.2019.04.20.09.56.50 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 20 Apr 2019 09:56:50 -0700 (PDT) From: Madhumitha Prabakaran To: eric@anholt.net, stefan.wahren@i2se.com, gregkh@linuxfoundation.org, f.fainelli@gmail.com, rjui@broadcom.com, sbranden@broadcom.com, bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] Staging: vc04_services: Cleanup in ctrl_set_bitrate() Date: Sat, 20 Apr 2019 11:56:44 -0500 Message-Id: <20190420165644.11892-1-madhumithabiw@gmail.com> X-Mailer: git-send-email 2.17.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190420_095653_878225_D3E12C7F X-CRM114-Status: UNSURE ( 9.65 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Madhumitha Prabakaran MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Remove unnecessary variable and replace return type. In addition to that align the function parameters with parentheses to maintain Linux coding style. Issue suggested by Coccinelle. Signed-off-by: Madhumitha Prabakaran --- Changes in v2 1) Fix my own error of removing function call from the variable. 2) Align the function parameters with parentheses. --- --- .../staging/vc04_services/bcm2835-camera/controls.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/staging/vc04_services/bcm2835-camera/controls.c b/drivers/staging/vc04_services/bcm2835-camera/controls.c index e39ab5fae724..71eb349c3138 100644 --- a/drivers/staging/vc04_services/bcm2835-camera/controls.c +++ b/drivers/staging/vc04_services/bcm2835-camera/controls.c @@ -607,18 +607,16 @@ static int ctrl_set_bitrate(struct bm2835_mmal_dev *dev, struct v4l2_ctrl *ctrl, const struct bm2835_mmal_v4l2_ctrl *mmal_ctrl) { - int ret; struct vchiq_mmal_port *encoder_out; dev->capture.encode_bitrate = ctrl->val; encoder_out = &dev->component[MMAL_COMPONENT_VIDEO_ENCODE]->output[0]; - ret = vchiq_mmal_port_parameter_set(dev->instance, encoder_out, - mmal_ctrl->mmal_id, - &ctrl->val, sizeof(ctrl->val)); - ret = 0; - return ret; + vchiq_mmal_port_parameter_set(dev->instance, encoder_out, + mmal_ctrl->mmal_id, &ctrl->val, + sizeof(ctrl->val)); + return 0; } static int ctrl_set_bitrate_mode(struct bm2835_mmal_dev *dev, -- 2.17.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel