From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0AAC6C282DD for ; Sat, 20 Apr 2019 19:51:26 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CDCF720833 for ; Sat, 20 Apr 2019 19:51:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="G4CePfpf"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="Au4yafyS" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CDCF720833 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gc7DyH7EEbQhNGBLrU3vA9U1sMdTHldCy6xLSCccPYI=; b=G4CePfpfSGUrTA u42tLzQacB6AfPsQRPkkyzUHapZwk2OmuH09+Y3KQ1Wl5TBtxEEModH6Nry0GuXpErUo2kno7ASNB fBux4GmimhLNcEob4UeverAl+86OXxWnAmjAnOm/9fbDuyJ7j7eqrsp3bdAeJNF0Om1WLqp8zIv2/ MP+TqPxBSPFL3h9lm82dNVqPR/2hU2P0uAijfrh1reH/6TdSGubfkIgRetESQyhOI/rOV3LuLLxFr xRCWczGnb1kYf/LxTiI/ZbMU0RKJRIQhg301JGDznb3A3jolNp5fGWyP57FBGpsBMKJtrlnnOWR86 uYSp5VAdRqTOozsSTTiQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hHw10-00068l-Gx; Sat, 20 Apr 2019 19:51:10 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hHw0w-00068J-In; Sat, 20 Apr 2019 19:51:08 +0000 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id ED67520833; Sat, 20 Apr 2019 19:51:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1555789865; bh=IWyxSI3pim/NYOfv+ZVrKFJhmS8+s9EwNEOMIt55IjE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Au4yafySDZxTkow5xWlbMBUWp+QNkxTgzp2WdPoLOrxR6v5KPYTl8lkQp54eYXn1o HPTNkV0GGeOp3tMuqtssXMPzubStFJhkWY8nnmzjdgrIDujhVhcJ5cUMbAOZWJe3uG On3YuxIjVK4lpQzWUBE1UHfmZaewTOx64nVyP7dU= Date: Sat, 20 Apr 2019 21:51:03 +0200 From: Greg KH To: Madhumitha Prabakaran Subject: Re: [PATCH v2] Staging: vc04_services: Cleanup in ctrl_set_bitrate() Message-ID: <20190420195103.GA18489@kroah.com> References: <20190420165644.11892-1-madhumithabiw@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190420165644.11892-1-madhumithabiw@gmail.com> User-Agent: Mutt/1.11.4 (2019-03-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190420_125106_638459_335F4B34 X-CRM114-Status: GOOD ( 15.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: stefan.wahren@i2se.com, devel@driverdev.osuosl.org, f.fainelli@gmail.com, sbranden@broadcom.com, rjui@broadcom.com, linux-kernel@vger.kernel.org, eric@anholt.net, bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Apr 20, 2019 at 11:56:44AM -0500, Madhumitha Prabakaran wrote: > Remove unnecessary variable and replace return type. > In addition to that align the function parameters with parentheses to > maintain Linux coding style. > > Issue suggested by Coccinelle. > > Signed-off-by: Madhumitha Prabakaran > > --- > Changes in v2 > > 1) Fix my own error of removing function call from the variable. > 2) Align the function parameters with parentheses. > > --- > --- > .../staging/vc04_services/bcm2835-camera/controls.c | 10 ++++------ > 1 file changed, 4 insertions(+), 6 deletions(-) > > diff --git a/drivers/staging/vc04_services/bcm2835-camera/controls.c b/drivers/staging/vc04_services/bcm2835-camera/controls.c > index e39ab5fae724..71eb349c3138 100644 > --- a/drivers/staging/vc04_services/bcm2835-camera/controls.c > +++ b/drivers/staging/vc04_services/bcm2835-camera/controls.c > @@ -607,18 +607,16 @@ static int ctrl_set_bitrate(struct bm2835_mmal_dev *dev, > struct v4l2_ctrl *ctrl, > const struct bm2835_mmal_v4l2_ctrl *mmal_ctrl) > { > - int ret; > struct vchiq_mmal_port *encoder_out; > > dev->capture.encode_bitrate = ctrl->val; > > encoder_out = &dev->component[MMAL_COMPONENT_VIDEO_ENCODE]->output[0]; > > - ret = vchiq_mmal_port_parameter_set(dev->instance, encoder_out, > - mmal_ctrl->mmal_id, > - &ctrl->val, sizeof(ctrl->val)); > - ret = 0; > - return ret; > + vchiq_mmal_port_parameter_set(dev->instance, encoder_out, > + mmal_ctrl->mmal_id, &ctrl->val, > + sizeof(ctrl->val)); > + return 0; > } Why does this function even return anything at all if it can not fail? Why not return the value that vchiq_mmal_port_parameter_set() returned? thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel