From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CCC6C10F14 for ; Sun, 21 Apr 2019 08:00:17 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DE77620869 for ; Sun, 21 Apr 2019 08:00:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="F+bJN/d+"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="R5rEqR31" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DE77620869 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=rRWd8yG6hwqD7Jr6Hjx9L46UISQY+G+7dueSEiJFMSM=; b=F+bJN/d+zWbPSO vhZiz8BA6j/1gcTn/So9eVUfAj4fCGO1iWstPlTuaLfjsoxzbP0ddZ2HuIWKOZm50oLxDnP/5VT3+ jhl2x5vf9CliW9WcYIuKunIW04Jb2zriplf763AC5AKtJ8IXnE4sBtwkltRqLqQaaVhg7K+z/ND1f hfRczDrpUdPyR6GX2NrYV1+v1Snw2bJGU/0iVmaW7BuOYLNBgZN6thQhnUegnSiU9O+aK9pLtRotB xEdKXC+DokqF8b3e9vLamXTjmRDCz3eaNA1nR19EZTcckGwUkyh0KJdX+sTnDCPpWiG1yC8Ekpko9 fNRPmnbXX6QKLSuvRzbA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hI7OJ-0002KQ-UO; Sun, 21 Apr 2019 07:59:59 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hI7OH-0002K1-6C for linux-arm-kernel@lists.infradead.org; Sun, 21 Apr 2019 07:59:58 +0000 Received: from dragon (98.142.130.235.16clouds.com [98.142.130.235]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id ED6DF20869; Sun, 21 Apr 2019 07:59:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1555833596; bh=WeRg4KSjI+4PPSsTWhAKMrKBNthp4wl9LpEfXFetrfg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=R5rEqR31M42UD4BCWWWPQHZE1+mkeQelvX/+TUDmgEDUoxgvZOUHZryDrReS74o3L vIwBKHjSWCX8de85pXrOpW149jOvBoSrt6nlESpFDaUMKdTo41M+pbbBeJ5tGV0GwS R1eh8eUHb5KLnMwlzLjT7uwLif2dCSXCkgVqM2vg= Date: Sun, 21 Apr 2019 15:59:41 +0800 From: Shawn Guo To: Vladimir Oltean Subject: Re: [PATCH v2 2/2] ARM: dts: ls1021: Fix SGMII PCS link remaining down after PHY disconnect Message-ID: <20190421075939.GE19962@dragon> References: <20190411232315.19588-1-olteanv@gmail.com> <20190411232315.19588-2-olteanv@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190411232315.19588-2-olteanv@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190421_005957_249598_0C154A25 X-CRM114-Status: GOOD ( 11.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, leoyang.li@nxp.com, claudiu.manoil@nxp.com, robh+dt@kernel.org, davem@davemloft.net, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Apr 12, 2019 at 02:23:15AM +0300, Vladimir Oltean wrote: > Each eTSEC MAC has its own TBI (SGMII) PCS and private MDIO bus. > But due to a DTS oversight, both SGMII-compatible MACs of the LS1021 SoC > are pointing towards the same internal PCS. Therefore nobody is > controlling the internal PCS of eTSEC0. > > Upon initial ndo_open, the SGMII link is ok by virtue of U-boot > initialization. But upon an ifdown/ifup sequence, the code path from > ndo_open -> init_phy -> gfar_configure_serdes does not get executed for > the PCS of eTSEC0 (and is executed twice for MAC eTSEC1). So the SGMII > link remains down for eTSEC0. On the LS1021A-TWR board, to signal this > failure condition, the PHY driver keeps printing > '803x_aneg_done: SGMII link is not ok'. > > Fixes: 055223d4d22d ("ARM: dts: ls1021a: Enable the eTSEC ports on QDS and TWR") > Signed-off-by: Vladimir Oltean > Reviewed-by: Claudiu Manoil To get it land as fix a bit easier, I squashed both patches into one (with a little edit on commit log), and applied it. Shawn _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel