* [PATCH] arm64: dts: imx8mq: fix GPU clock frequency
@ 2019-04-15 13:59 Lucas Stach
2019-04-15 18:52 ` Abel Vesa
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Lucas Stach @ 2019-04-15 13:59 UTC (permalink / raw)
To: Shawn Guo
Cc: linux-arm-kernel, Fabio Estevam, NXP Linux Team,
Pengutronix Kernel Team, patchwork-lst
v2 of "clk: imx: Refactor entire sccg pll clk" dropped the implicit
reparenting of the PLL output from the bypass clock to the real
PLL. The commit introducing the GPU node had only been tested against
v1 of this patch. Without an explicit reparent to the real PLL the
GPU is stuck at the bypass clock rate of 25MHz, serverly hampering
performance.
Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
---
arch/arm64/boot/dts/freescale/imx8mq.dtsi | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
index 7c0b12ad7ccf..6d635ba0904c 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
@@ -827,13 +827,15 @@
assigned-clocks = <&clk IMX8MQ_CLK_GPU_CORE_SRC>,
<&clk IMX8MQ_CLK_GPU_SHADER_SRC>,
<&clk IMX8MQ_CLK_GPU_AXI>,
- <&clk IMX8MQ_CLK_GPU_AHB>;
+ <&clk IMX8MQ_CLK_GPU_AHB>,
+ <&clk IMX8MQ_GPU_PLL_BYPASS>;
assigned-clock-parents = <&clk IMX8MQ_GPU_PLL_OUT>,
<&clk IMX8MQ_GPU_PLL_OUT>,
<&clk IMX8MQ_GPU_PLL_OUT>,
- <&clk IMX8MQ_GPU_PLL_OUT>;
+ <&clk IMX8MQ_GPU_PLL_OUT>,
+ <&clk IMX8MQ_GPU_PLL>;
assigned-clock-rates = <800000000>, <800000000>,
- <800000000>, <800000000>;
+ <800000000>, <800000000>, <0>;
power-domains = <&pgc_gpu>;
};
--
2.20.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] arm64: dts: imx8mq: fix GPU clock frequency
2019-04-15 13:59 [PATCH] arm64: dts: imx8mq: fix GPU clock frequency Lucas Stach
@ 2019-04-15 18:52 ` Abel Vesa
2019-04-22 1:18 ` Shawn Guo
2019-04-29 17:28 ` Guido Günther
2 siblings, 0 replies; 4+ messages in thread
From: Abel Vesa @ 2019-04-15 18:52 UTC (permalink / raw)
To: Lucas Stach
Cc: Shawn Guo, patchwork-lst@pengutronix.de, dl-linux-imx,
Pengutronix Kernel Team, Fabio Estevam,
linux-arm-kernel@lists.infradead.org
On 19-04-15 15:59:22, Lucas Stach wrote:
> v2 of "clk: imx: Refactor entire sccg pll clk" dropped the implicit
> reparenting of the PLL output from the bypass clock to the real
> PLL. The commit introducing the GPU node had only been tested against
> v1 of this patch. Without an explicit reparent to the real PLL the
> GPU is stuck at the bypass clock rate of 25MHz, serverly hampering
> performance.
>
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
Reviewed-by: Abel Vesa <abel.vesa@nxp.com>
> ---
> arch/arm64/boot/dts/freescale/imx8mq.dtsi | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> index 7c0b12ad7ccf..6d635ba0904c 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> @@ -827,13 +827,15 @@
> assigned-clocks = <&clk IMX8MQ_CLK_GPU_CORE_SRC>,
> <&clk IMX8MQ_CLK_GPU_SHADER_SRC>,
> <&clk IMX8MQ_CLK_GPU_AXI>,
> - <&clk IMX8MQ_CLK_GPU_AHB>;
> + <&clk IMX8MQ_CLK_GPU_AHB>,
> + <&clk IMX8MQ_GPU_PLL_BYPASS>;
> assigned-clock-parents = <&clk IMX8MQ_GPU_PLL_OUT>,
> <&clk IMX8MQ_GPU_PLL_OUT>,
> <&clk IMX8MQ_GPU_PLL_OUT>,
> - <&clk IMX8MQ_GPU_PLL_OUT>;
> + <&clk IMX8MQ_GPU_PLL_OUT>,
> + <&clk IMX8MQ_GPU_PLL>;
> assigned-clock-rates = <800000000>, <800000000>,
> - <800000000>, <800000000>;
> + <800000000>, <800000000>, <0>;
> power-domains = <&pgc_gpu>;
> };
>
> --
> 2.20.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: dts: imx8mq: fix GPU clock frequency
2019-04-15 13:59 [PATCH] arm64: dts: imx8mq: fix GPU clock frequency Lucas Stach
2019-04-15 18:52 ` Abel Vesa
@ 2019-04-22 1:18 ` Shawn Guo
2019-04-29 17:28 ` Guido Günther
2 siblings, 0 replies; 4+ messages in thread
From: Shawn Guo @ 2019-04-22 1:18 UTC (permalink / raw)
To: Lucas Stach
Cc: linux-arm-kernel, Fabio Estevam, NXP Linux Team,
Pengutronix Kernel Team, patchwork-lst
On Mon, Apr 15, 2019 at 03:59:22PM +0200, Lucas Stach wrote:
> v2 of "clk: imx: Refactor entire sccg pll clk" dropped the implicit
> reparenting of the PLL output from the bypass clock to the real
> PLL. The commit introducing the GPU node had only been tested against
> v1 of this patch. Without an explicit reparent to the real PLL the
> GPU is stuck at the bypass clock rate of 25MHz, serverly hampering
> performance.
>
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
Applied, thanks.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: dts: imx8mq: fix GPU clock frequency
2019-04-15 13:59 [PATCH] arm64: dts: imx8mq: fix GPU clock frequency Lucas Stach
2019-04-15 18:52 ` Abel Vesa
2019-04-22 1:18 ` Shawn Guo
@ 2019-04-29 17:28 ` Guido Günther
2 siblings, 0 replies; 4+ messages in thread
From: Guido Günther @ 2019-04-29 17:28 UTC (permalink / raw)
To: Lucas Stach
Cc: Shawn Guo, patchwork-lst, NXP Linux Team, Pengutronix Kernel Team,
Fabio Estevam, linux-arm-kernel
Hi,
On Mon, Apr 15, 2019 at 03:59:22PM +0200, Lucas Stach wrote:
> v2 of "clk: imx: Refactor entire sccg pll clk" dropped the implicit
> reparenting of the PLL output from the bypass clock to the real
> PLL. The commit introducing the GPU node had only been tested against
> v1 of this patch. Without an explicit reparent to the real PLL the
> GPU is stuck at the bypass clock rate of 25MHz, serverly hampering
> performance.
>
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> ---
> arch/arm64/boot/dts/freescale/imx8mq.dtsi | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> index 7c0b12ad7ccf..6d635ba0904c 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> @@ -827,13 +827,15 @@
> assigned-clocks = <&clk IMX8MQ_CLK_GPU_CORE_SRC>,
> <&clk IMX8MQ_CLK_GPU_SHADER_SRC>,
> <&clk IMX8MQ_CLK_GPU_AXI>,
> - <&clk IMX8MQ_CLK_GPU_AHB>;
> + <&clk IMX8MQ_CLK_GPU_AHB>,
> + <&clk IMX8MQ_GPU_PLL_BYPASS>;
> assigned-clock-parents = <&clk IMX8MQ_GPU_PLL_OUT>,
> <&clk IMX8MQ_GPU_PLL_OUT>,
> <&clk IMX8MQ_GPU_PLL_OUT>,
> - <&clk IMX8MQ_GPU_PLL_OUT>;
> + <&clk IMX8MQ_GPU_PLL_OUT>,
> + <&clk IMX8MQ_GPU_PLL>;
> assigned-clock-rates = <800000000>, <800000000>,
> - <800000000>, <800000000>;
> + <800000000>, <800000000>, <0>;
> power-domains = <&pgc_gpu>;
> };
Reviewed-by: Guido Günther <agx@sigxcpu.org>
>
> --
> 2.20.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-04-29 17:29 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-04-15 13:59 [PATCH] arm64: dts: imx8mq: fix GPU clock frequency Lucas Stach
2019-04-15 18:52 ` Abel Vesa
2019-04-22 1:18 ` Shawn Guo
2019-04-29 17:28 ` Guido Günther
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).