From: Shawn Guo <shawnguo@kernel.org>
To: Aisheng Dong <aisheng.dong@nxp.com>
Cc: Anson Huang <anson.huang@nxp.com>,
"sboyd@kernel.org" <sboyd@kernel.org>,
"mturquette@baylibre.com" <mturquette@baylibre.com>,
dl-linux-imx <linux-imx@nxp.com>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
Fabio Estevam <fabio.estevam@nxp.com>,
"linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 1/1] Revert "clk: imx: use devm_platform_ioremap_resource() to simplify code"
Date: Mon, 22 Apr 2019 10:03:15 +0800 [thread overview]
Message-ID: <20190422020314.GR19962@dragon> (raw)
In-Reply-To: <1555670144-24220-1-git-send-email-aisheng.dong@nxp.com>
On Fri, Apr 19, 2019 at 10:42:51AM +0000, Aisheng Dong wrote:
> This reverts commit 612d5b65894b5b1607a004bd9bc60d5963b58ef6.
>
> Originally we use devm_ioremap() specifically because we want to bypass
> the devm_request_mem_region due to LPCG address space are shared with
> some other modules within the same SS (subsystem).
>
> The patch in question occasionally added the request_me_region back
> by calling devm_platform_ioremap_resource which results in all the devices
> with overlappded IO space failed to be probed as follows:
>
> [ 1.062996] fsl-lpuart 5a060000.serial: can't request region for resource [mem 0x5a060000-0x5a060fff]
> [ 1.071923] fsl-lpuart: probe of 5a060000.serial failed with error -16
>
> Cc: Anson Huang <Anson.Huang@nxp.com>
> Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
> ---
> Shawn,
>
> This is a new issue and only exist in imx/for-next branch.
> You can decide whether to remove it or take the revert patch.
Dropped the offending patch. Thanks for finding it.
Shawn
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2019-04-22 2:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-19 10:42 [PATCH 1/1] Revert "clk: imx: use devm_platform_ioremap_resource() to simplify code" Aisheng Dong
2019-04-20 15:30 ` Leonard Crestez
2019-04-22 2:03 ` Shawn Guo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190422020314.GR19962@dragon \
--to=shawnguo@kernel.org \
--cc=aisheng.dong@nxp.com \
--cc=anson.huang@nxp.com \
--cc=fabio.estevam@nxp.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).