From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E42BAC282E1 for ; Mon, 22 Apr 2019 04:25:51 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B20F62077C for ; Mon, 22 Apr 2019 04:25:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="d36XWujK"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jGHiR6tV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B20F62077C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2/iW8vPymANVwnB3W+vMzRONzt+6p22dqldnPfzxVBM=; b=d36XWujKj6sAtI LRIs1To2dpZM3mOgwaiDAOx6HX4mOM5UWZ2osRSUJ2vL2AaW4vddsVYQcJCM61vA/K0Q//bkiDRRj Ery5y2qVH0QgvpasxJ+cIDi2+SGoEVqMk5PB2euzYExkUFOz+sU+FOXg7U97bldhqQ4IqLqTsyqiB hU+7dJSrpXMEazrRRg9OI2Cy8see3yDgZ6TZm8ZNrrqZsmGFDMdTKsrHy7gPnerPFlrp1IsdeyvIc BB1+c9loNgwkw1P3//T7XoB4jvHu9nPfEReY/y8QmHDxgaThIbKwb+oOiA+HV/dWyASjeAI99Q56p GDYhXq3rpWHDDU0mb53w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hIQWM-0005u7-SD; Mon, 22 Apr 2019 04:25:34 +0000 Received: from mail-pl1-x644.google.com ([2607:f8b0:4864:20::644]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hIQWJ-0005tk-L5 for linux-arm-kernel@lists.infradead.org; Mon, 22 Apr 2019 04:25:33 +0000 Received: by mail-pl1-x644.google.com with SMTP id y6so5226106plt.1 for ; Sun, 21 Apr 2019 21:25:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=LgVpHhZnASfuRCS+c0R9jxeOE6l0uajXoRX2DmClENs=; b=jGHiR6tVvPxNUj8YYvuMJM+meJG8qnE4iuQs9vQ13tk2bJGHQ6T/yfoOns9zlr0J0D yPsHITuuA4H+NacmqF9ccCqEOVfbaO8R6ORQFWrxl8GxqgV+RQeEsOTHaZsRnJVFtgHO v2Pup5gcRTUpnpIYsUnF6ZHEO287z1otclNVoXGGE2+N5GKYzdS/6mXGBgtw46scXszw PjrJYS8qz3I4pr3Q0xa8aJTCcwGkh43SSQhTeKGdWu8xZTee6YeQQK/QOR8bbaOmRxPP BLuS1fE6Vb1ydI6JW2LEY3Wo+qAZV9mj7fqSPWz4zsNQ3Cs5EnE7aAP8R0wFYYKNx1wC tghA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=LgVpHhZnASfuRCS+c0R9jxeOE6l0uajXoRX2DmClENs=; b=AICmi+RZxx2sq5ud2y1hd2xRksQiGU22/zkQ3xLe9psid99IK3CnHKAb6naMsuZz64 Bbfy+7AkH3XYafnhO/73prxYipKqBetGRHiiCN9danvYBgYBhnSfKovGVmFk8epbT9Cs FXG7sxmm8BrKMzDYQH5ZAtVx2iRM/m9BjxgKv+Y7sCMcHOU/ZMeNG1h4achjnfx0Iw6p zMMvxUuHqJMJgp1Wm7WBNA27xLO0iz43tNB9m/JfZfimJ7Dv5RYJ4wUZ4jWpO5Ea81SN 7Ok6uJz7BOrHstK65DRjt/1qsGgnfntXGoNsDV0vfEYoS/x2I9MNSfHeZTkKjR0E5h7v 1ARg== X-Gm-Message-State: APjAAAWiiFWjD/8CvzLHjo1QygonBxXIEmrdSrIh7QCejsePD6aHPGEh kYdndG6d54nK7x6PSyfs6d8= X-Google-Smtp-Source: APXvYqxTKugQGWfVu1bLTkffozSkuF5sJNMOsGX76y54k1minWbE0w4ZWJ9JmpBJc+FURcsC2USYpw== X-Received: by 2002:a17:902:31c3:: with SMTP id x61mr17900960plb.143.1555907127555; Sun, 21 Apr 2019 21:25:27 -0700 (PDT) Received: from Asurada (c-98-248-47-108.hsd1.ca.comcast.net. [98.248.47.108]) by smtp.gmail.com with ESMTPSA id k3sm9285633pfb.175.2019.04.21.21.25.26 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 21 Apr 2019 21:25:26 -0700 (PDT) Date: Sun, 21 Apr 2019 21:25:20 -0700 From: Nicolin Chen To: "S.j. Wang" Subject: Re: [PATCH] ARM: dts: imx: Add mclk0 clock for SAI Message-ID: <20190422042519.GA4304@Asurada> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.22 (2013-10-16) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190421_212531_718759_55370903 X-CRM114-Status: GOOD ( 18.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "mark.rutland@arm.com" , Aisheng Dong , Peng Fan , "festevam@gmail.com" , Anson Huang , "devicetree@vger.kernel.org" , Daniel Baluta , "s.hauer@pengutronix.de" , "linux-kernel@vger.kernel.org" , "robh+dt@kernel.org" , dl-linux-imx , "kernel@pengutronix.de" , "shawnguo@kernel.org" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Apr 22, 2019 at 03:30:26AM +0000, S.j. Wang wrote: > > > SAI has 4 clock sources, which can be selected using MSEL bit of SAI > > > TCR2 register. > > > > I have a doubt at this statement. As far as I can understand, this MSEL is > > probably used by its internal clock MUX, so it's not really proving that SAI > > has 4 MCLK inputs. What I know is that SAI block itself only has 3 MCLK > > inputs as we defined in DT. It's just internally connects bus clock or MCLK1 > > to input0 of clock MUX's and connects MCLK[1-3] to input[1-3]. So adding an > > MCLK0 here doesn't sound a right way to me. Unless someone can justify > > for it, I think we should just fix it from driver side. > > > > Thanks > > Nicolin > > > > The MSEL bit width is 2 bit, so there is 4 options, the MCLK0 maybe the same input as > MCLK1 or bus clock as you said, so we think may be better to show this relation in DT, > And this is DT's capability. Driver don't care about which clock connect to MCLK0, > it only need to know there is 4 MCLK from DT. I know what it is. But it feels weird that we add an MCLK0 just because of what a register filed has, and there's no "MCLK0" be mentioned in the RM at all. My point is that if SAI doesn't have a port named "MCLK0", I don't feel it's that convincing to have it in the DT. Usually in DT we define the clock sources of an entire IP block in audio use cases, not for an internal clock MUX. But taking a step back, it might not be really wrong to do so, since the MUX is a part of the hardware. If we redefine the MCLK[0-4] as "four clock sources of SAI's clock MUX selecting a clock for bit clock and frame clock providing" in the binding doc, I feel it'd make a lot of sense. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel