* [PATCH 0/1] AUXADC: Mediatek auxadc driver on MT8183 @ 2019-04-22 11:54 Zhiyong Tao 2019-04-22 11:54 ` [PATCH 1/2] dt-bindings: adc: mt8183: add binding document Zhiyong Tao 2019-04-22 11:54 ` [PATCH 2/2] arm64: dts: mt8183: Add auxadc device node Zhiyong Tao 0 siblings, 2 replies; 5+ messages in thread From: Zhiyong Tao @ 2019-04-22 11:54 UTC (permalink / raw) To: robh+dt, jic23, knaack.h, lars, pmeerw Cc: devicetree, sean.wang, srv_heupstream, linux-iio, erin.lo, hui.liu, linux-kernel, linux-mediatek, matthias.bgg, yingjoe.chen, eddie.huang, s.hauer, linux-arm-kernel This series includes two patches: 1.Add mt8183 auxadc compatible node in binding document. 1.Add mt8183 auxadc device node. Zhiyong Tao (1): arm64: dts: mt8183: Add auxadc device node arch/arm64/boot/dts/mediatek/mt8183-evb.dts | 4 ++++ arch/arm64/boot/dts/mediatek/mt8183.dtsi | 10 ++++++++++ 2 files changed, 14 insertions(+) -- 2.12.5 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 1/2] dt-bindings: adc: mt8183: add binding document 2019-04-22 11:54 [PATCH 0/1] AUXADC: Mediatek auxadc driver on MT8183 Zhiyong Tao @ 2019-04-22 11:54 ` Zhiyong Tao 2019-04-23 14:35 ` Matthias Brugger 2019-04-22 11:54 ` [PATCH 2/2] arm64: dts: mt8183: Add auxadc device node Zhiyong Tao 1 sibling, 1 reply; 5+ messages in thread From: Zhiyong Tao @ 2019-04-22 11:54 UTC (permalink / raw) To: robh+dt, jic23, knaack.h, lars, pmeerw Cc: devicetree, sean.wang, srv_heupstream, linux-iio, Zhiyong Tao, erin.lo, hui.liu, linux-kernel, linux-mediatek, matthias.bgg, yingjoe.chen, eddie.huang, s.hauer, linux-arm-kernel The commit adds mt8183 compatible node in binding document. Signed-off-by: Zhiyong Tao <zhiyong.tao@mediatek.com> --- Documentation/devicetree/bindings/iio/adc/mt6577_auxadc.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/iio/adc/mt6577_auxadc.txt b/Documentation/devicetree/bindings/iio/adc/mt6577_auxadc.txt index 0df9befdaecc..05bc79d8483c 100644 --- a/Documentation/devicetree/bindings/iio/adc/mt6577_auxadc.txt +++ b/Documentation/devicetree/bindings/iio/adc/mt6577_auxadc.txt @@ -15,6 +15,7 @@ Required properties: - "mediatek,mt2712-auxadc": For MT2712 family of SoCs - "mediatek,mt7622-auxadc": For MT7622 family of SoCs - "mediatek,mt8173-auxadc": For MT8173 family of SoCs + - "mediatek,mt8183-auxadc": For MT8183 family of SoCs - reg: Address range of the AUXADC unit. - clocks: Should contain a clock specifier for each entry in clock-names - clock-names: Should contain "main". -- 2.12.5 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] dt-bindings: adc: mt8183: add binding document 2019-04-22 11:54 ` [PATCH 1/2] dt-bindings: adc: mt8183: add binding document Zhiyong Tao @ 2019-04-23 14:35 ` Matthias Brugger 2019-04-24 0:51 ` Zhiyong Tao 0 siblings, 1 reply; 5+ messages in thread From: Matthias Brugger @ 2019-04-23 14:35 UTC (permalink / raw) To: Zhiyong Tao, robh+dt, jic23, knaack.h, lars, pmeerw Cc: devicetree, sean.wang, srv_heupstream, linux-iio, erin.lo, hui.liu, linux-kernel, linux-mediatek, yingjoe.chen, eddie.huang, s.hauer, linux-arm-kernel On 22/04/2019 13:54, Zhiyong Tao wrote: > The commit adds mt8183 compatible node in binding document. > > Signed-off-by: Zhiyong Tao <zhiyong.tao@mediatek.com> > --- > Documentation/devicetree/bindings/iio/adc/mt6577_auxadc.txt | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/iio/adc/mt6577_auxadc.txt b/Documentation/devicetree/bindings/iio/adc/mt6577_auxadc.txt > index 0df9befdaecc..05bc79d8483c 100644 > --- a/Documentation/devicetree/bindings/iio/adc/mt6577_auxadc.txt > +++ b/Documentation/devicetree/bindings/iio/adc/mt6577_auxadc.txt > @@ -15,6 +15,7 @@ Required properties: > - "mediatek,mt2712-auxadc": For MT2712 family of SoCs > - "mediatek,mt7622-auxadc": For MT7622 family of SoCs > - "mediatek,mt8173-auxadc": For MT8173 family of SoCs > + - "mediatek,mt8183-auxadc": For MT8183 family of SoCs > - reg: Address range of the AUXADC unit. > - clocks: Should contain a clock specifier for each entry in clock-names > - clock-names: Should contain "main". > You are missing the logic in the driver to bind against this compatible. If there is nothing different from other SoCs then you could add a compatible with a fallback, like: "mediatek,mt8183-auxadc", "mediatek,mt7622-auxadc": For MT8183 family of SoCs Regards, Matthias _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] dt-bindings: adc: mt8183: add binding document 2019-04-23 14:35 ` Matthias Brugger @ 2019-04-24 0:51 ` Zhiyong Tao 0 siblings, 0 replies; 5+ messages in thread From: Zhiyong Tao @ 2019-04-24 0:51 UTC (permalink / raw) To: Matthias Brugger Cc: devicetree, lars, srv_heupstream, linux-iio, erin.lo, hui.liu, linux-kernel, robh+dt, linux-mediatek, linux-arm-kernel, pmeerw, knaack.h, yingjoe.chen, eddie.huang, sean.wang, s.hauer, jic23 On Tue, 2019-04-23 at 16:35 +0200, Matthias Brugger wrote: > > On 22/04/2019 13:54, Zhiyong Tao wrote: > > The commit adds mt8183 compatible node in binding document. > > > > Signed-off-by: Zhiyong Tao <zhiyong.tao@mediatek.com> > > --- > > Documentation/devicetree/bindings/iio/adc/mt6577_auxadc.txt | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/Documentation/devicetree/bindings/iio/adc/mt6577_auxadc.txt b/Documentation/devicetree/bindings/iio/adc/mt6577_auxadc.txt > > index 0df9befdaecc..05bc79d8483c 100644 > > --- a/Documentation/devicetree/bindings/iio/adc/mt6577_auxadc.txt > > +++ b/Documentation/devicetree/bindings/iio/adc/mt6577_auxadc.txt > > @@ -15,6 +15,7 @@ Required properties: > > - "mediatek,mt2712-auxadc": For MT2712 family of SoCs > > - "mediatek,mt7622-auxadc": For MT7622 family of SoCs > > - "mediatek,mt8173-auxadc": For MT8173 family of SoCs > > + - "mediatek,mt8183-auxadc": For MT8183 family of SoCs > > - reg: Address range of the AUXADC unit. > > - clocks: Should contain a clock specifier for each entry in clock-names > > - clock-names: Should contain "main". > > > > You are missing the logic in the driver to bind against this compatible. > If there is nothing different from other SoCs then you could add a compatible > with a fallback, like: > > "mediatek,mt8183-auxadc", "mediatek,mt7622-auxadc": For MT8183 family of SoCs ==> Thanks for your suggestion. In v2, we will add the comment here: - "mediatek,mt8183-auxadc", "mediatek,mt8173-auxadc": For MT8183 family of SoCs. > > Regards, > Matthias _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 2/2] arm64: dts: mt8183: Add auxadc device node 2019-04-22 11:54 [PATCH 0/1] AUXADC: Mediatek auxadc driver on MT8183 Zhiyong Tao 2019-04-22 11:54 ` [PATCH 1/2] dt-bindings: adc: mt8183: add binding document Zhiyong Tao @ 2019-04-22 11:54 ` Zhiyong Tao 1 sibling, 0 replies; 5+ messages in thread From: Zhiyong Tao @ 2019-04-22 11:54 UTC (permalink / raw) To: robh+dt, jic23, knaack.h, lars, pmeerw Cc: devicetree, sean.wang, srv_heupstream, linux-iio, Zhiyong Tao, erin.lo, hui.liu, linux-kernel, linux-mediatek, matthias.bgg, yingjoe.chen, eddie.huang, s.hauer, linux-arm-kernel Add auxadc device node for MT8183 Signed-off-by: Zhiyong Tao <zhiyong.tao@mediatek.com> --- arch/arm64/boot/dts/mediatek/mt8183-evb.dts | 4 ++++ arch/arm64/boot/dts/mediatek/mt8183.dtsi | 10 ++++++++++ 2 files changed, 14 insertions(+) diff --git a/arch/arm64/boot/dts/mediatek/mt8183-evb.dts b/arch/arm64/boot/dts/mediatek/mt8183-evb.dts index 9b525597e5ec..49909acc6efa 100644 --- a/arch/arm64/boot/dts/mediatek/mt8183-evb.dts +++ b/arch/arm64/boot/dts/mediatek/mt8183-evb.dts @@ -26,6 +26,10 @@ }; }; +&auxadc { + status = "okay"; +}; + &uart0 { status = "okay"; }; diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi index 75c4881bbe5e..57580d973316 100644 --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi @@ -269,6 +269,16 @@ clock-names = "spi", "wrap"; }; + auxadc: auxadc@11001000 { + compatible = "mediatek,mt8183-auxadc", + "mediatek,mt8173-auxadc"; + reg = <0 0x11001000 0 0x1000>; + clocks = <&infracfg CLK_INFRA_AUXADC>; + clock-names = "main"; + #io-channel-cells = <1>; + status = "disabled"; + }; + uart0: serial@11002000 { compatible = "mediatek,mt8183-uart", "mediatek,mt6577-uart"; -- 2.12.5 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-04-24 0:51 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2019-04-22 11:54 [PATCH 0/1] AUXADC: Mediatek auxadc driver on MT8183 Zhiyong Tao 2019-04-22 11:54 ` [PATCH 1/2] dt-bindings: adc: mt8183: add binding document Zhiyong Tao 2019-04-23 14:35 ` Matthias Brugger 2019-04-24 0:51 ` Zhiyong Tao 2019-04-22 11:54 ` [PATCH 2/2] arm64: dts: mt8183: Add auxadc device node Zhiyong Tao
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).