From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8187C10F14 for ; Tue, 23 Apr 2019 13:36:19 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BB3E3214AE for ; Tue, 23 Apr 2019 13:36:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="L63lNwtZ"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="J+XOdqWW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BB3E3214AE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=EBPqsv8KOE1fOwl/nbpBGy0S5FZIb+wnNgxH5TZELPY=; b=L63lNwtZuopw7J 3FeQ4g0Rkn5v+xbMdP14uPtLagx4EGnNxULKKT1Ku/9EV+t1eZZGuVCt/q4LemDgCnn/P/LV/nwbr ozHLOiDVqD3HDJ0VBuhWyE6laLJYz9Sd7JePib5+t5Jp+tR3MbjTfJ64U7zn/2e+pv/usLS2aqfv+ fbxX0Ztmbf51bqbBAPth1T1CbOqth9tvS3IHVLTTigtN2P2etrkUAnhDaID+gJvlgp9oP6NA2fsUJ FLstyS0CjCgemOEio3nqahow4TsC8vwRoJe+hjy0tG1JNWwlKRahOWdTP7iK7MR1NSIZrmpqsRHc0 IFitUa+3eaiMv6/K5UnQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hIvan-0004FU-V9; Tue, 23 Apr 2019 13:36:13 +0000 Received: from mail-oi1-x241.google.com ([2607:f8b0:4864:20::241]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hIvak-0004F0-M2; Tue, 23 Apr 2019 13:36:12 +0000 Received: by mail-oi1-x241.google.com with SMTP id t81so11252442oig.10; Tue, 23 Apr 2019 06:36:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=rnJqCqpjZuGWNAaHeRBe5a/70WgmeQJC/iIWiElLinA=; b=J+XOdqWWf3QnLVr6LObWfdULuHZgU7u6mQqvi+Jpm2KyIYlyuYlB35ZSR+mDdtRDLp 25UvUjui4JGRHrEloyh5MtbWdhsgiHMQYDyOYlQ1XcsVzjo22AmxpwNN5TWLX7hQKdSb yhC5htt4GTBEG1i0HvIZcqQETJ0vLbz7R29QlMmOkBDn9XPicuaipaWRLtLIzFSBQdYc 8SwPcnbCWoLYT9ZCeRNT4QwUSv1c63gaQyQaT278cQRo2x4sFkDyjc1PeywU5RCnQxkn yageI3cewIELy+4NZRIURtH3grNcpFKdx0fJGGe0XkT2wMctFzp6kcf5+xXIX5dilom2 t6kQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=rnJqCqpjZuGWNAaHeRBe5a/70WgmeQJC/iIWiElLinA=; b=AcHV3ViqadZItA5+kzzk1Vypvd85jOcaH0/znGTn80OvGl1YCeuBJwLjuueNSEowW6 mEkhFTWnXq3Zuwp26GaiaOq9METaIgOpel0e1R9sihTjtYvagzfYl3Z+QFRklAzCtxW1 1pIbSkDuNI8myuk3XPyWl8sSYvYhakEximKMLK1i7vQ4sIrh39jXREup8UxgXacxFkoO sP5ofcd4wTOCOQ+qX3WkbKrf7wEFmYThn9B/FPW7H3mc55X7SgW8COU4Q+Q/XKF7479C 5Ab+xZzaGARdt9ubeSE8PNMvQD//id2OMeJHFP+3FvbEYi2eJsX9SBrvjIAWvACmw1bU HKtQ== X-Gm-Message-State: APjAAAUV+mm33xhC4neFmPMN+WmP0S1ygJVmfFpRhUwVz3hJ7avwU+63 1ZL8mAoG7IMUxn+jlq4B17M= X-Google-Smtp-Source: APXvYqwvbJAUE0FJXmEZdy2TYItB1O9aG1pA7k5wYJZG22ygbfCjMX/yx0Qy9YQ+vv21xLAErdYbcg== X-Received: by 2002:aca:d88b:: with SMTP id p133mr1855306oig.56.1556026568946; Tue, 23 Apr 2019 06:36:08 -0700 (PDT) Received: from madhuleo ([2605:6000:1023:606d:fd8f:ea25:f4b2:9189]) by smtp.gmail.com with ESMTPSA id i136sm269431oib.42.2019.04.23.06.36.07 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 23 Apr 2019 06:36:08 -0700 (PDT) Date: Tue, 23 Apr 2019 08:36:05 -0500 From: Madhumitha Prabakaran To: Greg KH Subject: Re: [PATCH v2] Staging: vc04_services: Cleanup in ctrl_set_bitrate() Message-ID: <20190423133603.GA6310@madhuleo> References: <20190420165644.11892-1-madhumithabiw@gmail.com> <20190420195103.GA18489@kroah.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190420195103.GA18489@kroah.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190423_063610_745650_FF3733A7 X-CRM114-Status: GOOD ( 19.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: stefan.wahren@i2se.com, devel@driverdev.osuosl.org, f.fainelli@gmail.com, sbranden@broadcom.com, rjui@broadcom.com, linux-kernel@vger.kernel.org, eric@anholt.net, bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 04/20 :51, Greg KH wrote: > On Sat, Apr 20, 2019 at 11:56:44AM -0500, Madhumitha Prabakaran wrote: > > Remove unnecessary variable and replace return type. > > In addition to that align the function parameters with parentheses to > > maintain Linux coding style. > > > > Issue suggested by Coccinelle. > > > > Signed-off-by: Madhumitha Prabakaran > > > > --- > > Changes in v2 > > > > 1) Fix my own error of removing function call from the variable. > > 2) Align the function parameters with parentheses. > > > > --- > > --- > > .../staging/vc04_services/bcm2835-camera/controls.c | 10 ++++------ > > 1 file changed, 4 insertions(+), 6 deletions(-) > > > > diff --git a/drivers/staging/vc04_services/bcm2835-camera/controls.c b/drivers/staging/vc04_services/bcm2835-camera/controls.c > > index e39ab5fae724..71eb349c3138 100644 > > --- a/drivers/staging/vc04_services/bcm2835-camera/controls.c > > +++ b/drivers/staging/vc04_services/bcm2835-camera/controls.c > > @@ -607,18 +607,16 @@ static int ctrl_set_bitrate(struct bm2835_mmal_dev *dev, > > struct v4l2_ctrl *ctrl, > > const struct bm2835_mmal_v4l2_ctrl *mmal_ctrl) > > { > > - int ret; > > struct vchiq_mmal_port *encoder_out; > > > > dev->capture.encode_bitrate = ctrl->val; > > > > encoder_out = &dev->component[MMAL_COMPONENT_VIDEO_ENCODE]->output[0]; > > > > - ret = vchiq_mmal_port_parameter_set(dev->instance, encoder_out, > > - mmal_ctrl->mmal_id, > > - &ctrl->val, sizeof(ctrl->val)); > > - ret = 0; > > - return ret; > > + vchiq_mmal_port_parameter_set(dev->instance, encoder_out, > > + mmal_ctrl->mmal_id, &ctrl->val, > > + sizeof(ctrl->val)); > > + return 0; > > } > > Why does this function even return anything at all if it can not fail? I looked at the function vchiq_mmal_port_parameter_set, which calls another function for setting the port parameters, which inturns sends an synchronous message. If it is able to send the message successfully, it returns 0. It can also fail and can return any other value. Also the function ctrl_set_bitrate is not evaluated anywhere for true or false, so it is safe to return the value we get from vchiq_mmal_port_parameter_set instead of returning 0 always. > > Why not return the value that vchiq_mmal_port_parameter_set() returned? > I will change the code to return the value from vchiq_mmal_port_parameter_set directly. > thanks, > > greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel