From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67A38C282DD for ; Tue, 23 Apr 2019 16:06:06 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3832B20693 for ; Tue, 23 Apr 2019 16:06:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ZwNW/D7w" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3832B20693 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VXnduG/QsWjM0LpJcRIpAKZW3Wv/220RtXXvDh50Fqs=; b=ZwNW/D7wD5qsi5 wdSdohYqiy0i0fdOICWd5j0Jaqcu4l7U6WudriJIAYgjV3aiU+AgMXy6YhabmMnGijmV/bGHJoXEs 5mXJouR25hsCvPpdHqJz/9e2TWxK2zXLtAbqBGnS53VSNAycPOUkTltrMF2UrWbnrd29crEypVBYo 4Cxb3pQOAzCivK68SzHEXGhb+uhn//UuadpOv8rcElyXA/M/oSvj5jN8Vju+bU6qs6UYyyWEGz7gw TlBU1+Oy+vawwZNZ71oL+YdN5dGtrzTg60J82gnST4DDlK2XuoCHXicQVEoEVQMPPvo5FwJj0AsGM O7hbQUmhBKmDZeaITnQA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hIxvj-0002wu-Vh; Tue, 23 Apr 2019 16:05:59 +0000 Received: from relay9-d.mail.gandi.net ([217.70.183.199]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hIxvh-0002vb-09 for linux-arm-kernel@lists.infradead.org; Tue, 23 Apr 2019 16:05:58 +0000 X-Originating-IP: 90.89.68.76 Received: from localhost (lfbn-1-10718-76.w90-89.abo.wanadoo.fr [90.89.68.76]) (Authenticated sender: maxime.ripard@bootlin.com) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id D06DBFF811; Tue, 23 Apr 2019 16:05:45 +0000 (UTC) Date: Tue, 23 Apr 2019 18:05:45 +0200 From: Maxime Ripard To: =?utf-8?B?Q2zDqW1lbnQgUMOpcm9u?= Subject: Re: [PATCH v2 2/3] arm64: dts: allwinner: h6: add r_watchog node Message-ID: <20190423160545.muolantrdppz35rz@flea> References: <20190411154534.25563-1-peron.clem@gmail.com> <20190411154534.25563-3-peron.clem@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190423_090557_186852_97A4BF32 X-CRM114-Status: GOOD ( 17.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree , linux-sunxi , linux-kernel , Chen-Yu Tsai , Rob Herring , linux-arm-kernel , Icenowy Zheng Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Apr 19, 2019 at 09:00:42PM +0200, Cl=E9ment P=E9ron wrote: > Hi, > > On Thu, 11 Apr 2019 at 17:34, Cl=E9ment P=E9ron wr= ote: > > > > Allwinner H6 has a r_watchdog similar to A64. > > > > Declare it in the device-tree. > > > > Signed-off-by: Cl=E9ment P=E9ron > > --- > > arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi b/arch/arm64/= boot/dts/allwinner/sun50i-h6.dtsi > > index 5c2f5451227b..66dc684a378e 100644 > > --- a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi > > @@ -622,6 +622,13 @@ > > #reset-cells =3D <1>; > > }; > > > > + r_watchdog: watchdog@7020400 { > > + compatible =3D "allwinner,sun50i-a64-wdt", > > + "allwinner,sun6i-a31-wdt"; > > + reg =3D <0x07020400 0x20>; > > + interrupts =3D ; > > + }; > > I have set the same compatible as A64 because regarding the User > Manual they have exactly the same memory mapping. > However we don't know really if it's the same IP version, maybe there > will be an errata one day. > So I would like to know if it's better to define the h6-wdt also > compatible =3D "allwinner,sun50i-h6-wdt", "allwinner,sun50i-a64-wdt", > "allwinner,sun6i-a31-wdt"; > > I would say Yes, but with this logic we would have to had a new > compatible each time there is a new SoC. Why not just having the A31 compatible? Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel