From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81653C10F03 for ; Tue, 23 Apr 2019 16:17:24 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4D2AC208E4 for ; Tue, 23 Apr 2019 16:17:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="YDYeTQoX"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="W9GKDDVj" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4D2AC208E4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=55TX0VzAiBIkvykeSOVDG9Ck9iI1IhnEQf6q7wTh23M=; b=YDYeTQoXx4/DbB Z8zqaAe7upGHqaFLGZwLlUwzEVkIUhLWdKicwMs1XGKrlGsWogO2CUi0Uho5JS/i+Aj3G+Srsg9ho iS3JQ6TdwxsZtvcAyAXKiNpPlqxi1n1ATsf43uToQbnak3/GWWmMPJuteqG+14OhjDW0278zwraSF dLfFGfCaUazTevnbD6OTmSQOzp0cLUNvRFz04CDmrcPGz/Ucb9aCvdTQpM7oNwEOG5LRJhXbY/Rkr fJ8I27Bh3YNKFITbB7XTq0LpXo0Z7NLTjR3RDi7eNDWb0SHXZFYpcdzT203Js48rtG8FKPChNRucW VOSnYYqgvydoOLodHrZQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hIy6d-0007Er-F7; Tue, 23 Apr 2019 16:17:15 +0000 Received: from mail-pg1-x542.google.com ([2607:f8b0:4864:20::542]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hIy6a-0007ER-AX for linux-arm-kernel@lists.infradead.org; Tue, 23 Apr 2019 16:17:13 +0000 Received: by mail-pg1-x542.google.com with SMTP id 85so7865333pgc.3 for ; Tue, 23 Apr 2019 09:17:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Uoo4zU9bRplcM88Gy3z7EAgvGkM989NlmEdwPQZGae8=; b=W9GKDDVjS0xCeXhVdmlvraJ8iHMF2HFs55cDzBQfSwOCPCNMaIUDSPsuO1sWbTjYBI fB+rcF1uQTc//aGnRJ1Sp719J0Fmm8KmACXUp76lWkPL/fu2dOkc0CWrtSsqeulCXkaS 0iSz6vf1Ci/2s9h91MCgVNrWKqit3HoPETw4E4DWlumY4ya5ISwpx8fm48hsJbUhIh98 6Qzv1gzbt6cC2uL77BTK87Z9aB2/5xmvi5NQa00pdEGAFJp1peNef7FyMqUdkICrb5yB Rhd0tnEfeZhX+aKVxtA7lHsfFY3GJfm+gc5VwAB9Ca8xqBwSXIBdjoR2RPjbJ9f7pRCj WKOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Uoo4zU9bRplcM88Gy3z7EAgvGkM989NlmEdwPQZGae8=; b=ZiWXoAsF1Whaznn5QWHgReWDJPqo2MlAcguD9I9H8sWoKlJ/S20LYqBO3ODOj0+J5y hoS1UOG7Rd7OW4SqH6zmCRoz1YzvS6uw2yaVXKw21Gu52vMv2vduBBxaxOQPajxkxiq+ SDlQzqvI4616n06326JUSGXRG10peMyVPjL5S7WTHFvOZJofXSKo62A18cEytTIVOHZc 75ua9Quu0TmTfgCX+dbUM62DJkb+2eYeHkHlvIRAIxEYNmNdvvl78ePTZ9Gm9CDCrFqM Y6wD9GnDdh+BSD2hLWG54s5J7XL9Az2CWsn7fu5rwO59+ODqcqsBASeZYot5kc0uDr4F pUdg== X-Gm-Message-State: APjAAAUMRiJV24OPM+LYoOp8uJYPcg36QQ4lp5v1nkIp8YPro86MZOUR KAUoo95bo37/izP++vrWH6dICglY9BY= X-Google-Smtp-Source: APXvYqwt+NHYDXHs8rvq7qzJYUyXlRSTBxHgj1E7lSJ1DIGbF4MuoRd9x2YDkzTgS6GI+BAixC4LGQ== X-Received: by 2002:a63:6fc1:: with SMTP id k184mr25772523pgc.239.1556036231587; Tue, 23 Apr 2019 09:17:11 -0700 (PDT) Received: from xps15 (S0106002369de4dac.cg.shawcable.net. [68.147.8.254]) by smtp.gmail.com with ESMTPSA id f13sm8045094pgr.35.2019.04.23.09.17.10 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 23 Apr 2019 09:17:10 -0700 (PDT) Date: Tue, 23 Apr 2019 10:17:08 -0600 From: Mathieu Poirier To: Suzuki K Poulose Subject: Re: [PATCH v2 28/36] coresight: platform: Use fwnode handle for device search Message-ID: <20190423161708.GB21070@xps15> References: <1555344260-12375-1-git-send-email-suzuki.poulose@arm.com> <1555344260-12375-29-git-send-email-suzuki.poulose@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1555344260-12375-29-git-send-email-suzuki.poulose@arm.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190423_091712_376956_0CFFD59C X-CRM114-Status: GOOD ( 18.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: coresight@lists.linaro.org, rjw@rjwysocki.net, linux-kernel@vger.kernel.org, robert.walker@arm.com, linux-arm-kernel@lists.infradead.org, mike.leach@linaro.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Apr 15, 2019 at 05:04:11PM +0100, Suzuki K Poulose wrote: > We match of_node while searching for a device. Make this > more generic in preparation for the ACPI support by using > fwnode_handle. > > Cc: Mathieu Poirier > Signed-off-by: Suzuki K Poulose > --- > drivers/hwtracing/coresight/coresight-platform.c | 17 +++++++---------- > 1 file changed, 7 insertions(+), 10 deletions(-) > > diff --git a/drivers/hwtracing/coresight/coresight-platform.c b/drivers/hwtracing/coresight/coresight-platform.c > index a408b01..318a6ff 100644 > --- a/drivers/hwtracing/coresight/coresight-platform.c > +++ b/drivers/hwtracing/coresight/coresight-platform.c > @@ -36,14 +36,8 @@ static int coresight_alloc_conns(struct device *dev, > return 0; > } > > -#ifdef CONFIG_OF > -static int of_dev_node_match(struct device *dev, void *data) > -{ > - return dev->of_node == data; > -} > - > static struct device * > -of_coresight_get_endpoint_device(struct device_node *endpoint) > +coresight_find_device_by_fwnode(struct fwnode_handle *fwnode) > { > struct device *dev = NULL; > > @@ -52,7 +46,7 @@ of_coresight_get_endpoint_device(struct device_node *endpoint) > * platform bus. > */ > dev = bus_find_device(&platform_bus_type, NULL, > - endpoint, of_dev_node_match); > + fwnode, device_fwnode_match); > if (dev) > return dev; > > @@ -61,9 +55,10 @@ of_coresight_get_endpoint_device(struct device_node *endpoint) > * looking for the device that matches the endpoint node. > */ > return bus_find_device(&amba_bustype, NULL, > - endpoint, of_dev_node_match); > + fwnode, device_fwnode_match); > } > > +#ifdef CONFIG_OF > static inline bool of_coresight_legacy_ep_is_input(struct device_node *ep) > { > return of_property_read_bool(ep, "slave-mode"); > @@ -191,6 +186,7 @@ static int of_coresight_parse_endpoint(struct device *dev, > struct device_node *rparent = NULL; > struct device_node *rep = NULL; > struct device *rdev = NULL; > + struct fwnode_handle *rdev_fwnode; > > do { > /* Parse the local port details */ > @@ -209,8 +205,9 @@ static int of_coresight_parse_endpoint(struct device *dev, > if (of_graph_parse_endpoint(rep, &rendpoint)) > break; > > + rdev_fwnode = of_fwnode_handle(rparent); > /* If the remote device is not available, defer probing */ > - rdev = of_coresight_get_endpoint_device(rparent); > + rdev = coresight_find_device_by_fwnode(rdev_fwnode); > if (!rdev) { > ret = -EPROBE_DEFER; > break; Reviewed-by: Mathieu Poirier > -- > 2.7.4 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel