linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Mark Rutland <mark.rutland@arm.com>
To: Dave Martin <Dave.Martin@arm.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will.deacon@arm.com>,
	linux-arm-kernel@lists.infradead.org,
	Andrew Murray <andrew.murray@arm.com>
Subject: Re: [PATCH] arm64: Expose SVE2 features for userspace
Date: Tue, 23 Apr 2019 17:28:52 +0100	[thread overview]
Message-ID: <20190423162852.GF56999@lakrids.cambridge.arm.com> (raw)
In-Reply-To: <1555609298-10498-1-git-send-email-Dave.Martin@arm.com>

On Thu, Apr 18, 2019 at 06:41:38PM +0100, Dave Martin wrote:
> This patch provides support for reporting the presence of SVE2 and
> its optional features to userspace.
> 
> This will also enable visibility of SVE2 for guests, when KVM
> support for SVE-enabled guests is available.
> 
> Signed-off-by: Dave Martin <Dave.Martin@arm.com>
> ---
> 
> This patch is based on
> 
> git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git
> f645d37e281f ("Merge remote-tracking branch 'arm64/for-next/mmiowb' into for-next/core")
> 
> (for Andrew Murray's HWCAP2 support).
> 
> 
> Tested with the Arm Fast Model SVE2 plugin.
> 
> For KVM, tested with:
> 
> git://linux-arm.org/linux-dm.git sve-kvm-fixes/v2/head
> http://linux-arm.org/git?p=linux-dm.git;a=shortlog;h=refs/heads/sve-kvm-fixes/v2/head
> 
> (which is also now merged to kvmarm/next).
> 
>  Documentation/arm64/cpu-feature-registers.txt | 16 ++++++++++++++++
>  Documentation/arm64/elf_hwcaps.txt            | 24 ++++++++++++++++++++++++
>  Documentation/arm64/sve.txt                   | 17 +++++++++++++++++
>  arch/arm64/Kconfig                            |  3 +++
>  arch/arm64/include/asm/hwcap.h                |  6 ++++++
>  arch/arm64/include/asm/sysreg.h               | 14 ++++++++++++++
>  arch/arm64/include/uapi/asm/hwcap.h           |  6 ++++++
>  arch/arm64/kernel/cpufeature.c                | 17 ++++++++++++++++-
>  arch/arm64/kernel/cpuinfo.c                   |  6 ++++++
>  9 files changed, 108 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/arm64/cpu-feature-registers.txt b/Documentation/arm64/cpu-feature-registers.txt
> index d4b4dd1f..4e47a01 100644
> --- a/Documentation/arm64/cpu-feature-registers.txt
> +++ b/Documentation/arm64/cpu-feature-registers.txt
> @@ -209,6 +209,22 @@ infrastructure:
>       | AT                           | [35-32] |    y    |
>       x--------------------------------------------------x
>  
> +  6) ID_AA64ZFR0_EL1 - SVE feature ID register 0
> +
> +     x--------------------------------------------------x
> +     | Name                         |  bits   | visible |
> +     |--------------------------------------------------|
> +     | SM4                          | [43-40] |    y    |
> +     x--------------------------------------------------x
> +     | SHA3                         | [35-32] |    y    |
> +     x--------------------------------------------------x
> +     | BitPerm                      | [19-16] |    y    |
> +     x--------------------------------------------------x
> +     | AES                          | [7-4]   |    y    |
> +     x--------------------------------------------------x
> +     | SVEVer                       | [3-0]   |    y    |
> +     x--------------------------------------------------x

Trivial nit: for consistency with all the other tables, please only use
'x' at the corners, and use '|' at the edges.

Otherwise, this looks good to me; sorry for the late style nit!

Thanks,
Mark.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2019-04-23 16:29 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-18 17:41 [PATCH] arm64: Expose SVE2 features for userspace Dave Martin
2019-04-23 15:32 ` Will Deacon
2019-04-23 15:48   ` Dave Martin
2019-04-23 16:28 ` Mark Rutland [this message]
2019-04-23 16:30   ` Will Deacon
2019-04-23 16:45     ` Dave Martin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190423162852.GF56999@lakrids.cambridge.arm.com \
    --to=mark.rutland@arm.com \
    --cc=Dave.Martin@arm.com \
    --cc=andrew.murray@arm.com \
    --cc=catalin.marinas@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).