linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Dave Martin <Dave.Martin@arm.com>
To: Will Deacon <will.deacon@arm.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	linux-arm-kernel@lists.infradead.org,
	Andrew Murray <andrew.murray@arm.com>
Subject: Re: [PATCH] arm64: Expose SVE2 features for userspace
Date: Tue, 23 Apr 2019 17:45:27 +0100	[thread overview]
Message-ID: <20190423164527.GR3567@e103592.cambridge.arm.com> (raw)
In-Reply-To: <20190423163017.GA21047@fuggles.cambridge.arm.com>

On Tue, Apr 23, 2019 at 05:30:17PM +0100, Will Deacon wrote:
> On Tue, Apr 23, 2019 at 05:28:52PM +0100, Mark Rutland wrote:
> > On Thu, Apr 18, 2019 at 06:41:38PM +0100, Dave Martin wrote:
> > > diff --git a/Documentation/arm64/cpu-feature-registers.txt b/Documentation/arm64/cpu-feature-registers.txt
> > > index d4b4dd1f..4e47a01 100644
> > > --- a/Documentation/arm64/cpu-feature-registers.txt
> > > +++ b/Documentation/arm64/cpu-feature-registers.txt
> > > @@ -209,6 +209,22 @@ infrastructure:
> > >       | AT                           | [35-32] |    y    |
> > >       x--------------------------------------------------x
> > >  
> > > +  6) ID_AA64ZFR0_EL1 - SVE feature ID register 0
> > > +
> > > +     x--------------------------------------------------x
> > > +     | Name                         |  bits   | visible |
> > > +     |--------------------------------------------------|
> > > +     | SM4                          | [43-40] |    y    |
> > > +     x--------------------------------------------------x
> > > +     | SHA3                         | [35-32] |    y    |
> > > +     x--------------------------------------------------x
> > > +     | BitPerm                      | [19-16] |    y    |
> > > +     x--------------------------------------------------x
> > > +     | AES                          | [7-4]   |    y    |
> > > +     x--------------------------------------------------x
> > > +     | SVEVer                       | [3-0]   |    y    |
> > > +     x--------------------------------------------------x
> > 
> > Trivial nit: for consistency with all the other tables, please only use
> > 'x' at the corners, and use '|' at the edges.
> > 
> > Otherwise, this looks good to me; sorry for the late style nit!
> 
> I'll fix that up in my tree.

Thanks.  I didn't even spot the difference...

Cheers
---Dave

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

      reply	other threads:[~2019-04-23 16:45 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-18 17:41 [PATCH] arm64: Expose SVE2 features for userspace Dave Martin
2019-04-23 15:32 ` Will Deacon
2019-04-23 15:48   ` Dave Martin
2019-04-23 16:28 ` Mark Rutland
2019-04-23 16:30   ` Will Deacon
2019-04-23 16:45     ` Dave Martin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190423164527.GR3567@e103592.cambridge.arm.com \
    --to=dave.martin@arm.com \
    --cc=andrew.murray@arm.com \
    --cc=catalin.marinas@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=mark.rutland@arm.com \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).