From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A174EC10F03 for ; Tue, 23 Apr 2019 17:59:29 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 72AC920685 for ; Tue, 23 Apr 2019 17:59:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Z11i8sFY"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="MpgLXP7t" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 72AC920685 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GyOg3d2HZK46r4vINfPwMAMm+mH4S3rcDb6doCuSKto=; b=Z11i8sFYmb2kiW sy0aI01qzdqUcxArrFzWQsG7ae6ADyD+xJGyyxbEQiCyHxNjuAOvbNERS6thrZjMKwb0t8HXjCZtD AO+lnPRCBfXdtJb800AHMykc4lDYh28yvqwveAITrOrILXU6+mZBm/t/Bh6I9ZsjplMOOTdk9Qd/0 73QPFPy9HlLxQm4bO0hG57d/RH2JesQdhjo/M/76YsJYbIu2O69EehpA7outWFlFPJL3oJxbFaA+C 0wxTA8wOAR6X31Y7oXvWtEhOMPiiqg5+LmUuIWP7Fo9K3FFzKjQT1IpIeDjadtlT5dCB5pdMDMsri LvbPlpBRzrevC0Sw8ueg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hIzhQ-0003cV-Sn; Tue, 23 Apr 2019 17:59:20 +0000 Received: from mail-pl1-x643.google.com ([2607:f8b0:4864:20::643]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hIzhN-0003by-6a for linux-arm-kernel@lists.infradead.org; Tue, 23 Apr 2019 17:59:18 +0000 Received: by mail-pl1-x643.google.com with SMTP id x15so3544835pln.9 for ; Tue, 23 Apr 2019 10:59:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=6/C6S80/bNvps6yDI1zPpR7sXzDiP/eSGJf2+LZbGpI=; b=MpgLXP7t/+4lOc/0vvwunCC3y08IJLih1EUz/sPPK6YxU4Zl73GdiDsIZ0/bkwTVPK MHxATdc8RJ+lDlzq26vnVdT7SAtAej3rLneMGovdnXi7Ll610SwrzBISEoM7MS2+ZLOx 0N6qNgxPUjqm6PH2iUG5tsCVZJzjAzzruCFX1PHxkW609gCf88BfpiMZQ4/hGNiNkiO/ RSZRn+P6v/Vvjbs/uhcBMCT1ok2o75YPfw/gxvTQye4dxwru9oAh6Bk4TjMX6mUVWbz5 8gesnornO2dG15MobAEHmX7436mT7nFcdRX3wYnok+tPk2IB405ZEqTs8xWJ95U0DcdD /9ig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=6/C6S80/bNvps6yDI1zPpR7sXzDiP/eSGJf2+LZbGpI=; b=Qe/yPCTXVJNthr0yA6S0/maUeJz3WymXuNer+ztf3VxLOMnskNi5BG2S1EsfICRMd+ qxwPM/Mds612OhM5M0DINjK+fN/KEzcrPntLx4CTWL7U0/5vpnoEWComnIydOYId5cN3 RYgwGns9IngCrGKKvuKYrF1II/CUJlkMN4jybTXZ/xo9ET3UBAlJz6oA+aW5oaj1qfiV EMnsKzsjDWprGxfgMpysvLEmJd5+zFUsqb03mZiGnnE3G/EgazOmig0GdpTmu9zHOCdo OVUwivxsf6M0I/h2h7/L06Sq68/5KPiHRNFxPhYG5lb89OsW10gQi0jAH5Yrt7/BmaMp KFsQ== X-Gm-Message-State: APjAAAW9J2VRBYWMAjz2CUQ8a/f9fv2tnJOpABf0Ie21qf3XApfd3EOU eP5GVQoyApRBJdqhC8ssZvn4+g== X-Google-Smtp-Source: APXvYqwB59UTLItpFcdUz+BR2BceSkfJ1A/DX4BziQCMSWrQrrWBA155QthkJICDMGJSqwvfVgHNtQ== X-Received: by 2002:a17:902:1621:: with SMTP id g30mr27344702plg.168.1556042356666; Tue, 23 Apr 2019 10:59:16 -0700 (PDT) Received: from xps15 (S0106002369de4dac.cg.shawcable.net. [68.147.8.254]) by smtp.gmail.com with ESMTPSA id s19sm21223241pfe.74.2019.04.23.10.59.15 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 23 Apr 2019 10:59:15 -0700 (PDT) Date: Tue, 23 Apr 2019 11:59:13 -0600 From: Mathieu Poirier To: Suzuki K Poulose Subject: Re: [PATCH v2 31/36] coresight: stm: ACPI support for parsing stimulus base Message-ID: <20190423175913.GD21070@xps15> References: <1555344260-12375-1-git-send-email-suzuki.poulose@arm.com> <1555344260-12375-32-git-send-email-suzuki.poulose@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1555344260-12375-32-git-send-email-suzuki.poulose@arm.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190423_105917_253013_3EF13CFD X-CRM114-Status: GOOD ( 19.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: coresight@lists.linaro.org, rjw@rjwysocki.net, linux-kernel@vger.kernel.org, robert.walker@arm.com, linux-arm-kernel@lists.infradead.org, mike.leach@linaro.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Apr 15, 2019 at 05:04:14PM +0100, Suzuki K Poulose wrote: > The stimulus base for STM device must be listed as the second memory > resource, followed by the programming base address as described in > "Section 2.3 Resources" in ACPI for CoreSightTM 1.0 Platform Design > documen (DEN0067). Thank you for adding more information. > > Add support for parsing the information for ACPI. > > Cc: Mathieu Poirier > Cc: "Rafael J. Wysocki" > Signed-off-by: Suzuki K Poulose > --- > drivers/hwtracing/coresight/coresight-stm.c | 43 +++++++++++++++++++++++++++++ > 1 file changed, 43 insertions(+) > > diff --git a/drivers/hwtracing/coresight/coresight-stm.c b/drivers/hwtracing/coresight/coresight-stm.c > index 2d6ae00..7cf2fe4 100644 > --- a/drivers/hwtracing/coresight/coresight-stm.c > +++ b/drivers/hwtracing/coresight/coresight-stm.c > @@ -16,6 +16,7 @@ > * (C) 2015-2016 Chunyan Zhang > */ > #include > +#include > #include > #include > #include > @@ -716,10 +717,52 @@ static inline int of_stm_get_stimulus_area(struct device *dev, > } > #endif > > +#ifdef CONFIG_ACPI > +static int acpi_stm_get_stimulus_area(struct device *dev, struct resource *res) > +{ > + int rc; > + bool found_base = false; > + struct resource_entry *rent; > + LIST_HEAD(res_list); > + > + struct acpi_device *adev = ACPI_COMPANION(dev); > + > + if (!adev) > + return -ENODEV; > + rc = acpi_dev_get_resources(adev, &res_list, NULL, NULL); > + if (rc < 0) > + return rc; > + > + rc = -ENOENT; > + list_for_each_entry(rent, &res_list, node) { > + if (resource_type(rent->res) != IORESOURCE_MEM) > + continue; > + if (found_base) { > + *res = *rent->res; > + rc = 0; > + break; > + } > + > + found_base = true; > + } I would copy the description in the changelog just before the list_for_each_entry() loop. > + > + acpi_dev_free_resource_list(&res_list); > + return rc; > +} > +#else > +static inline int acpi_stm_get_stimulus_area(struct device *dev, > + struct resource *res) > +{ > + return -ENOENT; > +} > +#endif > + > static int stm_get_stimulus_area(struct device *dev, struct resource *res) > { > if (dev->of_node) I noticed the direct access of ->of_node in patch 16 and thought it was a little odd that is_of_node() wasn't used. > return of_stm_get_stimulus_area(dev, res); > + else if (is_acpi_node(dev->fwnode)) > + return acpi_stm_get_stimulus_area(dev, res); > return -ENOENT; With the above: Reviewed-by: Mathieu Poirier > } > > -- > 2.7.4 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel